You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/12/08 01:11:12 UTC
Review Request 64433: HIVE-18203 change the way WM is enabled and
allow dropping the last resource plan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64433/
-----------------------------------------------------------
Review request for hive, Harish Jaiprakash and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 62c9172ef5
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 55ef8de9a5
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 8417ebb7d5
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java dbdbbf25db
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 50bdce89a4
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java a09b7961c2
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 1dcfe9dd28
ql/src/java/org/apache/hadoop/hive/ql/parse/ResourcePlanParser.g 95c87259c5
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java d70d52054d
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java c58e4507f2
ql/src/test/queries/clientpositive/resourceplan.q 002b21c1b9
ql/src/test/results/clientpositive/llap/resourceplan.q.out 093e5d58b6
service/src/java/org/apache/hive/service/server/HiveServer2.java 223be6aa32
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6e0da5781e
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java fc254c6f53
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 573ac0173d
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 2e80c9d3b1
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java 75fbfa23d2
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java da518ab6e3
standalone-metastore/src/main/thrift/hive_metastore.thrift 1085ce566a
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 24c59f2f1b
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 1e4fe5d973
Diff: https://reviews.apache.org/r/64433/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 64433: HIVE-18203 change the way WM is enabled and
allow dropping the last resource plan
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Dec. 11, 2017, 4:56 a.m., Harish Jaiprakash wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
> > Lines 939 (patched)
> > <https://reviews.apache.org/r/64433/diff/1/?file=1910967#file1910967line939>
> >
> > Yup, seem unintuitive to use enable in one and disable in another command. Is it better to add an extension to ALTER RESOURCE PLAN `plan_name` FORCE_DEACTIVATE;
I feel like this is error prone... I wanted to make it explicit to the admin that WM is being disabled, so they don't deactivate the plan just to edit it a little bit and throw everything into chaos.
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64433/#review193371
-----------------------------------------------------------
On Dec. 8, 2017, 1:11 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64433/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 1:11 a.m.)
>
>
> Review request for hive, Harish Jaiprakash and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 62c9172ef5
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 55ef8de9a5
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 8417ebb7d5
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java dbdbbf25db
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 50bdce89a4
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java a09b7961c2
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 1dcfe9dd28
> ql/src/java/org/apache/hadoop/hive/ql/parse/ResourcePlanParser.g 95c87259c5
> ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java d70d52054d
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java c58e4507f2
> ql/src/test/queries/clientpositive/resourceplan.q 002b21c1b9
> ql/src/test/results/clientpositive/llap/resourceplan.q.out 093e5d58b6
> service/src/java/org/apache/hive/service/server/HiveServer2.java 223be6aa32
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6e0da5781e
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java fc254c6f53
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 573ac0173d
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 2e80c9d3b1
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java 75fbfa23d2
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java da518ab6e3
> standalone-metastore/src/main/thrift/hive_metastore.thrift 1085ce566a
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 24c59f2f1b
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 1e4fe5d973
>
>
> Diff: https://reviews.apache.org/r/64433/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 64433: HIVE-18203 change the way WM is enabled and
allow dropping the last resource plan
Posted by Harish Jaiprakash <hj...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64433/#review193371
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
Lines 939 (patched)
<https://reviews.apache.org/r/64433/#comment271919>
Yup, seem unintuitive to use enable in one and disable in another command. Is it better to add an extension to ALTER RESOURCE PLAN `plan_name` FORCE_DEACTIVATE;
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Line 9781 (original), 9802 (patched)
<https://reviews.apache.org/r/64433/#comment271918>
If alter is a rename then, the name displayed here would be new name and hence the old name was being passed to ensure errors are logged with current name.
- Harish Jaiprakash
On Dec. 8, 2017, 6:41 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64433/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 6:41 a.m.)
>
>
> Review request for hive, Harish Jaiprakash and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 62c9172ef5
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 55ef8de9a5
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 8417ebb7d5
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java dbdbbf25db
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 50bdce89a4
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java a09b7961c2
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 1dcfe9dd28
> ql/src/java/org/apache/hadoop/hive/ql/parse/ResourcePlanParser.g 95c87259c5
> ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java d70d52054d
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java c58e4507f2
> ql/src/test/queries/clientpositive/resourceplan.q 002b21c1b9
> ql/src/test/results/clientpositive/llap/resourceplan.q.out 093e5d58b6
> service/src/java/org/apache/hive/service/server/HiveServer2.java 223be6aa32
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6e0da5781e
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java fc254c6f53
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 573ac0173d
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 2e80c9d3b1
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java 75fbfa23d2
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java da518ab6e3
> standalone-metastore/src/main/thrift/hive_metastore.thrift 1085ce566a
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 24c59f2f1b
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 1e4fe5d973
>
>
> Diff: https://reviews.apache.org/r/64433/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 64433: HIVE-18203 change the way WM is enabled and
allow dropping the last resource plan
Posted by Harish Jaiprakash <hj...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64433/#review194051
-----------------------------------------------------------
Ship it!
Ship It!
- Harish Jaiprakash
On Dec. 16, 2017, 2:49 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64433/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2017, 2:49 a.m.)
>
>
> Review request for hive, Harish Jaiprakash and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 62c9172ef5
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 55ef8de9a5
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 3c1b8d080c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java f0481fcf25
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 50bdce89a4
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java a09b7961c2
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 1dcfe9dd28
> ql/src/java/org/apache/hadoop/hive/ql/parse/ResourcePlanParser.g 95c87259c5
> ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java d70d52054d
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 98f5c58ab8
> ql/src/test/queries/clientpositive/resourceplan.q fc924a2f95
> ql/src/test/results/clientpositive/llap/resourceplan.q.out 7f3e784457
> service/src/java/org/apache/hive/service/server/HiveServer2.java 223be6aa32
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6e0da5781e
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java fc254c6f53
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 573ac0173d
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 2c92bb2056
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java 75fbfa23d2
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java da518ab6e3
> standalone-metastore/src/main/thrift/hive_metastore.thrift 1085ce566a
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 24c59f2f1b
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 1e4fe5d973
>
>
> Diff: https://reviews.apache.org/r/64433/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 64433: HIVE-18203 change the way WM is enabled and
allow dropping the last resource plan
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64433/
-----------------------------------------------------------
(Updated Dec. 15, 2017, 9:19 p.m.)
Review request for hive, Harish Jaiprakash and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 62c9172ef5
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 55ef8de9a5
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 3c1b8d080c
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java f0481fcf25
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 50bdce89a4
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java a09b7961c2
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 1dcfe9dd28
ql/src/java/org/apache/hadoop/hive/ql/parse/ResourcePlanParser.g 95c87259c5
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java d70d52054d
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 98f5c58ab8
ql/src/test/queries/clientpositive/resourceplan.q fc924a2f95
ql/src/test/results/clientpositive/llap/resourceplan.q.out 7f3e784457
service/src/java/org/apache/hive/service/server/HiveServer2.java 223be6aa32
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6e0da5781e
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java fc254c6f53
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 573ac0173d
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 2c92bb2056
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java 75fbfa23d2
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java da518ab6e3
standalone-metastore/src/main/thrift/hive_metastore.thrift 1085ce566a
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 24c59f2f1b
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 1e4fe5d973
Diff: https://reviews.apache.org/r/64433/diff/2/
Changes: https://reviews.apache.org/r/64433/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin