[GitHub] matthiasblaesing opened a new pull request #181: [NETBEANS-54] Module Review libs.osgi (followup)

[GitBox <gi...@apache.org>]

matthiasblaesing opened a new pull request #181: [NETBEANS-54] Module Review libs.osgi (followup)
URL: https://github.com/apache/incubator-netbeans/pull/181
 
 
   Maven central does not hold the original netbeans artifact 
   osgi.cmpn-4.2, but a superset of that: 
   
   <dependency>
       <groupId>org.osgi</groupId>
       <artifactId>org.osgi.compendium</artifactId>
       <version>4.2.0</version>
   </dependency>
   
   That artifact holds not only the compiled binaries, but also the
   java sources in a subfolder "OSGI-OPT". To get the original netbeans
   file, the jar is repacked and the folder is stripped. The resulting
   zip is not identical to the original binary, but the difference is
   in the zip structure, after expanding the original contents and the
   new file are identical.
   
   This PR is a followup for #104 which introduced a maven coordinate,
   that can't be satisfied from maven central.
   
   There are newer osgi compendium jar on maven central and it looks
   as if at least 4.3.1 would also work, but updating libraries should be
   a separate task from this cleanup task.
   
   This approach was inspired by @vieiro who first came up with
   building modified binaries for maven sources.
   
   @geertjanw could you please have a look at this and see if it works for you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services