You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/02/15 07:39:09 UTC
Review Request 31055: SQOOP-2101: Add SqoopClient support to call
Restful API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31055/
-----------------------------------------------------------
Review request for Sqoop and shen guoquan.
Repository: sqoop-sqoop2
Description
-------
Add SqoopClient support to call Restful API
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9e15c030a0b21bc5e0aa64184e13c2dc78cf9507
client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 1825cf3c96832283f589a77848da09c81abaec4b
Diff: https://reviews.apache.org/r/31055/diff/
Testing
-------
local
Thanks,
richard zhou
Re: Review Request 31055: SQOOP-2101: Add SqoopClient support to call
Restful API
Posted by richard zhou <ri...@intel.com>.
> On Feb. 15, 2015, 7:45 a.m., Abraham Elmahrek wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 568
> > <https://reviews.apache.org/r/31055/diff/1/?file=864577#file864577line568>
> >
> > getRoles twice?
>
> richard zhou wrote:
> It is a little tricky, but it is correct.
> The first getRoles function is to get the RolesBean, and the second getRoles is to get the Role List
To be more clear, I have changed function name in resourceRequests from getRoles to readRoles.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31055/#review72528
-----------------------------------------------------------
On Feb. 15, 2015, 8:28 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31055/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2015, 8:28 a.m.)
>
>
> Review request for Sqoop and shen guoquan.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add SqoopClient support to call Restful API
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9e15c030a0b21bc5e0aa64184e13c2dc78cf9507
> client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 1825cf3c96832283f589a77848da09c81abaec4b
>
> Diff: https://reviews.apache.org/r/31055/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 31055: SQOOP-2101: Add SqoopClient support to call
Restful API
Posted by richard zhou <ri...@intel.com>.
> On Feb. 15, 2015, 7:45 a.m., Abraham Elmahrek wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 568
> > <https://reviews.apache.org/r/31055/diff/1/?file=864577#file864577line568>
> >
> > getRoles twice?
It is a little tricky, but it is correct.
The first getRoles function is to get the RolesBean, and the second getRoles is to get the Role List
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31055/#review72528
-----------------------------------------------------------
On Feb. 15, 2015, 6:39 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31055/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2015, 6:39 a.m.)
>
>
> Review request for Sqoop and shen guoquan.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add SqoopClient support to call Restful API
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9e15c030a0b21bc5e0aa64184e13c2dc78cf9507
> client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 1825cf3c96832283f589a77848da09c81abaec4b
>
> Diff: https://reviews.apache.org/r/31055/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 31055: SQOOP-2101: Add SqoopClient support to call
Restful API
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31055/#review72528
-----------------------------------------------------------
Ship it!
Assuming this is functional... LGTM.
client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/31055/#comment118594>
getRoles twice?
- Abraham Elmahrek
On Feb. 15, 2015, 6:39 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31055/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2015, 6:39 a.m.)
>
>
> Review request for Sqoop and shen guoquan.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add SqoopClient support to call Restful API
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9e15c030a0b21bc5e0aa64184e13c2dc78cf9507
> client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 1825cf3c96832283f589a77848da09c81abaec4b
>
> Diff: https://reviews.apache.org/r/31055/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 31055: SQOOP-2101: Add SqoopClient support to call
Restful API
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31055/#review72789
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Feb. 15, 2015, 8:28 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31055/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2015, 8:28 a.m.)
>
>
> Review request for Sqoop and shen guoquan.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add SqoopClient support to call Restful API
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9e15c030a0b21bc5e0aa64184e13c2dc78cf9507
> client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 1825cf3c96832283f589a77848da09c81abaec4b
>
> Diff: https://reviews.apache.org/r/31055/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 31055: SQOOP-2101: Add SqoopClient support to call
Restful API
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31055/
-----------------------------------------------------------
(Updated Feb. 15, 2015, 8:28 a.m.)
Review request for Sqoop and shen guoquan.
Changes
-------
1. Add 2 situations:
PUT /authorization/privileges/revoke
If privilege is null, then revoke all privileges for principal(name, type)
GET /authorization/privileges?principal_type={type}&principal_name={name}&resource_type={type}&resource_name={name}
If resource is null, then show all privileges in principal with {name, type}
2. Change function name from getRoles to readRoles to be align with JobResourceRequest and linkResourceRequest
Repository: sqoop-sqoop2
Description
-------
Add SqoopClient support to call Restful API
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9e15c030a0b21bc5e0aa64184e13c2dc78cf9507
client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 1825cf3c96832283f589a77848da09c81abaec4b
Diff: https://reviews.apache.org/r/31055/diff/
Testing
-------
local
Thanks,
richard zhou