[GitHub] [airflow] jedcunningham commented on a change in pull request #19749: Chart: PgBouncer service enhancements

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #19749:
URL: https://github.com/apache/airflow/pull/19749#discussion_r765860292



##########
File path: chart/values.schema.json
##########
@@ -3004,6 +3004,16 @@
                     ],
                     "default": null
                 },
+                "extraVolumes": {
+                    "description": "Mount additional volumes into PgBouncer.",
+                    "type": "array",
+                    "default": []
+                },
+                "extraVolumeMounts": {
+                    "description": "Mount additional volumes into PgBouncer.",
+                    "type": "array",
+                    "default": []

Review comment:
       ```suggestion
                       "default": [],
                       "items": {
                           "$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/volumemount-v1.json"
                       }
   ```

##########
File path: chart/values.schema.json
##########
@@ -3004,6 +3004,16 @@
                     ],
                     "default": null
                 },
+                "extraVolumes": {
+                    "description": "Mount additional volumes into PgBouncer.",
+                    "type": "array",
+                    "default": []

Review comment:
       ```suggestion
                       "default": [],
                       "items": {
                           "$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/volume-v1.json"
                       }
   ```

##########
File path: chart/tests/test_pgbouncer.py
##########
@@ -427,7 +453,7 @@ def test_default_exporter_secret(self):
     def test_exporter_secret_with_overrides(self):
         connection = self._get_connection(
             {
-                "pgbouncer": {"enabled": True},
+                "pgbouncer": {"enabled": True, "metricsExporterSidecar": {"sslmode": "disable"}},

Review comment:
       ```suggestion
                   "pgbouncer": {"enabled": True, "metricsExporterSidecar": {"sslmode": "require"}},
   ```
   
   The intent of this test is to test with non-default values. It also needs to change in the assert below, but I can't suggest it via the UI.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org