You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2025/05/30 13:47:45 UTC

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22960


Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................

IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled

This skipIf used the coordinator webui to check whether the flag
is set and skipped the test if the cluster was not running.
The skipIf was only used in custom cluster tests where the cluster
is restarted with new flags anyway, so the flags of the previous
cluster are not relevant.

Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
---
M tests/common/skip.py
M tests/custom_cluster/test_event_processing_error.py
M tests/metadata/test_event_processing.py
3 files changed, 1 insertion(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/22960/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22960 )

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11962/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 10:50:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22960 )

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19348/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 14:09:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22960 )

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 10:50:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22960

to look at the new patch set (#2).

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................

IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled

This skipIf used the coordinator webui to check whether the flag
is set and skipped the test if the cluster was not running.
The skipIf was only used in custom cluster tests where the cluster
is restarted with new flags anyway, so the flags of the previous
cluster are not relevant.

Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
---
M tests/common/skip.py
M tests/custom_cluster/test_event_processing_error.py
M tests/metadata/test_event_processing.py
3 files changed, 1 insertion(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/22960/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22960 )

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 06:20:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22960 )

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 10:49:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22960 )

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................

IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled

This skipIf used the coordinator webui to check whether the flag
is set and skipped the test if the cluster was not running.
The skipIf was only used in custom cluster tests where the cluster
is restarted with new flags anyway, so the flags of the previous
cluster are not relevant.

Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Reviewed-on: http://gerrit.cloudera.org:8080/22960
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/skip.py
M tests/custom_cluster/test_event_processing_error.py
M tests/metadata/test_event_processing.py
3 files changed, 1 insertion(+), 10 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22960 )

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 16:45:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22960 )

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19350/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 14:30:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14109: Remove SkipIfCatalogV2.hms event polling disabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22960 )

Change subject: IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22960/1/tests/custom_cluster/test_event_processing_error.py
File tests/custom_cluster/test_event_processing_error.py:

http://gerrit.cloudera.org:8080/#/c/22960/1/tests/custom_cluster/test_event_processing_error.py@28
PS1, Line 28: @SkipIfFS.hive
flake8: E302 expected 2 blank lines, found 1



-- 
To view, visit http://gerrit.cloudera.org:8080/22960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Gerrit-Change-Number: 22960
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 13:49:34 +0000
Gerrit-HasComments: Yes