[GitHub] [apr] ylavic commented on pull request #34: Fix a rare segfault in apr_global_mutex_child_init()

["ylavic (via GitHub)" <gi...@apache.org>]

ylavic commented on PR #34:
URL: https://github.com/apache/apr/pull/34#issuecomment-1534446159

   apr_global_mutex_child_init() is not supposed to be called with `*mutex == NULL` (it should have been allocated with apr_global_mutex_create() first), so this is a usage/user error (i.e. don't do that)?
   Also, if something has to be done with the new `APR_ENOLOCK` error from this PR, it should be possible to do the same by testing `*mutex == NULL` before in the caller, so I don't get what this PR is fixing, looks like defensive programming only to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org