You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xalan.apache.org by jk...@apache.org on 2023/10/24 00:19:05 UTC

[xalan-java] branch xalan-java-mvn-refactored updated: Working on the build/ convenience output. Good news: It's now simplifying the jarnames. Bad news: Still creating/stepping on ../build. Maven conditionals are hairy...

This is an automated email from the ASF dual-hosted git repository.

jkesselm pushed a commit to branch xalan-java-mvn-refactored
in repository https://gitbox.apache.org/repos/asf/xalan-java.git


The following commit(s) were added to refs/heads/xalan-java-mvn-refactored by this push:
     new 26dd22e6 Working on the build/ convenience output. Good news: It's now simplifying the jarnames. Bad news: Still creating/stepping on ../build. Maven conditionals are hairy...
26dd22e6 is described below

commit 26dd22e66380c4849a7df25d70e107037d00b819
Author: kubycsolutions <ke...@kubyc.solutions>
AuthorDate: Mon Oct 23 20:18:56 2023 -0400

    Working on the build/ convenience output. Good news: It's now simplifying the jarnames. Bad news: Still creating/stepping on ../build. Maven conditionals are hairy...
---
 pom.xml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/pom.xml b/pom.xml
index f40fd8c4..bd45afa6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -29,7 +29,6 @@
 
   <build>
     <sourceDirectory>src/main/java</sourceDirectory>
-    <finalName>${project.artifactId}</finalName>
     <resources>
       <resource>
 	<directory>META-INF</directory>
@@ -123,7 +122,7 @@
 	   is Maven's standard solution for this, using an
 	   </exists> test to see if the expected jarfile is
 	   present. 
-	   -->
+      -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-dependency-plugin</artifactId>
@@ -135,18 +134,19 @@
               <goal>copy</goal>
             </goals>
             <configuration>
-	      <skip>${isParentModule}</skip>
+	      <skip></skip> <!-- Sensitive only to exactly "false" -->
               <artifactItems>
 		<artifactItem>
                   <groupId>${project.groupId}</groupId>
                   <artifactId>${project.artifactId}</artifactId>
                   <version>${project.version}</version>
                   <type>${project.packaging}</type>
-		  <!-- Copy without the "-${project.version}" suffix?
-		       ... Interacts badly with toplevel, which is
-		       currently outputting a POM.
-		  <destFileName>${project.artifactId}.jar</destFileName>
-		   -->
+		  <!-- Copy without the "-${project.version}" suffix,
+		       but with the filetype?
+		       -->
+		       <destFileName>${project.artifactId}.${project.packaging}</destFileName>
+		       <!--
+		       -->
 		</artifactItem>
               </artifactItems>
               <outputDirectory>../build</outputDirectory>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xalan.apache.org
For additional commands, e-mail: commits-help@xalan.apache.org