You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2021/05/31 06:38:05 UTC
[incubator-nuttx] 05/05: tcp_data_event: Add a comment
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7ac6c0a8de539c7034a022cde99b67d77ad74f52
Author: YAMAMOTO Takashi <ya...@midokura.com>
AuthorDate: Fri May 28 17:44:13 2021 +0900
tcp_data_event: Add a comment
---
net/tcp/tcp_callback.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/tcp/tcp_callback.c b/net/tcp/tcp_callback.c
index c717512..591cb78 100644
--- a/net/tcp/tcp_callback.c
+++ b/net/tcp/tcp_callback.c
@@ -96,7 +96,11 @@ tcp_data_event(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn,
#ifdef CONFIG_NET_STATISTICS
g_netstats.tcp.drop++;
#endif
- /* Clear the TCP_SNDACK bit so that no ACK will be sent */
+ /* Clear the TCP_SNDACK bit so that no ACK will be sent.
+ *
+ * Revisit: It might make more sense to send a dup ack
+ * to give a hint to the peer.
+ */
ret &= ~TCP_SNDACK;
}