You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/07 08:44:19 UTC
[GitHub] [kafka] chia7712 opened a new pull request #9706: KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break l…
chia7712 opened a new pull request #9706:
URL: https://github.com/apache/kafka/pull/9706
If we don't break it when all partitions are verified, the loop will take 10 mins ...
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #9706: KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9706:
URL: https://github.com/apache/kafka/pull/9706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9706: KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break l…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9706:
URL: https://github.com/apache/kafka/pull/9706#issuecomment-747891663
@vvcephei @mjsax Could you please take a look at this one-line change? This issue slowdown ```streams_eos_test```(10 mins) and it obstructs us from running system tests on Travis (due to timeout).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9706: KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9706:
URL: https://github.com/apache/kafka/pull/9706#issuecomment-750436117
> thanks for getting this into 2.7 and 2.6. (Btw: there is no need to do PRs. You can also cherry-pick and push directly.)
Thanks for kind reminder!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #9706: KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9706:
URL: https://github.com/apache/kafka/pull/9706#issuecomment-750433680
@chia7712 -- thanks for getting this into 2.7 and 2.6. (Btw: there is no need to do PRs. You can also cherry-pick and push directly.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org