You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/02 14:51:40 UTC

[GitHub] [hbase] Apache9 opened a new pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Apache9 opened a new pull request #2186:
URL: https://github.com/apache/hbase/pull/2186


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-667909082


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 21s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 57s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   4m 12s |  master passed  |
   | +1 :green_heart: |  spotbugs  |   7m 47s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 48s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 30s |  hbase-client: The patch generated 1 new + 76 unchanged - 70 fixed = 77 total (was 146)  |
   | -0 :warning: |  checkstyle  |   1m 22s |  hbase-server: The patch generated 7 new + 774 unchanged - 105 fixed = 781 total (was 879)  |
   | +1 :green_heart: |  checkstyle  |   0m 20s |  hbase-mapreduce: The patch generated 0 new + 70 unchanged - 2 fixed = 70 total (was 72)  |
   | +1 :green_heart: |  checkstyle  |   0m 43s |  hbase-thrift: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  The patch passed checkstyle in hbase-endpoint  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  hbase-backup: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)  |
   | +1 :green_heart: |  checkstyle  |   0m 18s |  The patch passed checkstyle in hbase-it  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  hbase-rest: The patch generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5)  |
   | +1 :green_heart: |  checkstyle  |   0m 10s |  The patch passed checkstyle in hbase-shaded-client-project  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m 19s |  Patch does not cause any errors with Hadoop 3.1.2 3.2.1.  |
   | +1 :green_heart: |  spotbugs  |   9m 19s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   1m 32s |  The patch does not generate ASF License warnings.  |
   |  |   |  59m 15s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2186 |
   | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
   | uname | Linux d38221522a9c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 8e33bb04bc |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
   | Max. process+thread count | 84 (vs. ulimit of 12500) |
   | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] tedyu commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
tedyu commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-668119294


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] virajjasani commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-667902936


   Looks like old ruby references have already started using new builder classes. Much better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-668003565


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 28s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 39s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 46s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 37s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m 18s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 53s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 35s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 35s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 32s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m 16s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  8s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  | 183m 48s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  unit  |  14m 46s |  hbase-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 57s |  hbase-thrift in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 41s |  hbase-endpoint in the patch passed.  |
   | +1 :green_heart: |  unit  |  12m 37s |  hbase-backup in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 41s |  hbase-it in the patch passed.  |
   | +1 :green_heart: |  unit  |   5m 23s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 23s |  hbase-shaded-client-project in the patch passed.  |
   |  |   | 271m 47s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2186 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 34051dadb717 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 8e33bb04bc |
   | Default Java | 1.8.0_232 |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/testReport/ |
   | Max. process+thread count | 5087 (vs. ulimit of 12500) |
   | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-667692113


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 44s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  2s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 16s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   4m 20s |  master passed  |
   | +1 :green_heart: |  spotbugs  |   8m 45s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 22s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 33s |  hbase-client: The patch generated 1 new + 76 unchanged - 70 fixed = 77 total (was 146)  |
   | -0 :warning: |  checkstyle  |   1m 32s |  hbase-server: The patch generated 7 new + 766 unchanged - 105 fixed = 773 total (was 871)  |
   | +1 :green_heart: |  checkstyle  |   0m 20s |  hbase-mapreduce: The patch generated 0 new + 63 unchanged - 2 fixed = 63 total (was 65)  |
   | +1 :green_heart: |  checkstyle  |   0m 48s |  hbase-thrift: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-endpoint  |
   | +1 :green_heart: |  checkstyle  |   0m 16s |  hbase-backup: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)  |
   | +1 :green_heart: |  checkstyle  |   0m 20s |  The patch passed checkstyle in hbase-it  |
   | +1 :green_heart: |  checkstyle  |   0m 17s |  hbase-rest: The patch generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5)  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  The patch passed checkstyle in hbase-shaded-client-project  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  hadoopcheck  |  14m 13s |  Patch does not cause any errors with Hadoop 3.1.2 3.2.1.  |
   | +1 :green_heart: |  spotbugs  |  10m 26s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   1m 38s |  The patch does not generate ASF License warnings.  |
   |  |   |  66m  8s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2186 |
   | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
   | uname | Linux eb3184272009 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 86ebbdd8a2 |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
   | Max. process+thread count | 84 (vs. ulimit of 12500) |
   | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-667709470


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   3m 28s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 45s |  master passed  |
   | +1 :green_heart: |  compile  |   5m  0s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 46s |  branch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 18s |  hbase-shaded-client-project in master failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-backup in master failed.  |
   | -0 :warning: |  javadoc  |   0m 25s |  hbase-client in master failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-mapreduce in master failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-rest in master failed.  |
   | -0 :warning: |  javadoc  |   0m 39s |  hbase-server in master failed.  |
   | -0 :warning: |  javadoc  |   0m 50s |  hbase-thrift in master failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 57s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 39s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 39s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 44s |  patch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 25s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 40s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-mapreduce in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 51s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-backup in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-rest in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 16s |  hbase-shaded-client-project in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  7s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  | 137m 25s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  unit  |  11m  5s |  hbase-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 51s |  hbase-thrift in the patch passed.  |
   | -1 :x: |  unit  |   3m 14s |  hbase-endpoint in the patch failed.  |
   | +1 :green_heart: |  unit  |  11m 33s |  hbase-backup in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 12s |  hbase-it in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 20s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m  8s |  hbase-shaded-client-project in the patch passed.  |
   |  |   | 220m 50s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2186 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux cab1bf237c00 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 86ebbdd8a2 |
   | Default Java | 2020-01-14 |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-archetypes_hbase-shaded-client-project.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-archetypes_hbase-shaded-client-project.txt |
   | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-endpoint.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/testReport/ |
   | Max. process+thread count | 5096 (vs. ulimit of 12500) |
   | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-668034134


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 23s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  2s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 39s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   4m  5s |  master passed  |
   | +1 :green_heart: |  spotbugs  |   7m 21s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 41s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 29s |  hbase-client: The patch generated 0 new + 76 unchanged - 70 fixed = 76 total (was 146)  |
   | +1 :green_heart: |  checkstyle  |   1m 22s |  hbase-server: The patch generated 0 new + 774 unchanged - 105 fixed = 774 total (was 879)  |
   | +1 :green_heart: |  checkstyle  |   0m 19s |  hbase-mapreduce: The patch generated 0 new + 70 unchanged - 2 fixed = 70 total (was 72)  |
   | +1 :green_heart: |  checkstyle  |   0m 43s |  hbase-thrift: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)  |
   | +1 :green_heart: |  checkstyle  |   0m 11s |  The patch passed checkstyle in hbase-endpoint  |
   | +1 :green_heart: |  checkstyle  |   0m 13s |  hbase-backup: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)  |
   | +1 :green_heart: |  checkstyle  |   0m 18s |  The patch passed checkstyle in hbase-it  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  hbase-rest: The patch generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5)  |
   | +1 :green_heart: |  checkstyle  |   0m 10s |  The patch passed checkstyle in hbase-shaded-client-project  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m 14s |  Patch does not cause any errors with Hadoop 3.1.2 3.2.1.  |
   | +1 :green_heart: |  spotbugs  |   8m 47s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   1m 31s |  The patch does not generate ASF License warnings.  |
   |  |   |  56m 58s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2186 |
   | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
   | uname | Linux 477d888f5b53 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / ad7caf754a |
   | Max. process+thread count | 84 (vs. ulimit of 12500) |
   | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-668122269


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 24s |  master passed  |
   | +1 :green_heart: |  compile  |   5m 53s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 14s |  branch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-shaded-client-project in master failed.  |
   | -0 :warning: |  javadoc  |   0m 26s |  hbase-backup in master failed.  |
   | -0 :warning: |  javadoc  |   0m 31s |  hbase-client in master failed.  |
   | -0 :warning: |  javadoc  |   0m 24s |  hbase-mapreduce in master failed.  |
   | -0 :warning: |  javadoc  |   0m 24s |  hbase-rest in master failed.  |
   | -0 :warning: |  javadoc  |   0m 53s |  hbase-server in master failed.  |
   | -0 :warning: |  javadoc  |   1m 10s |  hbase-thrift in master failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 39s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m  4s |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m  4s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   7m 52s |  patch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 31s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 45s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 23s |  hbase-mapreduce in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 55s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-backup in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-rest in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 16s |  hbase-shaded-client-project in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 11s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  | 137m  0s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  unit  |  10m 36s |  hbase-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 24s |  hbase-thrift in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 13s |  hbase-endpoint in the patch passed.  |
   | +1 :green_heart: |  unit  |   9m 54s |  hbase-backup in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m  8s |  hbase-it in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 15s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m  7s |  hbase-shaded-client-project in the patch passed.  |
   |  |   | 225m 19s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2186 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 05ffc649eb1a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / ad7caf754a |
   | Default Java | 2020-01-14 |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-archetypes_hbase-shaded-client-project.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-archetypes_hbase-shaded-client-project.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/testReport/ |
   | Max. process+thread count | 4821 (vs. ulimit of 12500) |
   | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/3/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache9 merged pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #2186:
URL: https://github.com/apache/hbase/pull/2186


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-667715730


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 25s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 11s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 38s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 50s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m 19s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 37s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 37s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 36s |  patch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 41s |  hbase-server generated 4 new + 28 unchanged - 0 fixed = 32 total (was 28)  |
   | -0 :warning: |  javadoc  |   0m 19s |  hbase-mapreduce generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  6s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  | 190m 25s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  unit  |  15m  3s |  hbase-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 53s |  hbase-thrift in the patch passed.  |
   | -1 :x: |  unit  |   3m 56s |  hbase-endpoint in the patch failed.  |
   | +1 :green_heart: |  unit  |  12m 52s |  hbase-backup in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 37s |  hbase-it in the patch passed.  |
   | +1 :green_heart: |  unit  |   5m 31s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 35s |  hbase-shaded-client-project in the patch passed.  |
   |  |   | 280m 59s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2186 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 87332078a44c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 86ebbdd8a2 |
   | Default Java | 1.8.0_232 |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-mapreduce.txt |
   | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-endpoint.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/testReport/ |
   | Max. process+thread count | 5084 (vs. ulimit of 12500) |
   | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] saintstack commented on a change in pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#discussion_r464127581



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##########
@@ -73,8 +80,19 @@ private Constraints() {
   /**
    * Enable constraints on a table.
    * <p/>
+<<<<<<< HEAD
    * Currently, if you attempt to add a constraint to the table, then Constraints will automatically
    * be turned on.
+=======
+   * Currently, if you attempt to add a constraint to the table, then
+   * Constraints will automatically be turned on.
+   *
+   * @param desc
+   *          table description to add the processor
+   * @throws IOException
+   *           If the {@link ConstraintProcessor} CP couldn't be added to the
+   *           table.
+>>>>>>> 210f1e7388... tmp

Review comment:
       Ditto

##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##########
@@ -41,10 +41,17 @@
 /**
  * Utilities for adding/removing constraints from a table.
  * <p/>
+<<<<<<< HEAD
  * Since {@link TableDescriptor} is immutable now, you should use {@link TableDescriptorBuilder}.
  * And when disabling or removing constraints, you could use
  * {@link TableDescriptorBuilder#newBuilder(TableDescriptor)} to clone the old
  * {@link TableDescriptor} and then pass it the below methods.
+=======
+ * Constraints can be added on table load time, via the {@link HTableDescriptor}.
+ * <p/>
+ * NOTE: this class is NOT thread safe. Concurrent setting/enabling/disabling of
+ * constraints can cause constraints to be run at incorrect times or not at all.
+>>>>>>> 210f1e7388... tmp

Review comment:
       Fix?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache9 commented on a change in pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#discussion_r464155114



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##########
@@ -41,10 +41,17 @@
 /**
  * Utilities for adding/removing constraints from a table.
  * <p/>
+<<<<<<< HEAD
  * Since {@link TableDescriptor} is immutable now, you should use {@link TableDescriptorBuilder}.
  * And when disabling or removing constraints, you could use
  * {@link TableDescriptorBuilder#newBuilder(TableDescriptor)} to clone the old
  * {@link TableDescriptor} and then pass it the below methods.
+=======
+ * Constraints can be added on table load time, via the {@link HTableDescriptor}.
+ * <p/>
+ * NOTE: this class is NOT thread safe. Concurrent setting/enabling/disabling of
+ * constraints can cause constraints to be run at incorrect times or not at all.
+>>>>>>> 210f1e7388... tmp

Review comment:
       Let me check.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#issuecomment-667983645


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   2m 55s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 15s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 46s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 53s |  branch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 19s |  hbase-shaded-client-project in master failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-backup in master failed.  |
   | -0 :warning: |  javadoc  |   0m 26s |  hbase-client in master failed.  |
   | -0 :warning: |  javadoc  |   0m 22s |  hbase-mapreduce in master failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-rest in master failed.  |
   | -0 :warning: |  javadoc  |   0m 40s |  hbase-server in master failed.  |
   | -0 :warning: |  javadoc  |   0m 52s |  hbase-thrift in master failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 11s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 50s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 50s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m  1s |  patch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 26s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 41s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-mapreduce in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 51s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 19s |  hbase-backup in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-rest in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 17s |  hbase-shaded-client-project in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  8s |  hbase-client in the patch passed.  |
   | -1 :x: |  unit  | 141m 38s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |  11m 16s |  hbase-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 50s |  hbase-thrift in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 14s |  hbase-endpoint in the patch passed.  |
   | +1 :green_heart: |  unit  |  11m 35s |  hbase-backup in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 13s |  hbase-it in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 21s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m  7s |  hbase-shaded-client-project in the patch passed.  |
   |  |   | 224m 57s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/2186 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 692995cb2b23 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 8e33bb04bc |
   | Default Java | 2020-01-14 |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-archetypes_hbase-shaded-client-project.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-backup.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-archetypes_hbase-shaded-client-project.txt |
   | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/testReport/ |
   | Max. process+thread count | 5089 (vs. ulimit of 12500) |
   | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/2/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org