[GitHub] [pulsar] mattisonchao commented on a change in pull request #13831: NPE when get isAllowAutoUploadSchema

[GitBox <gi...@apache.org>]

mattisonchao commented on a change in pull request #13831:
URL: https://github.com/apache/pulsar/pull/13831#discussion_r787486218



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
##########
@@ -1489,7 +1489,7 @@ public void deleteCompactionThreshold(@PathParam("tenant") String tenant,
                   notes = "A negative value disables automatic offloading")
     @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
                             @ApiResponse(code = 404, message = "Namespace doesn't exist") })
-    public long getOffloadThreshold(@PathParam("tenant") String tenant,
+    public Long getOffloadThreshold(@PathParam("tenant") String tenant,

Review comment:
       Maybe we need to think about why the ``internalGetOffloadThreshold method returns null``  , because null is an incorrect result.

##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
##########
@@ -1630,7 +1630,7 @@ public void setSchemaCompatibilityStrategy(
     @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
             @ApiResponse(code = 404, message = "Namespace doesn't exist"),
             @ApiResponse(code = 409, message = "Concurrent modification") })
-    public boolean getIsAllowAutoUpdateSchema(
+    public Boolean getIsAllowAutoUpdateSchema(

Review comment:
       Maybe we need to think about why the ``internalGetIsAllowAutoUpdateSchema`` method returns null , because null is an incorrect result.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org