You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/23 11:36:26 UTC
[GitHub] [spark] manbuyun opened a new pull request #34372: [SPARK-37101] In class ShuffleBlockPusher, use config instead of key
manbuyun opened a new pull request #34372:
URL: https://github.com/apache/spark/pull/34372
### What changes were proposed in this pull request?
In class ShuffleBlockPusher, We can use config.REDUCER_MAX_SIZE_IN_FLIGHT and config.REDUCER_MAX_REQS_IN_FLIGHT instead of "spark.reducer.maxSizeInFlight" and "spark.reducer.maxReqsInFlight"
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950527922
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49042/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950554990
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144571/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950523923
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34372: [SPARK-37101] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950141240
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950553295
**[Test build #144571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144571/testReport)** for PR 34372 at commit [`5c8792d`](https://github.com/apache/spark/commit/5c8792d55928cfb6c7d89a48a27d38fad04c246d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] manbuyun commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
manbuyun commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950468417
> Please fill the PR description as guided in the template.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950471886
ok to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950482146
**[Test build #144571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144571/testReport)** for PR 34372 at commit [`5c8792d`](https://github.com/apache/spark/commit/5c8792d55928cfb6c7d89a48a27d38fad04c246d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950436431
Please fill the PR description as guided in the template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950501750
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49042/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950554990
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144571/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950525915
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49042/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950527922
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49042/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on pull request #34372: [SPARK-37101] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950325812
Hi @manbuyun, would you like to rerun the "Build and test" by clicking "fetch upstream" on your branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950482146
**[Test build #144571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144571/testReport)** for PR 34372 at commit [`5c8792d`](https://github.com/apache/spark/commit/5c8792d55928cfb6c7d89a48a27d38fad04c246d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34372:
URL: https://github.com/apache/spark/pull/34372#issuecomment-950141240
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34372: [SPARK-37101][CORE] In class ShuffleBlockPusher, use config instead of key
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34372:
URL: https://github.com/apache/spark/pull/34372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org