You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:31:37 UTC
[GitHub] [arrow] emkornfield opened a new pull request #7862: ARROW-9598: [C++][Parquet] Fix nullable structs
emkornfield opened a new pull request #7862:
URL: https://github.com/apache/arrow/pull/7862
Traverse the node hierarchy to ensure we capture the right value count.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on a change in pull request #7862: ARROW-9598: [C++][Parquet] Fix writing nullable structs
Posted by GitBox <gi...@apache.org>.
wesm commented on a change in pull request #7862:
URL: https://github.com/apache/arrow/pull/7862#discussion_r468167821
##########
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##########
@@ -2344,6 +2344,23 @@ TEST(ArrowReadWrite, SimpleStructRoundTrip) {
2);
}
+TEST(ArrowReadWrite, SingleColumnNullableStruct) {
+ auto links =
+ field("Links",
+ ::arrow::struct_({field("Backward", ::arrow::int64(), /*nullable=*/true)}));
+
+ auto links_id_array = ::arrow::ArrayFromJSON(links->type(),
+ "[null, "
+ "{\"Backward\": 10}"
+ "]");
+
+ CheckSimpleRoundtrip(
+ ::arrow::Table::Make(std::make_shared<::arrow::Schema>(
+ std::vector<std::shared_ptr<::arrow::Field>>{links}),
Review comment:
in the future you could do `::arrow::schema({links})`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7862: ARROW-9598: [C++][Parquet] Fix writing nullable structs
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7862:
URL: https://github.com/apache/arrow/pull/7862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7862: ARROW-9598: [C++][Parquet] Fix writing nullable structs
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7862:
URL: https://github.com/apache/arrow/pull/7862#issuecomment-671143005
@wesm just wanted to make sure this is on your radar, it would be nice to get it into the patch release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jianxind commented on a change in pull request #7862: ARROW-9598: [C++][Parquet] Fix writing nullable structs
Posted by GitBox <gi...@apache.org>.
jianxind commented on a change in pull request #7862:
URL: https://github.com/apache/arrow/pull/7862#discussion_r463354793
##########
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##########
@@ -2344,6 +2344,23 @@ TEST(ArrowReadWrite, SimpleStructRoundTrip) {
2);
}
+TEST(ArrowReadWrite, SingleColumnNullableStuct) {
Review comment:
nit: Struct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #7862: ARROW-9598: [C++][Parquet] Fix writing nullable structs
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #7862:
URL: https://github.com/apache/arrow/pull/7862#discussion_r463915579
##########
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##########
@@ -2344,6 +2344,23 @@ TEST(ArrowReadWrite, SimpleStructRoundTrip) {
2);
}
+TEST(ArrowReadWrite, SingleColumnNullableStuct) {
Review comment:
thanks. fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7862: ARROW-9598: [C++][Parquet] Fix writing nullable structs
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7862:
URL: https://github.com/apache/arrow/pull/7862#issuecomment-671574382
Merging. Failure seems unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7862: ARROW-9598: [C++][Parquet] Fix writing nullable structs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7862:
URL: https://github.com/apache/arrow/pull/7862#issuecomment-666104382
https://issues.apache.org/jira/browse/ARROW-9598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org