You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/09/27 22:34:58 UTC
[PR] refactor(frontend): remove dead WorkflowUtilService members [texera]
aglinxinyuan opened a new pull request, #8717:
URL: https://github.com/apache/texera/pull/8717
### What changes were proposed in this PR?
Deletes four unused members of `WorkflowUtilService`, plus the rxjs import and the three spec cases that existed only for them. **+1/−85 lines.** There is no behaviour change. The constructor still fills `operatorSchemaList` from the metadata subscription; only the `.next(true)` to a Subject with no subscriber goes.
### History
| | |
| --- | --- |
| **Introduced by** | #712 (2019-06-06): `operatorSchemaListCreatedSubject` + getter. #754 (2020-12-11), "Added operator grouping feature": `getGroupRandomUUID`. #1309 (2021-08-28), "Re-enabling breakpoints": `getBreakpointRandomUUID`. #4020 (2025-11-25), "feat: introduce the LLM-based workflow copilot": `getOperatorTypeList` |
| **Usage removed by** | #1674 (2022-10-05), the Yjs shared-editing frontend, removed the last live path to `getGroupRandomUUID` (#3033 later deleted its last textual call, inside a dead `getNewGroup`). #4495 (2026-04-27) removed the copilot tool that called `getOperatorTypeList`. The stream and `getBreakpointRandomUUID` were **never used** |
The oldest of these has been dead for seven years, and the newest for five months.
### Any related issues, documentation, discussions?
Closes #8716
### How was this PR tested?
No new tests. The 15 remaining service cases cover what is left.
From `frontend/`:
- `npx ng test --watch=false`, with one `--include` per spec that imports `workflow-util.service` (20 files): 724 tests, all pass.
- `yarn format:ci`: clean.
- `npx ng build`: success.
To re-check:
```
git grep -n -E "getOperatorTypeList|getGroupRandomUUID|getBreakpointRandomUUID|OperatorSchemaListCreated" -- frontend # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove dead WorkflowUtilService members [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8717:
URL: https://github.com/apache/texera/pull/8717#issuecomment-5860466552
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@yangzhang75`
You can notify them by mentioning `@yangzhang75` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove dead WorkflowUtilService members [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8717:
URL: https://github.com/apache/texera/pull/8717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove dead WorkflowUtilService members [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8717:
URL: https://github.com/apache/texera/pull/8717#issuecomment-5860526649
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8717?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.74%. Comparing base ([`e0f4989`](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`671d08a`](https://app.codecov.io/gh/apache/texera/commit/671d08a61b2692dba159e548c31fbacbe6bcb997?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8717 +/- ##
=========================================
Coverage 92.73% 92.74%
Complexity 4946 4946
=========================================
Files 1242 1242
Lines 52684 52646 -38
Branches 6521 6514 -7
=========================================
- Hits 48854 48824 -30
+ Misses 2214 2206 -8
Partials 1616 1616
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [e0f4989](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [e0f4989](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.46% <ø> (ø)` | | Carriedforward from [e0f4989](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.41% <ø> (ø)` | | Carriedforward from [e0f4989](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [e0f4989](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [e0f4989](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.56% <ø> (+0.02%)` | :arrow_up: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [e0f4989](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.56% <ø> (ø)` | | Carriedforward from [e0f4989](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8717/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | Carriedforward from [e0f4989](https://app.codecov.io/gh/apache/texera/commit/e0f49897dbb525dc7faa6eac5f293fdb02b8f7f9?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8717?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org