You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/26 16:21:17 UTC
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5681: Use the Python Postinstall implementation by default
zrhoffman commented on a change in pull request #5681:
URL: https://github.com/apache/trafficcontrol/pull/5681#discussion_r602426030
##########
File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile
##########
@@ -35,56 +35,72 @@ RUN set -o nounset -o errexit && \
if [[ "${RHEL_VERSION%%.*}" -eq 7 ]]; then \
use_repo=''; \
enable_repo=''; \
+ llvm_version=5.0; \
# needed for llvm-toolset-7-clang, which is needed for postgresql13-devel-13.2-1PGDG, required by TO rpm
dnf -y install gcc centos-release-scl-rh; \
else \
use_repo='--repo=pgdg13'; \
enable_repo='--enablerepo=powertools'; \
+ llvm_version=''; \
fi; \
dnf -y install "https://download.postgresql.org/pub/repos/yum/reporpms/EL-${RHEL_VERSION%%.*}-x86_64/pgdg-redhat-repo-latest.noarch.rpm"; \
- # libicu required by postgresql13
- dnf -y install libicu; \
- dnf -y $use_repo -- install postgresql13; \
dnf -y install epel-release; \
- dnf -y $enable_repo install \
+ dnf -y install \
+ # libicu is required by postgresql13
+ libicu \
+ # libicu-devel, clang-devel, and llvm-devel are required by postgresql13-devel
Review comment:
The spec requires it:
https://github.com/apache/trafficcontrol/blob/95db4e8ef65c22f6af17aa6f63733ef80322a02f/traffic_ops/build/traffic_ops.spec#L39
Maybe we can remove that dependency in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org