[GitHub] [airflow] josh-fell commented on a change in pull request #18475: Fix example timetable for AIP-39 howto

[GitBox <gi...@apache.org>]

josh-fell commented on a change in pull request #18475:
URL: https://github.com/apache/airflow/pull/18475#discussion_r714937474



##########
File path: tests/timetatbles/__init__.py
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       Small nit but the `tests` directory path has a typo. Should be `tests/timetables/...`?

##########
File path: docs/apache-airflow/howto/timetable.rst
##########
@@ -96,10 +96,16 @@ file:
 
 .. code-block:: python
 
+    import datetime
+
     from airflow import DAG
 
 
-    with DAG(timetable=AfterWorkdayTimetable(), tags=["example", "timetable"]) as dag:
+    with DAG(
+        start_date=datetime.datetime(2021, 3, 10),

Review comment:
       This is just documentation but `dag_id` is missing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org