You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/10/08 16:14:20 UTC

Re: Review Request 13841: Missing tests from QA repo to ASF - 3 tests from test_vmware_drs.py

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13841/
-----------------------------------------------------------

(Updated Oct. 8, 2013, 2:14 p.m.)


Review request for cloudstack, Girish Shilamkar, Harikrishna Patnala, and Prasanna Santhanam.


Repository: cloudstack-git


Description
-------

New File added    : test_vmware_drs.py
Tests added       : def test_vm_creation_in_fully_automated_mode(self):
                    def test_vmware_anti_affinity(self):
                    def test_vmware_affinity(self):

The tests need manual setup and therefore have been marked as WIP and
skipped for the moment


Diffs (updated)
-----

  test/integration/component/test_vmware_drs.py PRE-CREATION 

Diff: https://reviews.apache.org/r/13841/diff/


Testing (updated)
-------

Tested locally.

One test case is working, two are skipped (one due to unavailability of particular setup and other die to feature not available in cloudstack yet)

Run Log:
==> client.log <==
2013-10-08 02:27:43,371 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - max memory: 14911

==> result.log <==
test_vmware_affinity (test_vmware_drs.TestAffinityRules)
Test Set up affinity rules ... skipped 'Skip'
test_vmware_anti_affinity (test_vmware_drs.TestAntiAffinityRules)
Test Set up anti-affinity rules ... skipped 'Skip'
test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement)
Test VM Creation in  automation mode = Fully automated ...
==> client.log <==
2013-10-08 02:28:53,855 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - Deploying VM in account: test-R7LY31

==> result.log <==
ok

----------------------------------------------------------------------
Ran 3 tests in 241.612s

OK (skipped=2)


Thanks,

Ashutosh Kelkar


Re: Review Request 13841: Missing tests from QA repo to ASF - 3 tests from test_vmware_drs.py

Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13841/#review28810
-----------------------------------------------------------


Committed to 4.2, 4.3 and master

- Girish Shilamkar


On Oct. 30, 2013, 7:01 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13841/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 7:01 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Harikrishna Patnala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> New File added    : test_vmware_drs.py
> Tests added       : def test_vm_creation_in_fully_automated_mode(self):
>                     def test_vmware_anti_affinity(self):
>                     def test_vmware_affinity(self):
> 
> The tests need manual setup and therefore have been marked as WIP and
> skipped for the moment
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vmware_drs.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13841/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> One test case is working, two are skipped (one due to unavailability of particular setup and other die to feature not available in cloudstack yet)
> 
> Run Log:
> ==> client.log <==
> 2013-10-08 02:27:43,371 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - max memory: 14911
> 
> ==> result.log <==
> test_vmware_affinity (test_vmware_drs.TestAffinityRules)
> Test Set up affinity rules ... skipped 'Skip'
> test_vmware_anti_affinity (test_vmware_drs.TestAntiAffinityRules)
> Test Set up anti-affinity rules ... skipped 'Skip'
> test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement)
> Test VM Creation in  automation mode = Fully automated ...
> ==> client.log <==
> 2013-10-08 02:28:53,855 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - Deploying VM in account: test-R7LY31
> 
> ==> result.log <==
> ok
> 
> ----------------------------------------------------------------------
> Ran 3 tests in 241.612s
> 
> OK (skipped=2)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 13841: Missing tests from QA repo to ASF - 3 tests from test_vmware_drs.py

Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13841/#review28783
-----------------------------------------------------------

Ship it!


Ship It!

- Girish Shilamkar


On Oct. 30, 2013, 7:01 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13841/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 7:01 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Harikrishna Patnala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> New File added    : test_vmware_drs.py
> Tests added       : def test_vm_creation_in_fully_automated_mode(self):
>                     def test_vmware_anti_affinity(self):
>                     def test_vmware_affinity(self):
> 
> The tests need manual setup and therefore have been marked as WIP and
> skipped for the moment
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vmware_drs.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13841/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> One test case is working, two are skipped (one due to unavailability of particular setup and other die to feature not available in cloudstack yet)
> 
> Run Log:
> ==> client.log <==
> 2013-10-08 02:27:43,371 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - max memory: 14911
> 
> ==> result.log <==
> test_vmware_affinity (test_vmware_drs.TestAffinityRules)
> Test Set up affinity rules ... skipped 'Skip'
> test_vmware_anti_affinity (test_vmware_drs.TestAntiAffinityRules)
> Test Set up anti-affinity rules ... skipped 'Skip'
> test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement)
> Test VM Creation in  automation mode = Fully automated ...
> ==> client.log <==
> 2013-10-08 02:28:53,855 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - Deploying VM in account: test-R7LY31
> 
> ==> result.log <==
> ok
> 
> ----------------------------------------------------------------------
> Ran 3 tests in 241.612s
> 
> OK (skipped=2)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 13841: Missing tests from QA repo to ASF - 3 tests from test_vmware_drs.py

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13841/
-----------------------------------------------------------

(Updated Oct. 30, 2013, 7:01 a.m.)


Review request for cloudstack, Girish Shilamkar and Harikrishna Patnala.


Changes
-------

Review Changes


Repository: cloudstack-git


Description
-------

New File added    : test_vmware_drs.py
Tests added       : def test_vm_creation_in_fully_automated_mode(self):
                    def test_vmware_anti_affinity(self):
                    def test_vmware_affinity(self):

The tests need manual setup and therefore have been marked as WIP and
skipped for the moment


Diffs (updated)
-----

  test/integration/component/test_vmware_drs.py PRE-CREATION 

Diff: https://reviews.apache.org/r/13841/diff/


Testing
-------

Tested locally.

One test case is working, two are skipped (one due to unavailability of particular setup and other die to feature not available in cloudstack yet)

Run Log:
==> client.log <==
2013-10-08 02:27:43,371 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - max memory: 14911

==> result.log <==
test_vmware_affinity (test_vmware_drs.TestAffinityRules)
Test Set up affinity rules ... skipped 'Skip'
test_vmware_anti_affinity (test_vmware_drs.TestAntiAffinityRules)
Test Set up anti-affinity rules ... skipped 'Skip'
test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement)
Test VM Creation in  automation mode = Fully automated ...
==> client.log <==
2013-10-08 02:28:53,855 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - Deploying VM in account: test-R7LY31

==> result.log <==
ok

----------------------------------------------------------------------
Ran 3 tests in 241.612s

OK (skipped=2)


Thanks,

Ashutosh Kelkar


Re: Review Request 13841: Missing tests from QA repo to ASF - 3 tests from test_vmware_drs.py

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13841/#review27711
-----------------------------------------------------------



test/integration/component/test_vmware_drs.py
<https://reviews.apache.org/r/13841/#comment53796>

    self.account_name is no where initialised.
    it should have been self.account



test/integration/component/test_vmware_drs.py
<https://reviews.apache.org/r/13841/#comment53797>

    self.account_name is no where initialised.
    it should have been self.account


- SrikanteswaraRao Talluri


On Oct. 28, 2013, 5:54 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13841/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 5:54 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Harikrishna Patnala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> New File added    : test_vmware_drs.py
> Tests added       : def test_vm_creation_in_fully_automated_mode(self):
>                     def test_vmware_anti_affinity(self):
>                     def test_vmware_affinity(self):
> 
> The tests need manual setup and therefore have been marked as WIP and
> skipped for the moment
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vmware_drs.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13841/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> One test case is working, two are skipped (one due to unavailability of particular setup and other die to feature not available in cloudstack yet)
> 
> Run Log:
> ==> client.log <==
> 2013-10-08 02:27:43,371 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - max memory: 14911
> 
> ==> result.log <==
> test_vmware_affinity (test_vmware_drs.TestAffinityRules)
> Test Set up affinity rules ... skipped 'Skip'
> test_vmware_anti_affinity (test_vmware_drs.TestAntiAffinityRules)
> Test Set up anti-affinity rules ... skipped 'Skip'
> test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement)
> Test VM Creation in  automation mode = Fully automated ...
> ==> client.log <==
> 2013-10-08 02:28:53,855 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - Deploying VM in account: test-R7LY31
> 
> ==> result.log <==
> ok
> 
> ----------------------------------------------------------------------
> Ran 3 tests in 241.612s
> 
> OK (skipped=2)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 13841: Missing tests from QA repo to ASF - 3 tests from test_vmware_drs.py

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13841/
-----------------------------------------------------------

(Updated Oct. 28, 2013, 5:54 a.m.)


Review request for cloudstack, Girish Shilamkar and Harikrishna Patnala.


Repository: cloudstack-git


Description
-------

New File added    : test_vmware_drs.py
Tests added       : def test_vm_creation_in_fully_automated_mode(self):
                    def test_vmware_anti_affinity(self):
                    def test_vmware_affinity(self):

The tests need manual setup and therefore have been marked as WIP and
skipped for the moment


Diffs
-----

  test/integration/component/test_vmware_drs.py PRE-CREATION 

Diff: https://reviews.apache.org/r/13841/diff/


Testing
-------

Tested locally.

One test case is working, two are skipped (one due to unavailability of particular setup and other die to feature not available in cloudstack yet)

Run Log:
==> client.log <==
2013-10-08 02:27:43,371 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - max memory: 14911

==> result.log <==
test_vmware_affinity (test_vmware_drs.TestAffinityRules)
Test Set up affinity rules ... skipped 'Skip'
test_vmware_anti_affinity (test_vmware_drs.TestAntiAffinityRules)
Test Set up anti-affinity rules ... skipped 'Skip'
test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement)
Test VM Creation in  automation mode = Fully automated ...
==> client.log <==
2013-10-08 02:28:53,855 - DEBUG - test_vm_creation_in_fully_automated_mode (test_vmware_drs.TestVMPlacement) - Deploying VM in account: test-R7LY31

==> result.log <==
ok

----------------------------------------------------------------------
Ran 3 tests in 241.612s

OK (skipped=2)


Thanks,

Ashutosh Kelkar