[GitHub] [cordova-plugin-inappbrowser] erisu commented on a change in pull request #465: Updated Travis CI Settings and Package.json

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #465: Updated Travis CI Settings and Package.json
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/465#discussion_r278045169
 
 

 ##########
 File path: package.json
 ##########
 @@ -15,10 +15,11 @@
   },
   "repository": {
     "type": "git",
-    "url": "https://github.com/apache/cordova-plugin-inappbrowser"
+    "url": "github:apache/cordova-plugin-inappbrowser"
 
 Review comment:
   I just wrote a script that updated the existing URL. I didn't think of shortening the entire field to a string. 
   
   Yeah we can shorten it more.
   
   https://docs.npmjs.com/files/package.json#repository
   
   I wonder what is the order of priority if you dropped GitHub from the string.
   
   ```
   "repository": "npm/npm"
   "repository": "github:user/repo"
   "repository": "gist:11081aaa281"
   "repository": "bitbucket:user/repo"
   "repository": "gitlab:user/repo"
   ```
   
   Would be bad if someone claimed the other services and NPM decided to use one of the other services.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org