You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2023/01/06 13:17:46 UTC
[GitHub] [accumulo] ddanielr opened a new pull request, #3152: Improve JavaDocs for VolumeChooser classes
ddanielr opened a new pull request, #3152:
URL: https://github.com/apache/accumulo/pull/3152
Fixes: #3110
Added more documentation for implementations of the VolumeChooser.
Added property table and basic usage examples to PreferredVolumeChooser.
Fixed minor grammatical issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ddanielr commented on a diff in pull request #3152: Improve JavaDocs for VolumeChooser classes
Posted by GitBox <gi...@apache.org>.
ddanielr commented on code in PR #3152:
URL: https://github.com/apache/accumulo/pull/3152#discussion_r1063633954
##########
core/src/main/java/org/apache/accumulo/core/spi/fs/RandomVolumeChooser.java:
##########
@@ -21,18 +21,30 @@
import java.security.SecureRandom;
import java.util.Set;
+import org.apache.accumulo.core.conf.Property;
+
/**
+ * A {@link VolumeChooser} that selects a volume at random from the list of provided volumes. This
+ * class is currently the default volume chooser as set by {@link Property#GENERAL_VOLUME_CHOOSER}.
Review Comment:
Sounds good! Changes implemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #3152: Improve JavaDocs for VolumeChooser classes
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #3152:
URL: https://github.com/apache/accumulo/pull/3152#discussion_r1063520765
##########
core/src/main/java/org/apache/accumulo/core/spi/fs/RandomVolumeChooser.java:
##########
@@ -21,18 +21,30 @@
import java.security.SecureRandom;
import java.util.Set;
+import org.apache.accumulo.core.conf.Property;
+
/**
+ * A {@link VolumeChooser} that selects a volume at random from the list of provided volumes. This
+ * class is currently the default volume chooser as set by {@link Property#GENERAL_VOLUME_CHOOSER}.
Review Comment:
```suggestion
* A {@link VolumeChooser} that selects a volume at random from the list of provided volumes.
```
If the default ever changes, then we have to remember to update this comment. Users can just check the default value of the property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ddanielr commented on pull request #3152: Improve JavaDocs for VolumeChooser classes
Posted by GitBox <gi...@apache.org>.
ddanielr commented on PR #3152:
URL: https://github.com/apache/accumulo/pull/3152#issuecomment-1377382995
@dlmarion any other changes you want to see or is this good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #3152: Improve JavaDocs for VolumeChooser classes
Posted by GitBox <gi...@apache.org>.
dlmarion merged PR #3152:
URL: https://github.com/apache/accumulo/pull/3152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org