You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/05/03 14:23:00 UTC
[jira] [Commented] (DISPATCH-1679) leak: qd_connector_t and
qd_timer_t
[ https://issues.apache.org/jira/browse/DISPATCH-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338386#comment-17338386 ]
ASF GitHub Bot commented on DISPATCH-1679:
------------------------------------------
kgiusti commented on a change in pull request #1170:
URL: https://github.com/apache/qpid-dispatch/pull/1170#discussion_r625121096
##########
File path: src/timer.c
##########
@@ -129,8 +214,9 @@ qd_timestamp_t qd_timer_now() {
void qd_timer_schedule(qd_timer_t *timer, qd_duration_t duration)
{
sys_mutex_lock(lock);
- timer_cancel_LH(timer); // Timer is now on the idle list
- DEQ_REMOVE(idle_timers, timer);
+
Review comment:
If state is DELETED that indicates a bug where a codepath is attempting to schedule a timer that has been deleted. Returning immediately would mask that bug - better to assert().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> leak: qd_connector_t and qd_timer_t
> -----------------------------------
>
> Key: DISPATCH-1679
> URL: https://issues.apache.org/jira/browse/DISPATCH-1679
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Routing Engine
> Affects Versions: 1.12.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Labels: leak
> Fix For: Backlog
>
>
> Every unit test that involves use of a connector leaks the connector and a related qd_timer_t. These leak warnings overwhelm other warnings in the test output.
> The qd_connector_t is reference counted. It also contains a qd_timer_t. From initial debug the reference count is never dropping below 1.
> It appears that every time the timer is scheduled the refcount is incremented. This appears to be an attempt to prevent the deletion of the qd_connector_t while the timer is outstanding. This appears likely to be the source of the outstanding ref count.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org