You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@community.apache.org by GitBox <gi...@apache.org> on 2023/01/10 01:33:32 UTC
[GitHub] [comdev-site] clr-apache opened a new pull request, #82: Update newcommitter.md
clr-apache opened a new pull request, #82:
URL: https://github.com/apache/comdev-site/pull/82
Update Committer Invite Template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on a diff in pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1098056789
##########
source/newcommitter.md:
##########
@@ -75,17 +75,19 @@ later in this document.
<a name="NewCommitter-Summary"></a>
### Summary
-1. Call a vote (templates/committerVote.txt)
-1. Close the vote
+1. Discuss the proposed committer/PMC member. If positive, call a vote (templates/committerVote.txt)
+1. Close the vote (templates/closeVote.txt)
1. If the result is positive, invite the new committer (templates/committerInvite.txt)
If they accept, then:
-1. Accept the committer (templates/committerAccept.txt)
-1. Wait until we see that receipt of CLA is recorded
-1. Request creation of the committer account (template/committerCreate.txt)
+1. If they already have an Apache id, grant appropriate commit privileges.
Review Comment:
It would have to be a generic link to whimsy/roster. Would that be useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] jvz commented on a diff in pull request #82: Update newcommitter.md
Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1097758720
##########
source/newcommitter.md:
##########
@@ -227,21 +236,40 @@ sent after a positive result from the vote for a new committer.
Of course, you can decline and instead remain as a
contributor, participating as you do now.
- A. This personal invitation is a chance for you to
- accept or decline in private. Either way, please
- let us know in reply to the private@[PROJECT].apache.org
- address only.
+ This personal invitation is a chance for you to accept or decline in private.
+ Please let us know in reply to this message whether you accept or decline.
+
+ A. If you accept, you will need an Apache account (id) with privileges.
+ Please follow these instructions.
+
+ 1. If you already have an Apache account, let us know your id and we
+ will grant you privileges on the project repositories.
+
+ 2. If you have previously sent an iCLA, let us know the email address
Review Comment:
```suggestion
2. If you have previously sent an ICLA, let us know the email address
```
Same with the rest of this email template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1419451227
Ready for final review...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] sebbASF commented on a diff in pull request #82: Update newcommitter.md
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1097279808
##########
source/newcommitter.md:
##########
@@ -227,21 +236,43 @@ sent after a positive result from the vote for a new committer.
Of course, you can decline and instead remain as a
contributor, participating as you do now.
- A. This personal invitation is a chance for you to
- accept or decline in private. Either way, please
- let us know in reply to the private@[PROJECT].apache.org
+ This personal invitation is a chance for you to
+ accept or decline in private.
+ If you decline, please let us know in reply to the private@[PROJECT].apache.org
address only.
+
+ A. If you accept, reply to this message with your acceptance.
Review Comment:
I think the original wording was better, in that it says that a reply is required in both cases.
The common case should be included before the split into A and B sections.
However, these are also in need of some work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
Posted by GitBox <gi...@apache.org>.
clr-apache commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1376600166
This is a work in progress...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1416898645
Any other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1419274238
That makes sense. I'll update it with new wording making clear that we expect a reply regardless of accept or decline.
> On Feb 6, 2023, at 03:50, sebbASF ***@***.***> wrote:
>
>
> @sebbASF commented on this pull request.
>
> In source/newcommitter.md <https://github.com/apache/comdev-site/pull/82#discussion_r1097279808>:
>
> > address only.
> +
> + A. If you accept, reply to this message with your acceptance.
> I think the original wording was better, in that it says that a reply is required in both cases.
> The common case should be included before the split into A and B sections.
> However, these are also in need of some work
>
> —
> Reply to this email directly, view it on GitHub <https://github.com/apache/comdev-site/pull/82#pullrequestreview-1285044999>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4M6RE3BQRDPOLR54Q55ULWWDQOXANCNFSM6AAAAAATWCP4LI>.
> You are receiving this because you authored the thread.
>
Craig L Russell
***@***.***
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on a diff in pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1096610164
##########
source/newcommitter.md:
##########
@@ -227,21 +235,42 @@ sent after a positive result from the vote for a new committer.
Of course, you can decline and instead remain as a
contributor, participating as you do now.
- A. This personal invitation is a chance for you to
- accept or decline in private. Either way, please
- let us know in reply to the private@[PROJECT].apache.org
+ This personal invitation is a chance for you to
+ accept or decline in private.
+ If you decline, please let us know in reply to the private@[PROJECT].apache.org
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] jvz commented on a diff in pull request #82: Update newcommitter.md
Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1097757460
##########
source/newcommitter.md:
##########
@@ -75,17 +75,19 @@ later in this document.
<a name="NewCommitter-Summary"></a>
### Summary
-1. Call a vote (templates/committerVote.txt)
-1. Close the vote
+1. Discuss the proposed committer/PMC member. If positive, call a vote (templates/committerVote.txt)
+1. Close the vote (templates/closeVote.txt)
1. If the result is positive, invite the new committer (templates/committerInvite.txt)
If they accept, then:
-1. Accept the committer (templates/committerAccept.txt)
-1. Wait until we see that receipt of CLA is recorded
-1. Request creation of the committer account (template/committerCreate.txt)
+1. If they already have an Apache id, grant appropriate commit privileges.
Review Comment:
Think we can link them to the right place in Whimsy here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on a diff in pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1096610226
##########
source/newcommitter.md:
##########
@@ -227,21 +235,42 @@ sent after a positive result from the vote for a new committer.
Of course, you can decline and instead remain as a
contributor, participating as you do now.
- A. This personal invitation is a chance for you to
- accept or decline in private. Either way, please
- let us know in reply to the private@[PROJECT].apache.org
+ This personal invitation is a chance for you to
+ accept or decline in private.
+ If you decline, please let us know in reply to the private@[PROJECT].apache.org
address only.
+
+ A. If you accept, you will need an Apache account (id) with privileges. Please follow
+ these instructions.
+
+ 1. If you already have an Apache account, let us know your id and we
+ will grant you privileges on the project repositories.
+
+ 2. If you have previously sent an iCLA, let us know the email address
+ and public name used on the iCLA and your preferred Apache id, and
+ we will request your account.
- B. If you accept, the next step is to register an iCLA:
+ 3. If the email address on the previously submitted iCLA is no longer
+ valid, let us know the email address and public name used on the new iCLA,
+ and your preferred Apache id. Continue to step B below and file your new iCLA.
+
+ Look to see if your preferred ID is already taken at
+ https://people.apache.org/committer-index.html
+
+ B. Otherwise, you need to register an iCLA:
1. Details of the iCLA and the forms are found
through this link: https://www.apache.org/licenses/#clas
2. Instructions for its completion and return to
the Secretary of the ASF are found at
- https://www.apache.org/licenses/#submitting
+ https://www.apache.org/licenses/contributor-agreements.html#submitting
+
+ Do not copy the project or any other individual on your message
+ to Secretary, as the form contains Personally Identifiable Information
+ that should be kept private.
- 3. When you transmit the completed iCLA, request
- to notify the Apache [Project] project and choose a
+ 3. When you fill the iCLA form, include in the form
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] bproffitt commented on pull request #82: Update newcommitter.md
Posted by "bproffitt (via GitHub)" <gi...@apache.org>.
bproffitt commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1428482573
@sebbASF Do you still have outstanding review requests? GitHub thinks you do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on a diff in pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1098058461
##########
source/newcommitter.md:
##########
@@ -227,21 +236,40 @@ sent after a positive result from the vote for a new committer.
Of course, you can decline and instead remain as a
contributor, participating as you do now.
- A. This personal invitation is a chance for you to
- accept or decline in private. Either way, please
- let us know in reply to the private@[PROJECT].apache.org
- address only.
+ This personal invitation is a chance for you to accept or decline in private.
+ Please let us know in reply to this message whether you accept or decline.
+
+ A. If you accept, you will need an Apache account (id) with privileges.
+ Please follow these instructions.
+
+ 1. If you already have an Apache account, let us know your id and we
+ will grant you privileges on the project repositories.
+
+ 2. If you have previously sent an iCLA, let us know the email address
Review Comment:
Either iCLA or ICLA is used and I did not want to overly complicate this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] sebbASF commented on pull request #82: Update newcommitter.md
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1418296812
I'd like to see the updated PR before commenting further
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1418302880
> On Feb 5, 2023, at 15:32, sebbASF ***@***.***> wrote:
>
>
> I'd like to see the updated PR before commenting further
>
>
I've pushed all changes to the patch-1 branch.
Latest commit 6fb6dff <https://github.com/clr-apache/comdev-site/commit/6fb6dff9a984ebc11c7a78e764d915d72ebd85c8> yesterday in response to your comments.
It's ready for final review. I cannot merge it because I have no commit privileges to this repo.
Thanks,
Craig
> —
> Reply to this email directly, view it on GitHub <https://github.com/apache/comdev-site/pull/82#issuecomment-1418296812>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4M6RH3S6QPI37YDR5Q4ILWWAZ7JANCNFSM6AAAAAATWCP4LI>.
> You are receiving this because you authored the thread.
>
Craig L Russell
***@***.***
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] sebbASF commented on pull request #82: Update newcommitter.md
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1428892926
What happened to the Committer Accept Template?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1428926714
@sebbASF The Committer Accept is no longer needed because the information it used to contain was moved.
Information about getting account privileges was moved to the Committer Invite Template.
Information about how-it-works and other general topics was moved to Committer Done Template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] jvz commented on a diff in pull request #82: Update newcommitter.md
Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1097757847
##########
source/newcommitter.md:
##########
@@ -75,17 +75,19 @@ later in this document.
<a name="NewCommitter-Summary"></a>
### Summary
-1. Call a vote (templates/committerVote.txt)
-1. Close the vote
+1. Discuss the proposed committer/PMC member. If positive, call a vote (templates/committerVote.txt)
+1. Close the vote (templates/closeVote.txt)
1. If the result is positive, invite the new committer (templates/committerInvite.txt)
If they accept, then:
-1. Accept the committer (templates/committerAccept.txt)
-1. Wait until we see that receipt of CLA is recorded
-1. Request creation of the committer account (template/committerCreate.txt)
+1. If they already have an Apache id, grant appropriate commit privileges.
+1. If they have already filed an ICLA, request creation of the committer account.
Review Comment:
And here would be nice to have a link to the list of ICLAs already filed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
Please review/merge this PR
Posted by Craig Russell <ap...@gmail.com>.
This PR is ready for comments in preparation for merge to main.
Regards,
Craig
> Begin forwarded message:
>
> From: clr-apache (via GitHub) <gi...@apache.org>
> Subject: [GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
> Date: February 3, 2023 at 14:59:53 PST
> To: dev@community.apache.org
> Reply-To: dev@community.apache.org
>
>
> clr-apache commented on PR #82:
> URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1416505062
>
> This PR updates the recommended process for inviting new committers/PMC members. It has detailed instructions to the candidate in cases where they already have an Apache id or have previously filed an ICLA.
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
> For additional commands, e-mail: dev-help@community.apache.org
>
Craig L Russell
clr@apache.org
[GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1416505062
This PR updates the recommended process for inviting new committers/PMC members. It has detailed instructions to the candidate in cases where they already have an Apache id or have previously filed an ICLA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on a diff in pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1098057818
##########
source/newcommitter.md:
##########
@@ -75,17 +75,19 @@ later in this document.
<a name="NewCommitter-Summary"></a>
### Summary
-1. Call a vote (templates/committerVote.txt)
-1. Close the vote
+1. Discuss the proposed committer/PMC member. If positive, call a vote (templates/committerVote.txt)
+1. Close the vote (templates/closeVote.txt)
1. If the result is positive, invite the new committer (templates/committerInvite.txt)
If they accept, then:
-1. Accept the committer (templates/committerAccept.txt)
-1. Wait until we see that receipt of CLA is recorded
-1. Request creation of the committer account (template/committerCreate.txt)
+1. If they already have an Apache id, grant appropriate commit privileges.
+1. If they have already filed an ICLA, request creation of the committer account.
Review Comment:
Not really, the user would have to tell us that they have filed a CLA. Only officers and members can see them and they have to provide the email address or name it was filed under.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1423466203
Can someone with commit privileges please merge patch1?
Or tell me anything else needed. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] sebbASF commented on a diff in pull request #82: Update newcommitter.md
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1101225078
##########
source/newcommitter.md:
##########
@@ -227,83 +237,50 @@ sent after a positive result from the vote for a new committer.
Of course, you can decline and instead remain as a
contributor, participating as you do now.
- A. This personal invitation is a chance for you to
- accept or decline in private. Either way, please
- let us know in reply to the private@[PROJECT].apache.org
- address only.
+ This personal invitation is a chance for you to accept or decline in private.
+ Please let us know in reply to this message whether you accept or decline.
+
+ A. If you accept, you will need an Apache account (id) with privileges.
Review Comment:
The placing of the A. prefix does not really correspond with the sentence at B.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] ShaneCurcuru merged pull request #82: Update newcommitter.md
Posted by "ShaneCurcuru (via GitHub)" <gi...@apache.org>.
ShaneCurcuru merged PR #82:
URL: https://github.com/apache/comdev-site/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on a diff in pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1101679831
##########
source/newcommitter.md:
##########
@@ -227,83 +237,50 @@ sent after a positive result from the vote for a new committer.
Of course, you can decline and instead remain as a
contributor, participating as you do now.
- A. This personal invitation is a chance for you to
- accept or decline in private. Either way, please
- let us know in reply to the private@[PROJECT].apache.org
- address only.
+ This personal invitation is a chance for you to accept or decline in private.
+ Please let us know in reply to this message whether you accept or decline.
+
+ A. If you accept, you will need an Apache account (id) with privileges.
Review Comment:
Yes, I've updated the instructions. A is if you have an ICLA on file. B is if you need to file an ICLA.
Thanks for the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on PR #82:
URL: https://github.com/apache/comdev-site/pull/82#issuecomment-1428478068
Can someone with commit privileges please merge patch1? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on a diff in pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1096610143
##########
source/newcommitter.md:
##########
@@ -75,17 +75,18 @@ later in this document.
<a name="NewCommitter-Summary"></a>
### Summary
-1. Call a vote (templates/committerVote.txt)
-1. Close the vote
+1. Discuss the proposed committer/PMC member. If positive, call a vote (templates/committerVote.txt)
+1. Close the vote (templates/closeVote.txt)
1. If the result is positive, invite the new committer (templates/committerInvite.txt)
If they accept, then:
-1. Accept the committer (templates/committerAccept.txt)
-1. Wait until we see that receipt of CLA is recorded
-1. Request creation of the committer account (template/committerCreate.txt)
+1. If they already have an Apache id, grant appropriate commit privileges.
+1. If they have already filed an ICLA, request creation of the committer account.
+ If they need to change anything in a previously filed ICLA, wait until the new ICLA is filed,
+ then request the account.
1. Wait until root says it is done
- 1. PMC Chair enables svn and other access
+ 1. PMC Chair enables svn, github, and other access
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] clr-apache commented on a diff in pull request #82: Update newcommitter.md
Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1096610203
##########
source/newcommitter.md:
##########
@@ -368,15 +345,34 @@ This is the email to announce the new committer to `[PROJECT]-dev` once the acco
[PROJECT] has various resources at:
https://svn.apache.org/repos/asf/[PROJECT]
+ https://github.com/apache/[PROJECT-REPOSITORY]
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] sebbASF commented on a diff in pull request #82: Update newcommitter.md
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on code in PR #82:
URL: https://github.com/apache/comdev-site/pull/82#discussion_r1096382560
##########
source/newcommitter.md:
##########
@@ -75,17 +75,18 @@ later in this document.
<a name="NewCommitter-Summary"></a>
### Summary
-1. Call a vote (templates/committerVote.txt)
-1. Close the vote
+1. Discuss the proposed committer/PMC member. If positive, call a vote (templates/committerVote.txt)
+1. Close the vote (templates/closeVote.txt)
1. If the result is positive, invite the new committer (templates/committerInvite.txt)
If they accept, then:
-1. Accept the committer (templates/committerAccept.txt)
-1. Wait until we see that receipt of CLA is recorded
-1. Request creation of the committer account (template/committerCreate.txt)
+1. If they already have an Apache id, grant appropriate commit privileges.
+1. If they have already filed an ICLA, request creation of the committer account.
+ If they need to change anything in a previously filed ICLA, wait until the new ICLA is filed,
+ then request the account.
1. Wait until root says it is done
- 1. PMC Chair enables svn and other access
+ 1. PMC Chair enables svn, github, and other access
Review Comment:
AFAIK, it is up to the committer to set up their GitHub account and link it to their ASF account.
The Chair is not directly involved, except insofar as they are required to set up LDAP membership.
Perhaps put:
PMC Chair updates LDAP group membership which enables svn, git and other access.
If the committer wishes to use GitHub, they are responsible for setting up their account and linking it to their ASF account
##########
source/newcommitter.md:
##########
@@ -227,21 +235,42 @@ sent after a positive result from the vote for a new committer.
Of course, you can decline and instead remain as a
contributor, participating as you do now.
- A. This personal invitation is a chance for you to
- accept or decline in private. Either way, please
- let us know in reply to the private@[PROJECT].apache.org
+ This personal invitation is a chance for you to
+ accept or decline in private.
+ If you decline, please let us know in reply to the private@[PROJECT].apache.org
address only.
+
+ A. If you accept, you will need an Apache account (id) with privileges. Please follow
+ these instructions.
+
+ 1. If you already have an Apache account, let us know your id and we
+ will grant you privileges on the project repositories.
+
+ 2. If you have previously sent an iCLA, let us know the email address
+ and public name used on the iCLA and your preferred Apache id, and
+ we will request your account.
- B. If you accept, the next step is to register an iCLA:
+ 3. If the email address on the previously submitted iCLA is no longer
+ valid, let us know the email address and public name used on the new iCLA,
+ and your preferred Apache id. Continue to step B below and file your new iCLA.
+
+ Look to see if your preferred ID is already taken at
+ https://people.apache.org/committer-index.html
+
+ B. Otherwise, you need to register an iCLA:
1. Details of the iCLA and the forms are found
through this link: https://www.apache.org/licenses/#clas
2. Instructions for its completion and return to
the Secretary of the ASF are found at
- https://www.apache.org/licenses/#submitting
+ https://www.apache.org/licenses/contributor-agreements.html#submitting
+
+ Do not copy the project or any other individual on your message
+ to Secretary, as the form contains Personally Identifiable Information
+ that should be kept private.
- 3. When you transmit the completed iCLA, request
- to notify the Apache [Project] project and choose a
+ 3. When you fill the iCLA form, include in the form
Review Comment:
'fill' => 'complete'
'include in the form' => 'please ensure you include'
##########
source/newcommitter.md:
##########
@@ -227,21 +235,42 @@ sent after a positive result from the vote for a new committer.
Of course, you can decline and instead remain as a
contributor, participating as you do now.
- A. This personal invitation is a chance for you to
- accept or decline in private. Either way, please
- let us know in reply to the private@[PROJECT].apache.org
+ This personal invitation is a chance for you to
+ accept or decline in private.
+ If you decline, please let us know in reply to the private@[PROJECT].apache.org
Review Comment:
If the user accepts, they also need to reply to the list!
##########
source/newcommitter.md:
##########
@@ -368,15 +345,34 @@ This is the email to announce the new committer to `[PROJECT]-dev` once the acco
[PROJECT] has various resources at:
https://svn.apache.org/repos/asf/[PROJECT]
+ https://github.com/apache/[PROJECT-REPOSITORY]
Review Comment:
The gitbox URL should be quoted in preference to the 3rd party GitHub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org