You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stormcrawler.apache.org by "rzo1 (via GitHub)" <gi...@apache.org> on 2024/03/27 20:12:10 UTC
[I] Drop coveralls code-coverage flow? [incubator-stormcrawler]
rzo1 opened a new issue, #1162:
URL: https://github.com/apache/incubator-stormcrawler/issues/1162
Can we drop the coveralls github action?
I did a quick search at ASF level and I think, that only datasketches-cpp is using it. So might be good to just drop it and rely on other test coverage report metrics, which are more common at ASF level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@stormcrawler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Drop coveralls code-coverage flow? [incubator-stormcrawler]
Posted by "sigee (via GitHub)" <gi...@apache.org>.
sigee commented on issue #1162:
URL: https://github.com/apache/incubator-stormcrawler/issues/1162#issuecomment-2314813471
Hi,
For checking and requiring a minimum test coverage you could use jacoco as it is used in [apache commons project](https://github.com/apache/commons-parent/blob/master/pom.xml#L218).
There is no generated badge for readme, but the pipeline could work perfectly by require a minimum coverage for different metrics (line coverage, branch coverage, class coverage, etc.).
Jacoco is already part of this project, so only the configuration is needed here.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Drop coveralls code-coverage flow? [incubator-stormcrawler]
Posted by "jnioche (via GitHub)" <gi...@apache.org>.
jnioche closed issue #1162: Drop coveralls code-coverage flow?
URL: https://github.com/apache/incubator-stormcrawler/issues/1162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Drop coveralls code-coverage flow? [incubator-stormcrawler]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on issue #1162:
URL: https://github.com/apache/incubator-stormcrawler/issues/1162#issuecomment-2314835389
I am using Jacoco in most of my projects ;-) - I have no objections in replacing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Drop coveralls code-coverage flow? [incubator-stormcrawler]
Posted by "lewismc (via GitHub)" <gi...@apache.org>.
lewismc commented on issue #1162:
URL: https://github.com/apache/incubator-stormcrawler/issues/1162#issuecomment-2024082127
SonarCloud.io is very good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org