You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@kafka.apache.org by john cheng <zq...@gmail.com> on 2017/06/16 16:26:01 UTC
comment in addStandbyTasks() method of StreamThread has some typos
https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L1345
This Line:
log.info("{} Adding assigned standby tasks {}", logPrefix, partitionAssignor
.activeTasks());
The parameter is active task, but the info content is standby tasks.
This should be change to
log.info("{} Adding assigned standby tasks {}", logPrefix, partitionAssignor
.standbyTasks());
Re: comment in addStandbyTasks() method of StreamThread has some typos
Posted by john cheng <zq...@gmail.com>.
ok, I'll open an PR to fix this.
2017-06-17 0:59 GMT+08:00 Matthias J. Sax <ma...@confluent.io>:
> Thanks for reporting this!
>
> Would you like to open a MINOR PR to fix it? Don't think we need a Jira
> for this.
>
> -Matthias
>
> On 6/16/17 9:26 AM, john cheng wrote:
> > https://github.com/apache/kafka/blob/trunk/streams/src/
> main/java/org/apache/kafka/streams/processor/internals/
> StreamThread.java#L1345
> >
> > This Line:
> > log.info("{} Adding assigned standby tasks {}", logPrefix,
> partitionAssignor
> > .activeTasks());
> > The parameter is active task, but the info content is standby tasks.
> >
> > This should be change to
> >
> > log.info("{} Adding assigned standby tasks {}", logPrefix,
> partitionAssignor
> > .standbyTasks());
> >
>
>
Re: comment in addStandbyTasks() method of StreamThread has some
typos
Posted by "Matthias J. Sax" <ma...@confluent.io>.
Thanks for reporting this!
Would you like to open a MINOR PR to fix it? Don't think we need a Jira
for this.
-Matthias
On 6/16/17 9:26 AM, john cheng wrote:
> https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L1345
>
> This Line:
> log.info("{} Adding assigned standby tasks {}", logPrefix, partitionAssignor
> .activeTasks());
> The parameter is active task, but the info content is standby tasks.
>
> This should be change to
>
> log.info("{} Adding assigned standby tasks {}", logPrefix, partitionAssignor
> .standbyTasks());
>