You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by y-shimizu <gi...@git.apache.org> on 2015/09/24 14:11:13 UTC
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
GitHub user y-shimizu opened a pull request:
https://github.com/apache/spark/pull/8904
[SPARK-10778][MLlib]Implement toString for AssociationRules.Rule
I implemented toString for AssociationRules.Rule, format like `[x, y] => {z}: 1.0`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/y-shimizu/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8904
----
commit 85406cbae57f3003a0177a7a601e71b8b70364b1
Author: y-shimizu <y....@gmail.com>
Date: 2015-09-24T12:05:04Z
[SPARK-10778][MLlib]Implement toString for AssociationRules.Rule
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143550190
[Test build #1819 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1819/consoleFull) for PR 8904 at commit [`ae12fba`](https://github.com/apache/spark/commit/ae12fbaab7e757aaaaaa6ddb29f6d4ca6451f335).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143568281
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143465445
[Test build #1817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1817/console) for PR 8904 at commit [`ae12fba`](https://github.com/apache/spark/commit/ae12fbaab7e757aaaaaa6ddb29f6d4ca6451f335).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143461976
[Test build #1816 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1816/consoleFull) for PR 8904 at commit [`ae12fba`](https://github.com/apache/spark/commit/ae12fbaab7e757aaaaaa6ddb29f6d4ca6451f335).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8904#discussion_r40336087
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
@@ -142,5 +142,13 @@ object AssociationRules {
def javaConsequent: java.util.List[Item] = {
consequent.toList.asJava
}
+
+ /**
+ * @return [antecedent] => [consequent]: [confidence]
--- End diff --
Sure, I don't feel strongly about it. Wouldn't this argument go for all return docs though? They're hidden by default for brevity. Maybe important ones should be put inline in the main doc but `toString` seems pretty minor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by y-shimizu <gi...@git.apache.org>.
Github user y-shimizu commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143128275
@mengxr I fixed format.
So, which I should use, `Returns` or `@return` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by y-shimizu <gi...@git.apache.org>.
Github user y-shimizu commented on a diff in the pull request:
https://github.com/apache/spark/pull/8904#discussion_r40313040
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
@@ -142,5 +142,14 @@ object AssociationRules {
def javaConsequent: java.util.List[Item] = {
consequent.toList.asJava
}
+
+ /**
+ * Returns String, [antecedent] => [consequent]: [confidence]
--- End diff --
@srowen
Thank you for review.
I fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8904#discussion_r40334311
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
@@ -142,5 +142,13 @@ object AssociationRules {
def javaConsequent: java.util.List[Item] = {
consequent.toList.asJava
}
+
+ /**
+ * @return [antecedent] => [consequent]: [confidence]
--- End diff --
Actually, I think `Returns` is better than `@return`. If we use `@return`, the message doesn't show up by default in the API doc, e.g.,
User needs to open it to see the doc:
If we use `Returns`, it shows up by default:
@srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-142911857
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8904
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143174303
[Test build #1815 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1815/consoleFull) for PR 8904 at commit [`1f9ce43`](https://github.com/apache/spark/commit/1f9ce435f44a372d8828490eca00f095b9bbfbec).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143560244
[Test build #1819 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1819/console) for PR 8904 at commit [`ae12fba`](https://github.com/apache/spark/commit/ae12fbaab7e757aaaaaa6ddb29f6d4ca6451f335).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8904#discussion_r40334364
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
@@ -142,5 +142,13 @@ object AssociationRules {
def javaConsequent: java.util.List[Item] = {
consequent.toList.asJava
}
+
+ /**
+ * @return [antecedent] => [consequent]: [confidence]
+ */
+ @Since("1.6.0")
--- End diff --
For methods inherited from `Object`, we don't need `@Since`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143151203
`Returns`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143463822
[Test build #1816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1816/console) for PR 8904 at commit [`ae12fba`](https://github.com/apache/spark/commit/ae12fbaab7e757aaaaaa6ddb29f6d4ca6451f335).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143464162
[Test build #1817 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1817/consoleFull) for PR 8904 at commit [`ae12fba`](https://github.com/apache/spark/commit/ae12fbaab7e757aaaaaa6ddb29f6d4ca6451f335).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by y-shimizu <gi...@git.apache.org>.
Github user y-shimizu commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143414381
@srowen I fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143174654
[Test build #1815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1815/console) for PR 8904 at commit [`1f9ce43`](https://github.com/apache/spark/commit/1f9ce435f44a372d8828490eca00f095b9bbfbec).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143175073
We still need a return type on the method, and the line is too long and needs to be wrapped
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8904#discussion_r40377349
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
@@ -142,5 +142,13 @@ object AssociationRules {
def javaConsequent: java.util.List[Item] = {
consequent.toList.asJava
}
+
+ /**
+ * @return [antecedent] => [consequent]: [confidence]
--- End diff --
For each method, there should be a summary sentence at the beginning, which shows up in the API doc by default. Other details are hidden by default. I think this is Scala specific. You can find the official guide at http://docs.scala-lang.org/style/scaladoc.html:
~~~
If the documentation of a method is a one line description of
what that method returns, do not repeat it with an @return annotation.
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by y-shimizu <gi...@git.apache.org>.
Github user y-shimizu commented on the pull request:
https://github.com/apache/spark/pull/8904#issuecomment-143164580
@mengxr I fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8904#discussion_r40311967
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
@@ -142,5 +142,14 @@ object AssociationRules {
def javaConsequent: java.util.List[Item] = {
consequent.toList.asJava
}
+
+ /**
+ * Returns String, [antecedent] => [consequent]: [confidence]
--- End diff --
Trivial, but you should use `@return` and there's no need to state the return type again. Remove the blank line below too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10778][MLlib]Implement toString for Ass...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8904#discussion_r40334462
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
@@ -142,5 +142,13 @@ object AssociationRules {
def javaConsequent: java.util.List[Item] = {
consequent.toList.asJava
}
+
+ /**
+ * @return [antecedent] => [consequent]: [confidence]
+ */
+ @Since("1.6.0")
+ override def toString = {
+ s"${javaAntecedent} => ${javaConsequent}: ${confidence}"
--- End diff --
Using `javaAntecedent` is hacky. We should use `antecedent.mkString("{", ",", "}")` instead. Same for `consequent`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org