You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/25 14:46:08 UTC
[GitHub] [flink] carp84 commented on a change in pull request #13772: [FLINK-19748] Iterating key groups in raw keyed stream on restore fails if some key groups weren't written
carp84 commented on a change in pull request #13772:
URL: https://github.com/apache/flink/pull/13772#discussion_r511606110
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/AbstractStreamOperatorTest.java
##########
@@ -444,10 +445,11 @@ public void testCustomRawKeyedStateSnapshotAndRestore() throws Exception {
final int maxParallelism = 10;
final int numSubtasks = 1;
final int subtaskIndex = 0;
- final KeyGroupRange keyGroupRange = KeyGroupRange.of(0, maxParallelism - 1);
+ final List<Integer> keyGroupsToWrite = Arrays.asList(2, 3, 8);
Review comment:
Maybe we could extract the common logic out as a utility test method and add another test case in name of like `testCustomRawKeyedStateSnapshotAndRestoreWithPartialWrittenKeyGroups`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org