You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/01/31 22:06:23 UTC

[GitHub] [commons-io] tbw777 opened a new pull request, #427: Simplified res closing and prevented creating/closing process OutputS…

tbw777 opened a new pull request, #427:
URL: https://github.com/apache/commons-io/pull/427

   …tream and ErrorStream.
   
   There is no needed to make local variables as null and opening unused streams to close them later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-io] tbw777 commented on pull request #427: Simplified res closing and prevented creating/closing process OutputS…

Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #427:
URL: https://github.com/apache/commons-io/pull/427#issuecomment-1412484450

   @garydgregory 
   The exception will also be thrown to the top because there is no corresponding catch as in the original version. Or do you mean something else?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-io] garydgregory commented on pull request #427: Simplified res closing and prevented creating/closing process OutputS…

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #427:
URL: https://github.com/apache/commons-io/pull/427#issuecomment-1412210060

   My only concern here is that the method will now fail if _anything_ goes wrong closing streams. This is a change in behavior that we do not test apparently. This could be considered reasonable if other processes try to use the same resources but I am not 100% sure. What do others think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-io] garydgregory commented on pull request #427: Simplified res closing and prevented creating/closing process OutputS…

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #427:
URL: https://github.com/apache/commons-io/pull/427#issuecomment-1413025670

   Hm, two behavior might be the same indeed. I'll look again in the AM.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-io] tbw777 closed pull request #427: Simplified res closing and prevented creating/closing process OutputS…

Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #427: Simplified res closing and prevented creating/closing process OutputS…
URL: https://github.com/apache/commons-io/pull/427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org