You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/11 07:08:53 UTC
[GitHub] [beam] arunpandianp opened a new pull request, #17333: [BEAM-14283] BigQueryServicesImpl: reduce number of threads spawned by BoundedExecutorService
arunpandianp opened a new pull request, #17333:
URL: https://github.com/apache/beam/pull/17333
Moving the semaphore aquire to outside the runnable, the tasks now wait before
getting submitted to the executor and reuse existing threads.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #17333: [BEAM-14283] BigQueryServicesImpl: reduce number of threads spawned by BoundedExecutorService
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17333:
URL: https://github.com/apache/beam/pull/17333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17333: [BEAM-14283] BigQueryServicesImpl: reduce number of threads spawned by BoundedExecutorService
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17333:
URL: https://github.com/apache/beam/pull/17333#issuecomment-1094631611
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17333: [BEAM-14283] BigQueryServicesImpl: reduce number of threads spawned by BoundedExecutorService
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17333:
URL: https://github.com/apache/beam/pull/17333#issuecomment-1094631608
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17333: [BEAM-14283] BigQueryServicesImpl: reduce number of threads spawned by BoundedExecutorService
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17333:
URL: https://github.com/apache/beam/pull/17333#issuecomment-1100287311
LGTM thanks all. @arunpandianp please make sure to share any testing outcome form this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] arunpandianp commented on pull request #17333: [BEAM-14283] BigQueryServicesImpl: reduce number of threads spawned by BoundedExecutorService
Posted by GitBox <gi...@apache.org>.
arunpandianp commented on PR #17333:
URL: https://github.com/apache/beam/pull/17333#issuecomment-1097276526
> Is the intended change meant to chain futures whenever executor.submit(callable) is called?
Yes the release is chained with the future. `semaphore.acquire();` runs on taskSubmitExecutor and `semaphore::release` runs on taskExecutor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] arunpandianp commented on pull request #17333: [BEAM-14283] BigQueryServicesImpl: reduce number of threads spawned by BoundedExecutorService
Posted by GitBox <gi...@apache.org>.
arunpandianp commented on PR #17333:
URL: https://github.com/apache/beam/pull/17333#issuecomment-1098570125
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17333: [BEAM-14283] BigQueryServicesImpl: reduce number of threads spawned by BoundedExecutorService
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17333:
URL: https://github.com/apache/beam/pull/17333#issuecomment-1094631607
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org