You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Nandu9494 (via GitHub)" <gi...@apache.org> on 2025/08/07 21:57:02 UTC
[PR] fix: strip html content when applying filter from drill-down menu [superset]
Nandu9494 opened a new pull request, #34605:
URL: https://github.com/apache/superset/pull/34605
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Strip out HTML tags when applying filter into SQL just as we do when showing in `Menu`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
**After**
<img width="1035" height="797" alt="Screenshot 2025-08-08 at 3 25 26 AM" src="https://github.com/user-attachments/assets/a73d6151-a6e8-4efd-90dd-06da4b417923" />
**Before**
<img width="1027" height="842" alt="Screenshot 2025-08-08 at 3 26 06 AM" src="https://github.com/user-attachments/assets/7b0ae1ca-ed2b-453c-b1e1-71b34422ca3e" />
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
Fixes #33771
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3181196635
@Nandu9494 I am not sure what you mean by that but i am pretty sure i can't replicate this in master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz closed pull request #34605: fix: strip html content when applying filter from drill-down menu
URL: https://github.com/apache/superset/pull/34605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3178770071
@msyavuz Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/16906361978). Action: **up**. More information on [how to use or configure ephemeral environments](https://superset.apache.org/docs/contributing/howtos/#github-ephemeral-environments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "Nandu9494 (via GitHub)" <gi...@apache.org>.
Nandu9494 commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3181049967
Hi, I tested the same in master in local issue seems to be there as well, can you share metric configuration you did in master env?
https://github.com/user-attachments/assets/8edbdbde-acd6-4ed0-aa56-4ed3260adfe8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3182902531
@Nandu9494 i used the exact same steps i used in the eph environment here.
```
'<a href="https://www.google.com/search?q=' || product_line || '">' || product_line || '</a>'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3169138193
Oooh, interesting! Running CI 🤞. Would love to see this for cross-filters too (that drives me a bit nuts in some dashboards).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3178796861
@msyavuz Ephemeral environment spinning up at http://34.221.85.75:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "b4s36t4 (via GitHub)" <gi...@apache.org>.
b4s36t4 commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3183248698
Hi, @msyavuz
I have updated the chart, now it's re-producible in master as well. Before my change the column name is `My Column` but when it's changed to `product_line` it didn't return any results.
<img width="440" height="344" alt="Screenshot 2025-08-13 at 4 05 14 PM" src="https://github.com/user-attachments/assets/ddbdf6fc-2f86-440c-9f27-f7dab207db80" />
eph environment related to this PR also has `product_line` as column, if you change it to any other it's not producible same as master env.
I think the changes @Nandu9494 pushed yesterday should fix the issue, seems the query itself is going with html tags, the change he pushed is removing the html tags I guess.
> Sorry if I shouldn't be here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "Nandu9494 (via GitHub)" <gi...@apache.org>.
Nandu9494 commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3172091223
hey, @rusackas, I see E2E tests are failing, can you check? I think it's not related to the changes, let me know if I need to make any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3180590454
I tested the issue steps in the eph environment and it is still there. Weirdly enough this issue seems to disappear on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3183087285
http://44.250.219.116:8080/superset/dashboard/12/?native_filters_key=LWQvciL4o1A
Here's a eph environment and a dashboard that doesn't have this issue on master @Nandu9494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #34605:
URL: https://github.com/apache/superset/pull/34605#discussion_r2261530636
##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailMenuItems.tsx:
##########
@@ -227,7 +238,7 @@ const DrillDetailMenuItems = ({
{filters.length > 1 && (
<Menu.Item
key="drill-detail-filter-all"
- onClick={openModal.bind(null, filters)}
+ onClick={openModal.bind(null, cleanedFilters)}
Review Comment:
### Missing Event Parameter in Modal Open Handler <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The openModal callback expects filters and event parameters, but the event parameter is not being passed when binding with cleanedFilters.
###### Why this matters
Missing the event parameter could lead to undefined event object in the openModal function, potentially causing issues when the onClick handler tries to use the event object.
###### Suggested change ∙ *Feature Preview*
Modify the code to properly pass both the filters and event parameters:
```typescript
onClick={(event) => openModal(cleanedFilters, event)}
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:195ba756-98cd-4135-afaf-c6771552cbe9 -->
[](195ba756-98cd-4135-afaf-c6771552cbe9)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "Nandu9494 (via GitHub)" <gi...@apache.org>.
Nandu9494 commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3181112597
hey, I tried in local master which synced up with master when I tried and still able to get the same. Anyhow possible to re-deploy the same pushed the same change for `Drill By` filters which will do the same as removing HTML tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3181070534
@Nandu9494 Your forks master is not up to date with superset master. Can you sync and try again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]
Posted by "Nandu9494 (via GitHub)" <gi...@apache.org>.
Nandu9494 commented on PR #34605:
URL: https://github.com/apache/superset/pull/34605#issuecomment-3182391284
Can you share metric config for the chart? I didn't see this issue if the metric name is different i.e eph envionrment the column name `product_line` which matches with DB column name, if they're different I didn't see this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org