Re: svn commit: r1041102 - /subversion/trunk/subversion/include/svn_io.h

[Julian Foad <ju...@wandisco.com>]

On Thu, 2010-12-02, Daniel Shahaf wrote:
> julianfoad@apache.org wrote on Wed, Dec 01, 2010 at 17:44:50 -0000:
> > -/** Copy file @a file from location @a src_path to location @a dest_path.
> > - * Use @a pool for memory allocations.
> > +/** Copy the file whose basename or relative path is @a file within
> > + * directory @a src_path to the same basename or relative path within
> > + * directory @a dest_path.  Overwrite the destination if it already
> 
> If you allow relative paths as input for @a file, then shouldn't the
> docstring say whether or not this creates intermediate directories?
> 
> Example: svn_io_dir_file_copy('A/B', 'A/C', 'E/alpha', NULL).

r1041336. Thanks.

- Julian


> > + * exists.  Set the destination file's permissions to match those of
> > + * the source.  Use @a pool for memory allocations.
> >   */
> >  svn_error_t *
> >  svn_io_dir_file_copy(const char *src_path,
> >                       const char *dest_path,
> >                       const char *file,
> >                       apr_pool_t *pool)
> > 
> >