You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/09/12 09:58:05 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #995: Fix the experiment pods label selector after using the new training operator
cdmikechen opened a new pull request, #995:
URL: https://github.com/apache/submarine/pull/995
### What is this PR for?
After updated to new training operator, the metrics/logs/params of the experiment cannot be shown, which is found that the pod label had changed to `job-name`.
### What type of PR is it?
Bug Fix
### Todos
* [x] - Change label to job-name
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1324
### How should this be tested?
Consider adding after refactoring.
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #995: SUBMARINE-1324. Fix the experiment pods label selector after using the new training operator
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #995: SUBMARINE-1324. Fix the experiment pods label selector after using the new training operator
URL: https://github.com/apache/submarine/pull/995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #995: SUBMARINE-1324. Fix the experiment pods label selector after using the new training operator
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on PR #995:
URL: https://github.com/apache/submarine/pull/995#issuecomment-1269243518
This issue has been merged for the time being as it will affect the flow of the experiment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #995: Fix the experiment pods label selector after using the new training operator
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #995:
URL: https://github.com/apache/submarine/pull/995#issuecomment-1243530573
# [Codecov](https://codecov.io/gh/apache/submarine/pull/995?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#995](https://codecov.io/gh/apache/submarine/pull/995?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7203c98) into [master](https://codecov.io/gh/apache/submarine/commit/806fcb2181e5cef5f40f4e57aa941fae53ee5217?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (806fcb2) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #995 +/- ##
============================================
- Coverage 14.27% 14.27% -0.01%
+ Complexity 992 991 -1
============================================
Files 241 241
Lines 23897 23891 -6
Branches 3473 3471 -2
============================================
- Hits 3412 3410 -2
+ Misses 20279 20274 -5
- Partials 206 207 +1
```
| [Impacted Files](https://codecov.io/gh/apache/submarine/pull/995?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/submarine/server/submitter/k8s/K8sSubmitter.java](https://codecov.io/gh/apache/submarine/pull/995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9LOHNTdWJtaXR0ZXIuamF2YQ==) | `39.33% <0.00%> (+1.26%)` | :arrow_up: |
| [...server/submitter/k8s/model/mljob/MLJobFactory.java](https://codecov.io/gh/apache/submarine/pull/995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9tb2RlbC9tbGpvYi9NTEpvYkZhY3RvcnkuamF2YQ==) | `81.81% <0.00%> (-8.19%)` | :arrow_down: |
| [.../submarine/server/websocket/ConnectionManager.java](https://codecov.io/gh/apache/submarine/pull/995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci93ZWJzb2NrZXQvQ29ubmVjdGlvbk1hbmFnZXIuamF2YQ==) | `53.65% <0.00%> (-4.88%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org