You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacopo Cappellato (JIRA)" <ji...@ofbiz.org> on 2006/08/26 15:07:20 UTC
[JIRA] Closed: (OFBIZ-266) Existing shippingContactMechId in cart overridden by finalizeOrderEntry
[ http://jira.undersunconsulting.com/browse/OFBIZ-266?page=all ]
Jacopo Cappellato closed OFBIZ-266:
-----------------------------------
Resolution: Won't Fix
I think that a better approach is to skip the call to the finalizeOrderEntryShip method; the finalizeOrderEntry method has been recently simplified and this should be easier now. For now I'll close this issue.
> Existing shippingContactMechId in cart overridden by finalizeOrderEntry
> -----------------------------------------------------------------------
>
> Key: OFBIZ-266
> URL: http://jira.undersunconsulting.com/browse/OFBIZ-266
> Project: [OFBiz] Open For Business
> Type: Bug
> Components: order
> Versions: SVN
> Environment: Rev: 5064
> Reporter: Ashish Hareet
> Assignee: Jira Administrator
> Priority: Minor
>
>
> I'm currently working on re-defining the order entry process flow & it differs in it's data collection routine from the OfBiz implementation. But for the backend logic I'm sticking with the core logic as defined in the current order entry impl.
> The problem is that the existing order entry process flow assumes that shippingContactMechId comes at a later step after items have been ordered & so in case you have defined it for the cart but during finalizeOrderEntry, it doesn't get it's required parameter via the request, it simply returns an error, when(I think) it should also check for an existing shippingContactMechId before returning an error.
> A check like this in CheckOutHelper.finalizeOrderEntryShip should suffice
> if (UtilValidate.isNotEmpty(shippingContactMechId)) {
> this.cart.setShippingContactMechId(shippingContactMechId);
> result = ServiceUtil.returnSuccess();
> }else if(this.cart.getShippingContactMechId() != null){
> result = ServiceUtil.returnSuccess();
> }else {
> errMsg = UtilProperties.getMessage(resource,"checkhelper.enter_shipping_address", (cart != null ? cart.getLocale() : Locale.getDefault()));
> result = ServiceUtil.returnError(errMsg);
> }
> In case this is not a bug, but is a requirement, I'd appreciate if I get some feedback as to why...
> Also, in case I'm getting this all wrong, please let me know where I'm wrong.
> Thanks
> Ashish Hareet
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.undersunconsulting.com/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira