You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/06/01 11:19:26 UTC
Review Request 34885: LENS-531: Add cli command to show all queryable
fields with description for a cube
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/QueryableFieldList.java PRE-CREATION
lens-api/src/main/resources/cube-0.1.xsd 1e8d71d8ce430ad0404ec425e738d5de2529a03f
lens-cli/pom.xml 7b98523140a332e55a77019c1128189aa2b5ec0f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/commands/converter/XDimAttributesToTableConverter.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a6651f6a8f896974498d3c29a88c1c1ad0b54b49
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 5a1f8f9e4920e76a7436183776b3785d05f7869d
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
Diff: https://reviews.apache.org/r/34885/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review86166
-----------------------------------------------------------
Changes look fine. Can you include unit tests?
- Amareshwari Sriramadasu
On June 1, 2015, 9:39 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 9:39 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-531
> https://issues.apache.org/jira/browse/LENS-531
>
>
> Repository: lens
>
>
> Description
> -------
>
> added command
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 1e8d71d8ce430ad0404ec425e738d5de2529a03f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
> lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a6651f6a8f896974498d3c29a88c1c1ad0b54b49
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 5a1f8f9e4920e76a7436183776b3785d05f7869d
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/34885/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 3, 2015, 3:34 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, line 263
> > <https://reviews.apache.org/r/34885/diff/3/?file=977378#file977378line263>
> >
> > join_chains are not fields. We give flattenedColumns which returns fields from all chains along with direct fields.
> >
> > {cubename}/fields can return only direct fields.
if flattened is already there, I'm inclined towards reusing it. adding new rest end point for similar purpose doesn't make sense.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review86384
-----------------------------------------------------------
On June 3, 2015, 3:20 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 3:20 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-531
> https://issues.apache.org/jira/browse/LENS-531
>
>
> Repository: lens
>
>
> Description
> -------
>
> added command
>
>
> Diffs
> -----
>
> lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
> lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XFieldTable.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
> lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/34885/diff/
>
>
> Testing
> -------
>
> lens-shell>cube show fields sales
> dim attributes
> =======================
> Name Display String Description
> -------------------- --------------- --------------------------------------------
> delivery_city_name Delivery City City name to which the product was delivered
> production_city_name Production City City name in which the product was produced
> production_city_id
> product_id
> order_id
> delivery_city_id
> customer_city_name Customer City City name to which the customer belongs
> delivery_time
> order_time
> order_line_number
> customer_city_id
> promotion_id
> customer_id
>
> measures
> =======================
> Name Display String Description
> ------------------------- -------------------------- -----------
> rating Rating
> line_item_quantity Line item quantity
> store_sales Store Sales
> unit_sales Unit Sales
> line_item_tax Line item tax
> max_line_item_discount Maximum Line item discount
> store_cost Store Cost
> max_line_item_price Maximum Line item price
> line_item_discount_amount Line item discount
> line_item_product_price Line item product price
>
> expr columns
> =======================
> Name Display String Description Expr Specs
> --------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> profit Profit always valid: store_sales - store_cost
> promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
>
> join chains
> =======================
> Name Display String Description Destination Table Paths
> ---------------- -------------- ----------- ----------------- ---------------------------------------------------------------------------------------
> customer_details customer sales.customer_id=customer.id
> customer_city city sales.customer_city_id=city.id, sales.customer_id=customer.id->customer.city_id=city.id
> product_details product sales.product_id=product.id
> production_city city sales.production_city_id=city.id
> delivery_city city sales.delivery_city_id=city.id
>
>
> lens-shell>
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On June 3, 2015, 10:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, line 263
> > <https://reviews.apache.org/r/34885/diff/3/?file=977378#file977378line263>
> >
> > join_chains are not fields. We give flattenedColumns which returns fields from all chains along with direct fields.
> >
> > {cubename}/fields can return only direct fields.
>
> Rajat Khandelwal wrote:
> if flattened is already there, I'm inclined towards reusing it. adding new rest end point for similar purpose doesn't make sense.
>
> Rajat Khandelwal wrote:
> I'd also thought to remove the new command and add an argument `--pretty` in `describe cube` which would behave like `cube show fields` is made to behave now.
yes. I agree
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review86384
-----------------------------------------------------------
On June 3, 2015, 9:50 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 9:50 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-531
> https://issues.apache.org/jira/browse/LENS-531
>
>
> Repository: lens
>
>
> Description
> -------
>
> added command
>
>
> Diffs
> -----
>
> lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
> lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XFieldTable.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
> lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/34885/diff/
>
>
> Testing
> -------
>
> lens-shell>cube show fields sales
> dim attributes
> =======================
> Name Display String Description
> -------------------- --------------- --------------------------------------------
> delivery_city_name Delivery City City name to which the product was delivered
> production_city_name Production City City name in which the product was produced
> production_city_id
> product_id
> order_id
> delivery_city_id
> customer_city_name Customer City City name to which the customer belongs
> delivery_time
> order_time
> order_line_number
> customer_city_id
> promotion_id
> customer_id
>
> measures
> =======================
> Name Display String Description
> ------------------------- -------------------------- -----------
> rating Rating
> line_item_quantity Line item quantity
> store_sales Store Sales
> unit_sales Unit Sales
> line_item_tax Line item tax
> max_line_item_discount Maximum Line item discount
> store_cost Store Cost
> max_line_item_price Maximum Line item price
> line_item_discount_amount Line item discount
> line_item_product_price Line item product price
>
> expr columns
> =======================
> Name Display String Description Expr Specs
> --------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> profit Profit always valid: store_sales - store_cost
> promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
>
> join chains
> =======================
> Name Display String Description Destination Table Paths
> ---------------- -------------- ----------- ----------------- ---------------------------------------------------------------------------------------
> customer_details customer sales.customer_id=customer.id
> customer_city city sales.customer_city_id=city.id, sales.customer_id=customer.id->customer.city_id=city.id
> product_details product sales.product_id=product.id
> production_city city sales.production_city_id=city.id
> delivery_city city sales.delivery_city_id=city.id
>
>
> lens-shell>
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 3, 2015, 3:34 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, line 263
> > <https://reviews.apache.org/r/34885/diff/3/?file=977378#file977378line263>
> >
> > join_chains are not fields. We give flattenedColumns which returns fields from all chains along with direct fields.
> >
> > {cubename}/fields can return only direct fields.
>
> Rajat Khandelwal wrote:
> if flattened is already there, I'm inclined towards reusing it. adding new rest end point for similar purpose doesn't make sense.
I'd also thought to remove the new command and add an argument `--pretty` in `describe cube` which would behave like `cube show fields` is made to behave now.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review86384
-----------------------------------------------------------
On June 3, 2015, 3:20 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 3:20 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-531
> https://issues.apache.org/jira/browse/LENS-531
>
>
> Repository: lens
>
>
> Description
> -------
>
> added command
>
>
> Diffs
> -----
>
> lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
> lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XFieldTable.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
> lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/34885/diff/
>
>
> Testing
> -------
>
> lens-shell>cube show fields sales
> dim attributes
> =======================
> Name Display String Description
> -------------------- --------------- --------------------------------------------
> delivery_city_name Delivery City City name to which the product was delivered
> production_city_name Production City City name in which the product was produced
> production_city_id
> product_id
> order_id
> delivery_city_id
> customer_city_name Customer City City name to which the customer belongs
> delivery_time
> order_time
> order_line_number
> customer_city_id
> promotion_id
> customer_id
>
> measures
> =======================
> Name Display String Description
> ------------------------- -------------------------- -----------
> rating Rating
> line_item_quantity Line item quantity
> store_sales Store Sales
> unit_sales Unit Sales
> line_item_tax Line item tax
> max_line_item_discount Maximum Line item discount
> store_cost Store Cost
> max_line_item_price Maximum Line item price
> line_item_discount_amount Line item discount
> line_item_product_price Line item product price
>
> expr columns
> =======================
> Name Display String Description Expr Specs
> --------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> profit Profit always valid: store_sales - store_cost
> promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
>
> join chains
> =======================
> Name Display String Description Destination Table Paths
> ---------------- -------------- ----------- ----------------- ---------------------------------------------------------------------------------------
> customer_details customer sales.customer_id=customer.id
> customer_city city sales.customer_city_id=city.id, sales.customer_id=customer.id->customer.city_id=city.id
> product_details product sales.product_id=product.id
> production_city city sales.production_city_id=city.id
> delivery_city city sales.delivery_city_id=city.id
>
>
> lens-shell>
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review86384
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
<https://reviews.apache.org/r/34885/#comment138360>
join_chains are not fields. We give flattenedColumns which returns fields from all chains along with direct fields.
{cubename}/fields can return only direct fields.
- Amareshwari Sriramadasu
On June 3, 2015, 9:50 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 9:50 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-531
> https://issues.apache.org/jira/browse/LENS-531
>
>
> Repository: lens
>
>
> Description
> -------
>
> added command
>
>
> Diffs
> -----
>
> lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
> lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XFieldTable.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
> lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/34885/diff/
>
>
> Testing
> -------
>
> lens-shell>cube show fields sales
> dim attributes
> =======================
> Name Display String Description
> -------------------- --------------- --------------------------------------------
> delivery_city_name Delivery City City name to which the product was delivered
> production_city_name Production City City name in which the product was produced
> production_city_id
> product_id
> order_id
> delivery_city_id
> customer_city_name Customer City City name to which the customer belongs
> delivery_time
> order_time
> order_line_number
> customer_city_id
> promotion_id
> customer_id
>
> measures
> =======================
> Name Display String Description
> ------------------------- -------------------------- -----------
> rating Rating
> line_item_quantity Line item quantity
> store_sales Store Sales
> unit_sales Unit Sales
> line_item_tax Line item tax
> max_line_item_discount Maximum Line item discount
> store_cost Store Cost
> max_line_item_price Maximum Line item price
> line_item_discount_amount Line item discount
> line_item_product_price Line item product price
>
> expr columns
> =======================
> Name Display String Description Expr Specs
> --------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> profit Profit always valid: store_sales - store_cost
> promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
>
> join chains
> =======================
> Name Display String Description Destination Table Paths
> ---------------- -------------- ----------- ----------------- ---------------------------------------------------------------------------------------
> customer_details customer sales.customer_id=customer.id
> customer_city city sales.customer_city_id=city.id, sales.customer_id=customer.id->customer.city_id=city.id
> product_details product sales.product_id=product.id
> production_city city sales.production_city_id=city.id
> delivery_city city sales.delivery_city_id=city.id
>
>
> lens-shell>
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 10, 2015, 10:56 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java, line 78
> > <https://reviews.apache.org/r/34885/diff/6/?file=981294#file981294line78>
> >
> > Remove commented code?
I was thinking there should be a command that can show the join chains of cube/dimension to the user. Will move this code to somewhere else.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review87353
-----------------------------------------------------------
On June 11, 2015, 3:27 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 3:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-531
> https://issues.apache.org/jira/browse/LENS-531
>
>
> Repository: lens
>
>
> Description
> -------
>
> added command
>
>
> Diffs
> -----
>
> lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
> lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 208081db41b4a6bf75fb2c9bf95419b220861b00
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 84ae6c3f4369f27ba893ceb29cf7d451014045a3
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 40380b7ff5d0d4b2ec3cbe5fcc0ec56ecdafcccf
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 24992b9a58ab72c4f24321c60b6bfaf32733756e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 1eb7ed677b023f3dc8f57f789b2c5f016dfa23dc
> lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XJoinChainTable.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 208eb78a1a4857976f974b728a1ba1a362e670b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d5fd9995d7b1d74c61e27d5cb69ffc4cbff3ed4c
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 7c8261928d9c3a734f75cd915439a623438e1e77
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
> pom.xml e2cbac531a9155cd7c7db19996cafe9f61c84eeb
>
> Diff: https://reviews.apache.org/r/34885/diff/
>
>
> Testing
> -------
>
> lens-shell>show fields sales
> measures
> =============================
> Name Display String Description
> ------------------------- -------------------------- -----------
> line_item_discount_amount Line item discount
> line_item_product_price Line item product price
> line_item_quantity Line item quantity
> line_item_tax Line item tax
> max_line_item_discount Maximum Line item discount
> max_line_item_price Maximum Line item price
> rating Rating
> store_cost Store Cost
> store_sales Store Sales
> unit_sales Unit Sales
>
> dim attributes
> =============================
> Name Display String Description
> --------------------------------------- --------------- --------------------------------------------
> customer_city_id
> customer_city_name Customer City City name to which the customer belongs
> customer_id
> delivery_city_id
> delivery_city_name Delivery City City name to which the product was delivered
> delivery_time
> order_id
> order_line_number
> order_time
> product_id
> production_city_id
> production_city_name Production City City name in which the product was produced
> promotion_id
> customer_city.id
> customer_city.name
> customer_city.poi Point of interests
> customer_city.population
> delivery_city.id
> delivery_city.name
> delivery_city.poi Point of interests
> delivery_city.population
> production_city.id
> production_city.name
> production_city.poi Point of interests
> production_city.population
> customer_details.age
> customer_details.city_id
> customer_details.customer_city_name Customer City City name to which the customer belongs
> customer_details.customer_credit_status
> customer_details.gender
> customer_details.id
> customer_details.name
> product_details.category
> product_details.color
> product_details.description
> product_details.id
> product_details.manufacturer
> product_details.sku_number
> product_details.weight
>
> expr columns
> =============================
> Name Display String Description Expr Specs
> --------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
> profit Profit always valid: store_sales - store_cost
> promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
>
>
> lens-shell>show fields city
> dim attributes
> =============================
> Name Display String Description
> ---------- -------------- ------------------
> id
> name
> poi Point of interests
> population
>
>
> lens-shell>
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review87353
-----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd
<https://reviews.apache.org/r/34885/#comment139687>
I think text here was wrong earlier.
Can be comma separated should be changed to space separated.
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/34885/#comment139689>
Can we add option to show only direct fields or all flattened fields, optionally?
Because all flattened fields in some cases can be huge set. We have cubes which have 2K flattened fields.
By default , we can show direct fields and --flattened fields can give full flattened list.
What do you think?
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java
<https://reviews.apache.org/r/34885/#comment139690>
Remove commented code?
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
<https://reviews.apache.org/r/34885/#comment139691>
Should be moved to TestLensDimensionCommands?
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
<https://reviews.apache.org/r/34885/#comment139692>
API no more required?
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
<https://reviews.apache.org/r/34885/#comment139693>
API no more required?
- Amareshwari Sriramadasu
On June 9, 2015, 6:45 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 6:45 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-531
> https://issues.apache.org/jira/browse/LENS-531
>
>
> Repository: lens
>
>
> Description
> -------
>
> added command
>
>
> Diffs
> -----
>
> lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
> lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 6c4a1b5fc82a8fe4776919546d6f8c975ae0f514
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 32a89ac98230d642738e1954b965c692c7235507
> lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/34885/diff/
>
>
> Testing
> -------
>
> lens-shell>show fields sales
> measures
> =============================
> Name Display String Description
> ------------------------- -------------------------- -----------
> line_item_discount_amount Line item discount
> line_item_product_price Line item product price
> line_item_quantity Line item quantity
> line_item_tax Line item tax
> max_line_item_discount Maximum Line item discount
> max_line_item_price Maximum Line item price
> rating Rating
> store_cost Store Cost
> store_sales Store Sales
> unit_sales Unit Sales
>
> dim attributes
> =============================
> Name Display String Description
> --------------------------------------- --------------- --------------------------------------------
> customer_city_id
> customer_city_name Customer City City name to which the customer belongs
> customer_id
> delivery_city_id
> delivery_city_name Delivery City City name to which the product was delivered
> delivery_time
> order_id
> order_line_number
> order_time
> product_id
> production_city_id
> production_city_name Production City City name in which the product was produced
> promotion_id
> customer_city.id
> customer_city.name
> customer_city.poi Point of interests
> customer_city.population
> delivery_city.id
> delivery_city.name
> delivery_city.poi Point of interests
> delivery_city.population
> production_city.id
> production_city.name
> production_city.poi Point of interests
> production_city.population
> customer_details.age
> customer_details.city_id
> customer_details.customer_city_name Customer City City name to which the customer belongs
> customer_details.customer_credit_status
> customer_details.gender
> customer_details.id
> customer_details.name
> product_details.category
> product_details.color
> product_details.description
> product_details.id
> product_details.manufacturer
> product_details.sku_number
> product_details.weight
>
> expr columns
> =============================
> Name Display String Description Expr Specs
> --------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
> profit Profit always valid: store_sales - store_cost
> promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
>
>
> lens-shell>show fields city
> dim attributes
> =============================
> Name Display String Description
> ---------- -------------- ------------------
> id
> name
> poi Point of interests
> population
>
>
> lens-shell>
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review87547
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java
<https://reviews.apache.org/r/34885/#comment139924>
name showQueryableFields? - to be consistent with other methods
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java
<https://reviews.apache.org/r/34885/#comment139925>
Add test for show chains as well?
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java
<https://reviews.apache.org/r/34885/#comment139926>
Similarly test for show chains as well?
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
<https://reviews.apache.org/r/34885/#comment139929>
Error seems wrong - should say "can't get chains"?
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
<https://reviews.apache.org/r/34885/#comment139930>
Can we add default value as true? To be backward compatible with old api and result?
Can you also update javadoc for new param added?
- Amareshwari Sriramadasu
On June 11, 2015, 9:57 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 9:57 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-531
> https://issues.apache.org/jira/browse/LENS-531
>
>
> Repository: lens
>
>
> Description
> -------
>
> added command
>
>
> Diffs
> -----
>
> lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
> lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 208081db41b4a6bf75fb2c9bf95419b220861b00
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 84ae6c3f4369f27ba893ceb29cf7d451014045a3
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 40380b7ff5d0d4b2ec3cbe5fcc0ec56ecdafcccf
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 24992b9a58ab72c4f24321c60b6bfaf32733756e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 1eb7ed677b023f3dc8f57f789b2c5f016dfa23dc
> lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XJoinChainTable.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 208eb78a1a4857976f974b728a1ba1a362e670b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d5fd9995d7b1d74c61e27d5cb69ffc4cbff3ed4c
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 7c8261928d9c3a734f75cd915439a623438e1e77
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
> pom.xml e2cbac531a9155cd7c7db19996cafe9f61c84eeb
>
> Diff: https://reviews.apache.org/r/34885/diff/
>
>
> Testing
> -------
>
> lens-shell>show fields sales
> measures
> =============================
> Name Display String Description
> ------------------------- -------------------------- -----------
> line_item_discount_amount Line item discount
> line_item_product_price Line item product price
> line_item_quantity Line item quantity
> line_item_tax Line item tax
> max_line_item_discount Maximum Line item discount
> max_line_item_price Maximum Line item price
> rating Rating
> store_cost Store Cost
> store_sales Store Sales
> unit_sales Unit Sales
>
> dim attributes
> =============================
> Name Display String Description
> --------------------------------------- --------------- --------------------------------------------
> customer_city_id
> customer_city_name Customer City City name to which the customer belongs
> customer_id
> delivery_city_id
> delivery_city_name Delivery City City name to which the product was delivered
> delivery_time
> order_id
> order_line_number
> order_time
> product_id
> production_city_id
> production_city_name Production City City name in which the product was produced
> promotion_id
> customer_city.id
> customer_city.name
> customer_city.poi Point of interests
> customer_city.population
> delivery_city.id
> delivery_city.name
> delivery_city.poi Point of interests
> delivery_city.population
> production_city.id
> production_city.name
> production_city.poi Point of interests
> production_city.population
> customer_details.age
> customer_details.city_id
> customer_details.customer_city_name Customer City City name to which the customer belongs
> customer_details.customer_credit_status
> customer_details.gender
> customer_details.id
> customer_details.name
> product_details.category
> product_details.color
> product_details.description
> product_details.id
> product_details.manufacturer
> product_details.sku_number
> product_details.weight
>
> expr columns
> =============================
> Name Display String Description Expr Specs
> --------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
> profit Profit always valid: store_sales - store_cost
> promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
>
>
> lens-shell>show fields city
> dim attributes
> =============================
> Name Display String Description
> ---------- -------------- ------------------
> id
> name
> poi Point of interests
> population
>
>
> lens-shell>
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 11, 2015, 7:11 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
added command
Diffs (updated)
-----
lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 208081db41b4a6bf75fb2c9bf95419b220861b00
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 84ae6c3f4369f27ba893ceb29cf7d451014045a3
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 40380b7ff5d0d4b2ec3cbe5fcc0ec56ecdafcccf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 24992b9a58ab72c4f24321c60b6bfaf32733756e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 1eb7ed677b023f3dc8f57f789b2c5f016dfa23dc
lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XJoinChainTable.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 208eb78a1a4857976f974b728a1ba1a362e670b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d5fd9995d7b1d74c61e27d5cb69ffc4cbff3ed4c
lens-client/src/main/java/org/apache/lens/client/LensClient.java 7c8261928d9c3a734f75cd915439a623438e1e77
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml e2cbac531a9155cd7c7db19996cafe9f61c84eeb
src/site/apt/user/cli.apt a5bc056692fe01aed97949539dbc1607d22048e7
Diff: https://reviews.apache.org/r/34885/diff/
Testing (updated)
-------
lens-shell>cube show fields sales
measures
=============================
Name Display String Description
\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- -------------------------- -----------
line_item_discount_amount Line item discount
line_item_product_price Line item product price
line_item_quantity Line item quantity
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
max_line_item_price Maximum Line item price
rating Rating
store_cost Store Cost
store_sales Store Sales
unit_sales Unit Sales
dim attributes
=============================
Name Display String Description
\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- --------------- --------------------------------------------
customer_city_id
customer_city_name Customer City City name to which the customer belongs
customer_id
delivery_city_id
delivery_city_name Delivery City City name to which the product was delivered
delivery_time
order_id
order_line_number
order_time
product_id
production_city_id
production_city_name Production City City name in which the product was produced
promotion_id
expr columns
=============================
Name Display String Description Expr Specs
\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
lens-shell>cube show joinchains sales
Name Display String Description Destination Table Path
\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- -------------- ----------- ----------------- -------------------------------------------------------
customer_details customer sales.customer_id=customer.id
customer_city city sales.customer_city_id=city.id
sales.customer_id=customer.id->customer.city_id=city.id
product_details product sales.product_id=product.id
production_city city sales.production_city_id=city.id
delivery_city city sales.delivery_city_id=city.id
lens-shell>cube show fields sales --flattened
measures
=============================
Name Display String Description
\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- -------------------------- -----------
line_item_discount_amount Line item discount
line_item_product_price Line item product price
line_item_quantity Line item quantity
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
max_line_item_price Maximum Line item price
rating Rating
store_cost Store Cost
store_sales Store Sales
unit_sales Unit Sales
dim attributes
=============================
Name Display String Description
\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- --------------- --------------------------------------------
customer_city_id
customer_city_name Customer City City name to which the customer belongs
customer_id
delivery_city_id
delivery_city_name Delivery City City name to which the product was delivered
delivery_time
order_id
order_line_number
order_time
product_id
production_city_id
production_city_name Production City City name in which the product was produced
promotion_id
customer_city.id
customer_city.name
customer_city.poi Point of interests
customer_city.population
delivery_city.id
delivery_city.name
delivery_city.poi Point of interests
delivery_city.population
production_city.id
production_city.name
production_city.poi Point of interests
production_city.population
customer_details.age
customer_details.city_id
customer_details.customer_city_name Customer City City name to which the customer belongs
customer_details.customer_credit_status
customer_details.gender
customer_details.id
customer_details.name
product_details.category
product_details.color
product_details.description
product_details.id
product_details.manufacturer
product_details.sku_number
product_details.weight
expr columns
=============================
Name Display String Description Expr Specs
\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
lens-shell>dimension show fields customer
dim attributes
=============================
Name Display String Description
\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- -------------- ---------------------------------------
age
city_id
customer_city_name Customer City City name to which the customer belongs
customer_credit_status
gender
id
name
lens-shell>dimension show joinchains customer
Name Display String Description Destination Table Path
\-\-\-\-\-\-\-\-\-\-\-\-\- -------------- ----------- ----------------- ------------------------
customer_city city customer.city_id=city.id
lens-shell>dimension show fields customer --flattened
dim attributes
=============================
Name Display String Description
\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- -------------- ---------------------------------------
age
city_id
customer_city_name Customer City City name to which the customer belongs
customer_credit_status
gender
id
name
customer_city.id
customer_city.name
customer_city.poi Point of interests
customer_city.population
lens-shell>
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.741s]
[INFO] Lens .............................................. SUCCESS [3.245s]
[INFO] Lens API .......................................... SUCCESS [19.327s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.891s]
[INFO] Lens Cube ......................................... SUCCESS [3:37.195s]
[INFO] Lens DB storage ................................... SUCCESS [20.412s]
[INFO] Lens Query Library ................................ SUCCESS [16.420s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:55.124s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.585s]
[INFO] Lens Server ....................................... SUCCESS [5:42.352s]
[INFO] Lens client ....................................... SUCCESS [37.761s]
[INFO] Lens CLI .......................................... SUCCESS [3:36.178s]
[INFO] Lens Examples ..................................... SUCCESS [9.356s]
[INFO] Lens Distribution ................................. SUCCESS [8.363s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.033s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.791s]
[INFO] Lens Regression ................................... SUCCESS [12.316s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:21.037s
[INFO] Finished at: Thu Jun 11 13:34:33 UTC 2015
[INFO] Final Memory: 171M/1462M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review87554
-----------------------------------------------------------
Ship it!
Changes look fine.
Update CLI doc and ship.
- Amareshwari Sriramadasu
On June 11, 2015, 11:26 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 11:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-531
> https://issues.apache.org/jira/browse/LENS-531
>
>
> Repository: lens
>
>
> Description
> -------
>
> added command
>
>
> Diffs
> -----
>
> lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
> lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 208081db41b4a6bf75fb2c9bf95419b220861b00
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 84ae6c3f4369f27ba893ceb29cf7d451014045a3
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 40380b7ff5d0d4b2ec3cbe5fcc0ec56ecdafcccf
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 24992b9a58ab72c4f24321c60b6bfaf32733756e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 1eb7ed677b023f3dc8f57f789b2c5f016dfa23dc
> lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/table/XJoinChainTable.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 208eb78a1a4857976f974b728a1ba1a362e670b0
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d5fd9995d7b1d74c61e27d5cb69ffc4cbff3ed4c
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 7c8261928d9c3a734f75cd915439a623438e1e77
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
> pom.xml e2cbac531a9155cd7c7db19996cafe9f61c84eeb
>
> Diff: https://reviews.apache.org/r/34885/diff/
>
>
> Testing
> -------
>
> lens-shell>cube show fields sales
> measures
> =============================
> Name Display String Description
> ------------------------- -------------------------- -----------
> line_item_discount_amount Line item discount
> line_item_product_price Line item product price
> line_item_quantity Line item quantity
> line_item_tax Line item tax
> max_line_item_discount Maximum Line item discount
> max_line_item_price Maximum Line item price
> rating Rating
> store_cost Store Cost
> store_sales Store Sales
> unit_sales Unit Sales
>
> dim attributes
> =============================
> Name Display String Description
> -------------------- --------------- --------------------------------------------
> customer_city_id
> customer_city_name Customer City City name to which the customer belongs
> customer_id
> delivery_city_id
> delivery_city_name Delivery City City name to which the product was delivered
> delivery_time
> order_id
> order_line_number
> order_time
> product_id
> production_city_id
> production_city_name Production City City name in which the product was produced
> promotion_id
>
> expr columns
> =============================
> Name Display String Description Expr Specs
> --------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> profit Profit always valid: store_sales - store_cost
> promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
>
>
> lens-shell>cube show joinchains sales
> Name Display String Description Destination Table Path
> ---------------- -------------- ----------- ----------------- -------------------------------------------------------
> customer_details customer sales.customer_id=customer.id
> customer_city city sales.customer_city_id=city.id
> sales.customer_id=customer.id->customer.city_id=city.id
> product_details product sales.product_id=product.id
> production_city city sales.production_city_id=city.id
> delivery_city city sales.delivery_city_id=city.id
>
> lens-shell>cube show fields sales --flattened
> measures
> =============================
> Name Display String Description
> ------------------------- -------------------------- -----------
> line_item_discount_amount Line item discount
> line_item_product_price Line item product price
> line_item_quantity Line item quantity
> line_item_tax Line item tax
> max_line_item_discount Maximum Line item discount
> max_line_item_price Maximum Line item price
> rating Rating
> store_cost Store Cost
> store_sales Store Sales
> unit_sales Unit Sales
>
> dim attributes
> =============================
> Name Display String Description
> --------------------------------------- --------------- --------------------------------------------
> customer_city_id
> customer_city_name Customer City City name to which the customer belongs
> customer_id
> delivery_city_id
> delivery_city_name Delivery City City name to which the product was delivered
> delivery_time
> order_id
> order_line_number
> order_time
> product_id
> production_city_id
> production_city_name Production City City name in which the product was produced
> promotion_id
> customer_city.id
> customer_city.name
> customer_city.poi Point of interests
> customer_city.population
> delivery_city.id
> delivery_city.name
> delivery_city.poi Point of interests
> delivery_city.population
> production_city.id
> production_city.name
> production_city.poi Point of interests
> production_city.population
> customer_details.age
> customer_details.city_id
> customer_details.customer_city_name Customer City City name to which the customer belongs
> customer_details.customer_credit_status
> customer_details.gender
> customer_details.id
> customer_details.name
> product_details.category
> product_details.color
> product_details.description
> product_details.id
> product_details.manufacturer
> product_details.sku_number
> product_details.weight
>
> expr columns
> =============================
> Name Display String Description Expr Specs
> --------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
> profit Profit always valid: store_sales - store_cost
> promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
>
>
> lens-shell>dimension show fields customer
> dim attributes
> =============================
> Name Display String Description
> ---------------------- -------------- ---------------------------------------
> age
> city_id
> customer_city_name Customer City City name to which the customer belongs
> customer_credit_status
> gender
> id
> name
>
>
> lens-shell>dimension show joinchains customer
> Name Display String Description Destination Table Path
> ------------- -------------- ----------- ----------------- ------------------------
> customer_city city customer.city_id=city.id
>
> lens-shell>dimension show fields customer --flattened
> dim attributes
> =============================
> Name Display String Description
> ------------------------ -------------- ---------------------------------------
> age
> city_id
> customer_city_name Customer City City name to which the customer belongs
> customer_credit_status
> gender
> id
> name
> customer_city.id
> customer_city.name
> customer_city.poi Point of interests
> customer_city.population
>
>
> lens-shell>
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 11, 2015, 4:56 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
added command
Diffs (updated)
-----
lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 208081db41b4a6bf75fb2c9bf95419b220861b00
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 84ae6c3f4369f27ba893ceb29cf7d451014045a3
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 40380b7ff5d0d4b2ec3cbe5fcc0ec56ecdafcccf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 24992b9a58ab72c4f24321c60b6bfaf32733756e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 1eb7ed677b023f3dc8f57f789b2c5f016dfa23dc
lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XJoinChainTable.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 208eb78a1a4857976f974b728a1ba1a362e670b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d5fd9995d7b1d74c61e27d5cb69ffc4cbff3ed4c
lens-client/src/main/java/org/apache/lens/client/LensClient.java 7c8261928d9c3a734f75cd915439a623438e1e77
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml e2cbac531a9155cd7c7db19996cafe9f61c84eeb
Diff: https://reviews.apache.org/r/34885/diff/
Testing (updated)
-------
lens-shell>cube show fields sales
measures
=============================
Name Display String Description
------------------------- -------------------------- -----------
line_item_discount_amount Line item discount
line_item_product_price Line item product price
line_item_quantity Line item quantity
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
max_line_item_price Maximum Line item price
rating Rating
store_cost Store Cost
store_sales Store Sales
unit_sales Unit Sales
dim attributes
=============================
Name Display String Description
-------------------- --------------- --------------------------------------------
customer_city_id
customer_city_name Customer City City name to which the customer belongs
customer_id
delivery_city_id
delivery_city_name Delivery City City name to which the product was delivered
delivery_time
order_id
order_line_number
order_time
product_id
production_city_id
production_city_name Production City City name in which the product was produced
promotion_id
expr columns
=============================
Name Display String Description Expr Specs
--------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
lens-shell>cube show joinchains sales
Name Display String Description Destination Table Path
---------------- -------------- ----------- ----------------- -------------------------------------------------------
customer_details customer sales.customer_id=customer.id
customer_city city sales.customer_city_id=city.id
sales.customer_id=customer.id->customer.city_id=city.id
product_details product sales.product_id=product.id
production_city city sales.production_city_id=city.id
delivery_city city sales.delivery_city_id=city.id
lens-shell>cube show fields sales --flattened
measures
=============================
Name Display String Description
------------------------- -------------------------- -----------
line_item_discount_amount Line item discount
line_item_product_price Line item product price
line_item_quantity Line item quantity
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
max_line_item_price Maximum Line item price
rating Rating
store_cost Store Cost
store_sales Store Sales
unit_sales Unit Sales
dim attributes
=============================
Name Display String Description
--------------------------------------- --------------- --------------------------------------------
customer_city_id
customer_city_name Customer City City name to which the customer belongs
customer_id
delivery_city_id
delivery_city_name Delivery City City name to which the product was delivered
delivery_time
order_id
order_line_number
order_time
product_id
production_city_id
production_city_name Production City City name in which the product was produced
promotion_id
customer_city.id
customer_city.name
customer_city.poi Point of interests
customer_city.population
delivery_city.id
delivery_city.name
delivery_city.poi Point of interests
delivery_city.population
production_city.id
production_city.name
production_city.poi Point of interests
production_city.population
customer_details.age
customer_details.city_id
customer_details.customer_city_name Customer City City name to which the customer belongs
customer_details.customer_credit_status
customer_details.gender
customer_details.id
customer_details.name
product_details.category
product_details.color
product_details.description
product_details.id
product_details.manufacturer
product_details.sku_number
product_details.weight
expr columns
=============================
Name Display String Description Expr Specs
--------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
lens-shell>dimension show fields customer
dim attributes
=============================
Name Display String Description
---------------------- -------------- ---------------------------------------
age
city_id
customer_city_name Customer City City name to which the customer belongs
customer_credit_status
gender
id
name
lens-shell>dimension show joinchains customer
Name Display String Description Destination Table Path
------------- -------------- ----------- ----------------- ------------------------
customer_city city customer.city_id=city.id
lens-shell>dimension show fields customer --flattened
dim attributes
=============================
Name Display String Description
------------------------ -------------- ---------------------------------------
age
city_id
customer_city_name Customer City City name to which the customer belongs
customer_credit_status
gender
id
name
customer_city.id
customer_city.name
customer_city.poi Point of interests
customer_city.population
lens-shell>
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 11, 2015, 4:47 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
added command
Diffs (updated)
-----
lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 208081db41b4a6bf75fb2c9bf95419b220861b00
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 84ae6c3f4369f27ba893ceb29cf7d451014045a3
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 40380b7ff5d0d4b2ec3cbe5fcc0ec56ecdafcccf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 24992b9a58ab72c4f24321c60b6bfaf32733756e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 1eb7ed677b023f3dc8f57f789b2c5f016dfa23dc
lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XJoinChainTable.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 208eb78a1a4857976f974b728a1ba1a362e670b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d5fd9995d7b1d74c61e27d5cb69ffc4cbff3ed4c
lens-client/src/main/java/org/apache/lens/client/LensClient.java 7c8261928d9c3a734f75cd915439a623438e1e77
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml e2cbac531a9155cd7c7db19996cafe9f61c84eeb
Diff: https://reviews.apache.org/r/34885/diff/
Testing
-------
lens-shell>show fields sales
measures
=============================
Name Display String Description
------------------------- -------------------------- -----------
line_item_discount_amount Line item discount
line_item_product_price Line item product price
line_item_quantity Line item quantity
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
max_line_item_price Maximum Line item price
rating Rating
store_cost Store Cost
store_sales Store Sales
unit_sales Unit Sales
dim attributes
=============================
Name Display String Description
--------------------------------------- --------------- --------------------------------------------
customer_city_id
customer_city_name Customer City City name to which the customer belongs
customer_id
delivery_city_id
delivery_city_name Delivery City City name to which the product was delivered
delivery_time
order_id
order_line_number
order_time
product_id
production_city_id
production_city_name Production City City name in which the product was produced
promotion_id
customer_city.id
customer_city.name
customer_city.poi Point of interests
customer_city.population
delivery_city.id
delivery_city.name
delivery_city.poi Point of interests
delivery_city.population
production_city.id
production_city.name
production_city.poi Point of interests
production_city.population
customer_details.age
customer_details.city_id
customer_details.customer_city_name Customer City City name to which the customer belongs
customer_details.customer_credit_status
customer_details.gender
customer_details.id
customer_details.name
product_details.category
product_details.color
product_details.description
product_details.id
product_details.manufacturer
product_details.sku_number
product_details.weight
expr columns
=============================
Name Display String Description Expr Specs
--------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
lens-shell>show fields city
dim attributes
=============================
Name Display String Description
---------- -------------- ------------------
id
name
poi Point of interests
population
lens-shell>
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 11, 2015, 3:27 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
added command
Diffs (updated)
-----
lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java 208081db41b4a6bf75fb2c9bf95419b220861b00
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 84ae6c3f4369f27ba893ceb29cf7d451014045a3
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 40380b7ff5d0d4b2ec3cbe5fcc0ec56ecdafcccf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 24992b9a58ab72c4f24321c60b6bfaf32733756e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 1eb7ed677b023f3dc8f57f789b2c5f016dfa23dc
lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XJoinChainTable.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 208eb78a1a4857976f974b728a1ba1a362e670b0
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java d5fd9995d7b1d74c61e27d5cb69ffc4cbff3ed4c
lens-client/src/main/java/org/apache/lens/client/LensClient.java 7c8261928d9c3a734f75cd915439a623438e1e77
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml e2cbac531a9155cd7c7db19996cafe9f61c84eeb
Diff: https://reviews.apache.org/r/34885/diff/
Testing
-------
lens-shell>show fields sales
measures
=============================
Name Display String Description
------------------------- -------------------------- -----------
line_item_discount_amount Line item discount
line_item_product_price Line item product price
line_item_quantity Line item quantity
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
max_line_item_price Maximum Line item price
rating Rating
store_cost Store Cost
store_sales Store Sales
unit_sales Unit Sales
dim attributes
=============================
Name Display String Description
--------------------------------------- --------------- --------------------------------------------
customer_city_id
customer_city_name Customer City City name to which the customer belongs
customer_id
delivery_city_id
delivery_city_name Delivery City City name to which the product was delivered
delivery_time
order_id
order_line_number
order_time
product_id
production_city_id
production_city_name Production City City name in which the product was produced
promotion_id
customer_city.id
customer_city.name
customer_city.poi Point of interests
customer_city.population
delivery_city.id
delivery_city.name
delivery_city.poi Point of interests
delivery_city.population
production_city.id
production_city.name
production_city.poi Point of interests
production_city.population
customer_details.age
customer_details.city_id
customer_details.customer_city_name Customer City City name to which the customer belongs
customer_details.customer_credit_status
customer_details.gender
customer_details.id
customer_details.name
product_details.category
product_details.color
product_details.description
product_details.id
product_details.manufacturer
product_details.sku_number
product_details.weight
expr columns
=============================
Name Display String Description Expr Specs
--------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
lens-shell>show fields city
dim attributes
=============================
Name Display String Description
---------- -------------- ------------------
id
name
poi Point of interests
population
lens-shell>
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 9, 2015, 12:15 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
added command
Diffs (updated)
-----
lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 6c4a1b5fc82a8fe4776919546d6f8c975ae0f514
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 32a89ac98230d642738e1954b965c692c7235507
lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
Diff: https://reviews.apache.org/r/34885/diff/
Testing
-------
lens-shell>show fields sales
measures
=============================
Name Display String Description
------------------------- -------------------------- -----------
line_item_discount_amount Line item discount
line_item_product_price Line item product price
line_item_quantity Line item quantity
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
max_line_item_price Maximum Line item price
rating Rating
store_cost Store Cost
store_sales Store Sales
unit_sales Unit Sales
dim attributes
=============================
Name Display String Description
--------------------------------------- --------------- --------------------------------------------
customer_city_id
customer_city_name Customer City City name to which the customer belongs
customer_id
delivery_city_id
delivery_city_name Delivery City City name to which the product was delivered
delivery_time
order_id
order_line_number
order_time
product_id
production_city_id
production_city_name Production City City name in which the product was produced
promotion_id
customer_city.id
customer_city.name
customer_city.poi Point of interests
customer_city.population
delivery_city.id
delivery_city.name
delivery_city.poi Point of interests
delivery_city.population
production_city.id
production_city.name
production_city.poi Point of interests
production_city.population
customer_details.age
customer_details.city_id
customer_details.customer_city_name Customer City City name to which the customer belongs
customer_details.customer_credit_status
customer_details.gender
customer_details.id
customer_details.name
product_details.category
product_details.color
product_details.description
product_details.id
product_details.manufacturer
product_details.sku_number
product_details.weight
expr columns
=============================
Name Display String Description Expr Specs
--------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
lens-shell>show fields city
dim attributes
=============================
Name Display String Description
---------- -------------- ------------------
id
name
poi Point of interests
population
lens-shell>
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 4, 2015, 5:24 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
added command
Diffs
-----
lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 6c4a1b5fc82a8fe4776919546d6f8c975ae0f514
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 32a89ac98230d642738e1954b965c692c7235507
lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
Diff: https://reviews.apache.org/r/34885/diff/
Testing (updated)
-------
lens-shell>show fields sales
measures
=============================
Name Display String Description
------------------------- -------------------------- -----------
line_item_discount_amount Line item discount
line_item_product_price Line item product price
line_item_quantity Line item quantity
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
max_line_item_price Maximum Line item price
rating Rating
store_cost Store Cost
store_sales Store Sales
unit_sales Unit Sales
dim attributes
=============================
Name Display String Description
--------------------------------------- --------------- --------------------------------------------
customer_city_id
customer_city_name Customer City City name to which the customer belongs
customer_id
delivery_city_id
delivery_city_name Delivery City City name to which the product was delivered
delivery_time
order_id
order_line_number
order_time
product_id
production_city_id
production_city_name Production City City name in which the product was produced
promotion_id
customer_city.id
customer_city.name
customer_city.poi Point of interests
customer_city.population
delivery_city.id
delivery_city.name
delivery_city.poi Point of interests
delivery_city.population
production_city.id
production_city.name
production_city.poi Point of interests
production_city.population
customer_details.age
customer_details.city_id
customer_details.customer_city_name Customer City City name to which the customer belongs
customer_details.customer_credit_status
customer_details.gender
customer_details.id
customer_details.name
product_details.category
product_details.color
product_details.description
product_details.id
product_details.manufacturer
product_details.sku_number
product_details.weight
expr columns
=============================
Name Display String Description Expr Specs
--------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
lens-shell>show fields city
dim attributes
=============================
Name Display String Description
---------- -------------- ------------------
id
name
poi Point of interests
population
lens-shell>
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 4, 2015, 5:23 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
added command
Diffs (updated)
-----
lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 6c4a1b5fc82a8fe4776919546d6f8c975ae0f514
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 32a89ac98230d642738e1954b965c692c7235507
lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
Diff: https://reviews.apache.org/r/34885/diff/
Testing
-------
lens-shell>show fields sales
measures
=============================
Name Display String Description
------------------------- -------------------------- -----------
rating Rating
line_item_quantity Line item quantity
store_sales Store Sales
unit_sales Unit Sales
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
store_cost Store Cost
max_line_item_price Maximum Line item price
line_item_discount_amount Line item discount
line_item_product_price Line item product price
dim attributes
=============================
Name Display String Description
---------------------- --------------- --------------------------------------------
delivery_city_name Delivery City City name to which the product was delivered
production_city_name Production City City name in which the product was produced
production_city_id
product_id
order_id
delivery_city_id
customer_city_name Customer City City name to which the customer belongs
delivery_time
order_time
order_line_number
customer_city_id
promotion_id
customer_id
city_id
id
gender
customer_credit_status
customer_city_name Customer City City name to which the customer belongs
name
age
id
poi Point of interests
name
population
category
color
weight
description
id
sku_number
manufacturer
id
poi Point of interests
name
population
id
poi Point of interests
name
population
expr columns
=============================
Name Display String Description Expr Specs
--------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
lens-shell>show fields city
dim attributes
=============================
Name Display String Description
---------- -------------- ------------------
id
poi Point of interests
name
population
lens-shell>
name
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 3, 2015, 8:12 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
added command
Diffs (updated)
-----
lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 6c4a1b5fc82a8fe4776919546d6f8c975ae0f514
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 32a89ac98230d642738e1954b965c692c7235507
lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
Diff: https://reviews.apache.org/r/34885/diff/
Testing (updated)
-------
lens-shell>show fields sales
measures
=============================
Name Display String Description
------------------------- -------------------------- -----------
rating Rating
line_item_quantity Line item quantity
store_sales Store Sales
unit_sales Unit Sales
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
store_cost Store Cost
max_line_item_price Maximum Line item price
line_item_discount_amount Line item discount
line_item_product_price Line item product price
dim attributes
=============================
Name Display String Description
---------------------- --------------- --------------------------------------------
delivery_city_name Delivery City City name to which the product was delivered
production_city_name Production City City name in which the product was produced
production_city_id
product_id
order_id
delivery_city_id
customer_city_name Customer City City name to which the customer belongs
delivery_time
order_time
order_line_number
customer_city_id
promotion_id
customer_id
city_id
id
gender
customer_credit_status
customer_city_name Customer City City name to which the customer belongs
name
age
id
poi Point of interests
name
population
category
color
weight
description
id
sku_number
manufacturer
id
poi Point of interests
name
population
id
poi Point of interests
name
population
expr columns
=============================
Name Display String Description Expr Specs
--------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
isheavy before 2015-04-11T23:30:00.000+05:30: weight > 10, after 2015-04-11T23:30:00.000+05:30: weight > 50
lens-shell>show fields city
dim attributes
=============================
Name Display String Description
---------- -------------- ------------------
id
poi Point of interests
name
population
lens-shell>
name
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 3, 2015, 3:20 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description
-------
added command
Diffs (updated)
-----
lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2
lens-api/src/main/resources/cube-0.1.xsd 719d10d94f638718d25c0b91f00abea75414ddf5
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/table/XFieldTable.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java ae39a2abe01d175c927fa2dcb80836c628e5c3ab
lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 44f4f1f49894f235568aabc3de128879a233b35c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
Diff: https://reviews.apache.org/r/34885/diff/
Testing (updated)
-------
lens-shell>cube show fields sales
dim attributes
=======================
Name Display String Description
-------------------- --------------- --------------------------------------------
delivery_city_name Delivery City City name to which the product was delivered
production_city_name Production City City name in which the product was produced
production_city_id
product_id
order_id
delivery_city_id
customer_city_name Customer City City name to which the customer belongs
delivery_time
order_time
order_line_number
customer_city_id
promotion_id
customer_id
measures
=======================
Name Display String Description
------------------------- -------------------------- -----------
rating Rating
line_item_quantity Line item quantity
store_sales Store Sales
unit_sales Unit Sales
line_item_tax Line item tax
max_line_item_discount Maximum Line item discount
store_cost Store Cost
max_line_item_price Maximum Line item price
line_item_discount_amount Line item discount
line_item_product_price Line item product price
expr columns
=======================
Name Display String Description Expr Specs
--------------- --------------- ----------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
profit Profit always valid: store_sales - store_cost
promotion_sales Promotion sales after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
join chains
=======================
Name Display String Description Destination Table Paths
---------------- -------------- ----------- ----------------- ---------------------------------------------------------------------------------------
customer_details customer sales.customer_id=customer.id
customer_city city sales.customer_city_id=city.id, sales.customer_id=customer.id->customer.city_id=city.id
product_details product sales.product_id=product.id
production_city city sales.production_city_id=city.id
delivery_city city sales.delivery_city_id=city.id
lens-shell>
Thanks,
Rajat Khandelwal
Re: Review Request 34885: LENS-531: Add cli command to show all
queryable fields with description for a cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/
-----------------------------------------------------------
(Updated June 1, 2015, 3:09 p.m.)
Review request for lens.
Bugs: LENS-531
https://issues.apache.org/jira/browse/LENS-531
Repository: lens
Description (updated)
-------
added command
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 1e8d71d8ce430ad0404ec425e738d5de2529a03f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java d05d7a516d2c65b081464e84858a593ab8f0e1bf
lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 86099d3b65ef03be62825e1abcdf8ce88f2a1f60
lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java b599d6ed469354596e972ffafe75716eb5239378
lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java e5524bda29c55e7bb17ab081f8170716a297af18
lens-client/src/main/java/org/apache/lens/client/LensClient.java cd8bf166e11786ae8ec26df8d03dd381ef62d787
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a6651f6a8f896974498d3c29a88c1c1ad0b54b49
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 5a1f8f9e4920e76a7436183776b3785d05f7869d
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 890da4cbd365a6b01381a110f9888a5491b49727
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 64f6cd4bddeadfccc8ab992fcdf16151a29d3c24
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e746ebbe5035fcc43563a5509f1dbf67d51980db
pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
Diff: https://reviews.apache.org/r/34885/diff/
Testing
-------
Thanks,
Rajat Khandelwal