You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/16 18:45:04 UTC

[GitHub] [arrow] rdettai edited a comment on pull request #8917: ARROW-9828: [Rust] [DataFusion] Support filter pushdown optimisation for TableProvider implementations

rdettai edited a comment on pull request #8917:
URL: https://github.com/apache/arrow/pull/8917#issuecomment-746426491


   I am very happy with the general heading of this PR. Thanks for your great work @returnString 😄 . 
   
   I can't shake the feeling that we are adding too much complexity to the `TableProvider` enum (1 extra method + 1 signature change + extra enum type). Are we really sure that we couldn't achieve the same with less? (cf [comment](https://github.com/apache/arrow/pull/8917/files#r544351700) and [comment](https://github.com/apache/arrow/pull/8917#discussion_r544337093))


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org