You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Abhishek Rawat (Code Review)" <ge...@cloudera.org> on 2023/08/24 21:22:45 UTC
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20419
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
IMPALA-12400: Test expected executors used for
planning when no executor groups are healthy
Added a custom cluster test for testing number of executors used for
planning when no executor groups are healthy. Planner should use
num executors from 'num_expected_executors' or
'expected_executor_group_sets' when executor groups aren't healthy.
Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
---
M tests/custom_cluster/test_executor_groups.py
1 file changed, 69 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/20419/1
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9663/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 15:19:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13896/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 15:46:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Added a custom cluster test for testing number of executors used for
planning when no executor groups are healthy. Planner should use
num executors from 'num_expected_executors' or
'expected_executor_group_sets' when executor groups aren't healthy.
Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
---
M tests/custom_cluster/test_executor_groups.py
1 file changed, 69 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/20419/2
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13835/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Aug 2023 21:48:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Sep 2023 00:07:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
LGTM
http://gerrit.cloudera.org:8080/#/c/20419/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20419/1//COMMIT_MSG@8
PS1, Line 8: planning when no executor groups are healthy
Nit: put on one line?
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Aug 2023 01:04:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 19:50:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 15:19:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Added a custom cluster test for testing number of executors used for
planning when no executor groups are healthy. Planner should use
num executors from 'num_expected_executors' or
'expected_executor_group_sets' when executor groups aren't healthy.
Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Reviewed-on: http://gerrit.cloudera.org:8080/20419
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_executor_groups.py
1 file changed, 69 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9665/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 19:50:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20419/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20419/1//COMMIT_MSG@8
PS1, Line 8: planning when no executor groups are healthy
> Nit: put on one line?
Done
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 15:17:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 15:17:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 )
Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9663/
--
To view, visit http://gerrit.cloudera.org:8080/20419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ca0a5402c74d07ee875878f092d6d3827c6b7
Gerrit-Change-Number: 20419
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 19:34:31 +0000
Gerrit-HasComments: No