You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/03/22 21:38:41 UTC
[GitHub] [lucene] dweiss opened a new pull request #33: LUCENE-9861: pull tuned vm options into a separate aspect.
dweiss opened a new pull request #33:
URL: https://github.com/apache/lucene/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on a change in pull request #33: LUCENE-9861: pull tuned vm options into a separate aspect.
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599375420
##########
File path: gradle/validation/ecj-lint.gradle
##########
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties", file("${resources}/ecj.javadocs.prefs").absolutePath ]
- // disable for now because individual file excludes cannot be applied to ecj.
Review comment:
In addition, it's automatically activated for all JavaExec tasks, no need to handle it in all custom tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #33: LUCENE-9861: pull tuned vm options into a separate aspect.
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #33:
URL: https://github.com/apache/lucene/pull/33#issuecomment-804436499
I compared times with another PR (just looking at the github check times), and it shaved a few minutes off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss merged pull request #33: LUCENE-9861: pull tuned vm options into a separate aspect.
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #33:
URL: https://github.com/apache/lucene/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on a change in pull request #33: LUCENE-9861: pull tuned vm options into a separate aspect.
Posted by GitBox <gi...@apache.org>.
rmuir commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599114563
##########
File path: gradle/validation/ecj-lint.gradle
##########
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties", file("${resources}/ecj.javadocs.prefs").absolutePath ]
- // disable for now because individual file excludes cannot be applied to ecj.
Review comment:
nm, i see, it must be a "JavaExec" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a change in pull request #33: LUCENE-9861: pull tuned vm options into a separate aspect.
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599370747
##########
File path: gradle/validation/ecj-lint.gradle
##########
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties", file("${resources}/ecj.javadocs.prefs").absolutePath ]
- // disable for now because individual file excludes cannot be applied to ecj.
Review comment:
These vm options are applied to all ecjLint* tasks - I just moved the application to that separate file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on a change in pull request #33: LUCENE-9861: pull tuned vm options into a separate aspect.
Posted by GitBox <gi...@apache.org>.
rmuir commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599114199
##########
File path: gradle/validation/ecj-lint.gradle
##########
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties", file("${resources}/ecj.javadocs.prefs").absolutePath ]
- // disable for now because individual file excludes cannot be applied to ecj.
Review comment:
can we apply the options here as well, like the patch on the JIRA? It was a large win for ecjlint for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on a change in pull request #33: LUCENE-9861: pull tuned vm options into a separate aspect.
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599162761
##########
File path: gradle/validation/ecj-lint.gradle
##########
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties", file("${resources}/ecj.javadocs.prefs").absolutePath ]
- // disable for now because individual file excludes cannot be applied to ecj.
Review comment:
It is. That's the trick here. 😜
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org