You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/18 10:19:41 UTC
[GitHub] [camel-website] shreyaag770 opened a new pull request #237:
Frontpage/projects
shreyaag770 opened a new pull request #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237
Rearranged the alignment under Project Section on Frontpage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#237: Frontpage/projects
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#discussion_r397016100
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -156,8 +160,12 @@ section.frontpage.projects .project {
section.frontpage.projects .project h1 {
white-space: nowrap;
- padding: 1rem 0;
- flex: 1;
+ padding: 1rem ;
Review comment:
Trailing whitespace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] oscerd commented on issue #237: Frontpage/projects
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#issuecomment-601584333
I don't know, if this is a minor change I think you can go ahead without an issue number, when the updates are much bigger we need an issue for them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #237:
Frontpage/projects
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#issuecomment-601644841
Thanks, @oscerd and Do you think changes I suggest in this PR are relevant? or else I can look for an issue in JIRA.
Changes I made :
Before:
After:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #237:
Frontpage/projects
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#issuecomment-603177095
@zregvart I don't why but I am not able to push changes in this PR. I have to make another PR #264. All the changes you asked for are made in that PR. I am really sorry for all this trouble.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#237: Frontpage/projects
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#discussion_r397016614
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -245,6 +253,10 @@ section.frontpage h1 {
min-width: 51vw;
}
+ section.frontpage.projects .project h1{
Review comment:
Insert space after h1 and before the bracket
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#237: Frontpage/projects
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#discussion_r397014919
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -50,24 +50,28 @@ header.frontpage a:active {
.frontpage a.significant {
margin: 1rem;
- padding: 0.8rem 1.5rem;
- background: var(--color-camel-orange);
- color: var(--color-white);
+ padding: .8rem 1.5rem;
+ background: #ed8225;
+ color: #fff;
Review comment:
We need to use the variables here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #237:
Frontpage/projects
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#issuecomment-601583692
Alright! @oscerd I just thought this was a necessary change since @zregvart told us we can do minor changes other than issues listed. What should I do to this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #237: Frontpage/projects
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#issuecomment-604336336
No problem, lets close this in favour of #264 and continue the discussion there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#237: Frontpage/projects
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#discussion_r397015565
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -50,24 +50,28 @@ header.frontpage a:active {
.frontpage a.significant {
margin: 1rem;
- padding: 0.8rem 1.5rem;
- background: var(--color-camel-orange);
- color: var(--color-white);
+ padding: .8rem 1.5rem;
+ background: #ed8225;
+ color: #fff;
border-radius: 8px;
font-size: 1.2rem;
- font-weight: bold;
+ font-weight: 700;
outline: none;
display: inline-block;
white-space: nowrap;
+ box-shadow: 0 4px #8e480b;
Review comment:
Buttons are designed without shadows, rebase and have a look at the current master or live website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on a change in pull request
#237: Frontpage/projects
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on a change in pull request #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#discussion_r397049129
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -50,24 +50,28 @@ header.frontpage a:active {
.frontpage a.significant {
margin: 1rem;
- padding: 0.8rem 1.5rem;
- background: var(--color-camel-orange);
- color: var(--color-white);
+ padding: .8rem 1.5rem;
+ background: #ed8225;
+ color: #fff;
border-radius: 8px;
font-size: 1.2rem;
- font-weight: bold;
+ font-weight: 700;
outline: none;
display: inline-block;
white-space: nowrap;
+ box-shadow: 0 4px #8e480b;
Review comment:
I have pulled the fresh code now and checked the current website, there have been updates, current buttons have a shadow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#237: Frontpage/projects
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#discussion_r397015147
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -50,24 +50,28 @@ header.frontpage a:active {
.frontpage a.significant {
margin: 1rem;
- padding: 0.8rem 1.5rem;
- background: var(--color-camel-orange);
- color: var(--color-white);
+ padding: .8rem 1.5rem;
+ background: #ed8225;
+ color: #fff;
border-radius: 8px;
font-size: 1.2rem;
- font-weight: bold;
+ font-weight: 700;
Review comment:
Use weight names or variables instead of numbers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#237: Frontpage/projects
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237#discussion_r397016348
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -156,8 +160,12 @@ section.frontpage.projects .project {
section.frontpage.projects .project h1 {
white-space: nowrap;
- padding: 1rem 0;
- flex: 1;
+ padding: 1rem ;
+ -webkit-box-flex: 1;
+ -ms-flex: 1;
Review comment:
There is no reason to use browser prefixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart closed pull request #237:
Frontpage/projects
Posted by GitBox <gi...@apache.org>.
zregvart closed pull request #237: Frontpage/projects
URL: https://github.com/apache/camel-website/pull/237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services