You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/06 19:39:02 UTC
[GitHub] [incubator-nuttx] jturnsek opened a new pull request #3462: MIMXRT1064-EVK support
jturnsek opened a new pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462
## Summary
Board support for the MIMXRT1064-EVK development board.
## Impact
New board support.
## Testing
nsh build configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#discussion_r608362699
##########
File path: boards/arm/imxrt/imxrt1064-evk/src/imxrt_userleds.c
##########
@@ -0,0 +1,100 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1064-evk/src/imxrt_userleds.c
+ *
+ * Copyright (C) 2018 Gregory Nutt. All rights reserved.
+ * Authors: Gregory Nutt <gn...@nuttx.org>
+ * David Sidrane <da...@nscdg.com>
Review comment:
@jturnsek change ALL copyright from Greg and David to apache since they already sign SGA or ICLA. You can reference the original code to know which files can convert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-819017453
hmm that may be tomorrow :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 merged pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-818831383
@jturnsek - I do not think moving it to RAM is correct. Moving it around in the FLASH may resolve it.
It will be a while before I can get to this. In the short term we can always black list that config in CI and document it as not building in the README.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jturnsek commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
jturnsek commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-862060825
@CFD2 : It should not be a problem, except flash size shall be changed from 8192 to 4096. Better still, config option shall be used instead of fixed value (something to be done to improve things).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jturnsek commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
jturnsek commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-818846678
@davids5 It is actually relocating from flash to sram at init as it is .text. Doing it like this is solving the linking problem with nshocram configuration. I am getting the successful build actually. But the CI is still failling and I can not find out a reason from the build log. Am I missing something? Maybe you can look into logs to see what is going on there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-818278911
@jturnsek - any luck on the build error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-818957703
@jturnsek OK good - I will take a look once it finishes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#discussion_r608686238
##########
File path: boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
##########
@@ -0,0 +1,213 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdint.h>
+#include <stdbool.h>
+#include <errno.h>
+#include <debug.h>
+
+#include <nuttx/spi/spi.h>
+#include <arch/board/board.h>
+
+#include "arm_arch.h"
+
+#include "imxrt_config.h"
+#include "imxrt_lpspi.h"
+#include "imxrt_gpio.h"
+#include "imxrt1064-evk.h"
+
+#if defined(CONFIG_IMXRT_LPSPI1) || defined(CONFIG_IMXRT_LPSPI2) || \
+ defined(CONFIG_IMXRT_LPSPI3) || defined(CONFIG_IMXRT_LPSPI4)
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: imxrt_spidev_initialize
+ *
+ * Description:
+ * Called to configure SPI chip select GPIO pins for the imxrt1060-evk
+ * board.
+ *
+ ****************************************************************************/
+
+void weak_function imxrt_spidev_initialize(void)
+{
+#ifdef CONFIG_IMXRT_LPSPI1
+ imxrt_config_gpio(GPIO_LPSPI1_CS); /* LPSPI1 chip select */
+ imxrt_config_gpio(GPIO_MMCSD_EN);
Review comment:
First find out what is being emitted to that section. Are exception (check command line with `V=1 make` in local build) and unwinding disabled (check the config.h in a local build)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-819874797
@jturnsek - Thank you for the contribution, and sticking with it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jturnsek commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
jturnsek commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-819468242
@davids5 OK, will do that this evening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jturnsek commented on a change in pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
jturnsek commented on a change in pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#discussion_r608655235
##########
File path: boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
##########
@@ -0,0 +1,213 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdint.h>
+#include <stdbool.h>
+#include <errno.h>
+#include <debug.h>
+
+#include <nuttx/spi/spi.h>
+#include <arch/board/board.h>
+
+#include "arm_arch.h"
+
+#include "imxrt_config.h"
+#include "imxrt_lpspi.h"
+#include "imxrt_gpio.h"
+#include "imxrt1064-evk.h"
+
+#if defined(CONFIG_IMXRT_LPSPI1) || defined(CONFIG_IMXRT_LPSPI2) || \
+ defined(CONFIG_IMXRT_LPSPI3) || defined(CONFIG_IMXRT_LPSPI4)
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: imxrt_spidev_initialize
+ *
+ * Description:
+ * Called to configure SPI chip select GPIO pins for the imxrt1060-evk
+ * board.
+ *
+ ****************************************************************************/
+
+void weak_function imxrt_spidev_initialize(void)
+{
+#ifdef CONFIG_IMXRT_LPSPI1
+ imxrt_config_gpio(GPIO_LPSPI1_CS); /* LPSPI1 chip select */
+ imxrt_config_gpio(GPIO_MMCSD_EN);
Review comment:
Agree with you. Will look into.
As you can see some build checks fail because of .ARM.exidx section and bigger offset then 0x3fffffff when using flash-ocram.ld linker script. This is not the case with MIMXRT1060_EVK because it is using FLASH_BASE of 0x60000000, while MIMXRT1064-EVK is using FLASH_BASE of 0x70000000 and this is out of R_ARM_PREL31 range. I do not know what to do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#discussion_r608569614
##########
File path: boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
##########
@@ -0,0 +1,213 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdint.h>
+#include <stdbool.h>
+#include <errno.h>
+#include <debug.h>
+
+#include <nuttx/spi/spi.h>
+#include <arch/board/board.h>
+
+#include "arm_arch.h"
+
+#include "imxrt_config.h"
+#include "imxrt_lpspi.h"
+#include "imxrt_gpio.h"
+#include "imxrt1064-evk.h"
+
+#if defined(CONFIG_IMXRT_LPSPI1) || defined(CONFIG_IMXRT_LPSPI2) || \
+ defined(CONFIG_IMXRT_LPSPI3) || defined(CONFIG_IMXRT_LPSPI4)
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: imxrt_spidev_initialize
+ *
+ * Description:
+ * Called to configure SPI chip select GPIO pins for the imxrt1060-evk
+ * board.
+ *
+ ****************************************************************************/
+
+void weak_function imxrt_spidev_initialize(void)
+{
+#ifdef CONFIG_IMXRT_LPSPI1
+ imxrt_config_gpio(GPIO_LPSPI1_CS); /* LPSPI1 chip select */
+ imxrt_config_gpio(GPIO_MMCSD_EN);
Review comment:
Looking at the schematic - the board supports full SDMMC is this for an external use case or a copy/paste artifact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#discussion_r608647184
##########
File path: boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
##########
@@ -0,0 +1,213 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdint.h>
+#include <stdbool.h>
+#include <errno.h>
+#include <debug.h>
+
+#include <nuttx/spi/spi.h>
+#include <arch/board/board.h>
+
+#include "arm_arch.h"
+
+#include "imxrt_config.h"
+#include "imxrt_lpspi.h"
+#include "imxrt_gpio.h"
+#include "imxrt1064-evk.h"
+
+#if defined(CONFIG_IMXRT_LPSPI1) || defined(CONFIG_IMXRT_LPSPI2) || \
+ defined(CONFIG_IMXRT_LPSPI3) || defined(CONFIG_IMXRT_LPSPI4)
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: imxrt_spidev_initialize
+ *
+ * Description:
+ * Called to configure SPI chip select GPIO pins for the imxrt1060-evk
+ * board.
+ *
+ ****************************************************************************/
+
+void weak_function imxrt_spidev_initialize(void)
+{
+#ifdef CONFIG_IMXRT_LPSPI1
+ imxrt_config_gpio(GPIO_LPSPI1_CS); /* LPSPI1 chip select */
+ imxrt_config_gpio(GPIO_MMCSD_EN);
Review comment:
I think it would make sense to have the board support only support what is on the schematic. Given the obscurity of IO definitions, it is far from obvious what IO pin GPIO_MMCSD_EN will be changes if SPI1 is lit. So it is best to save some one the heartache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jturnsek commented on a change in pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
jturnsek commented on a change in pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#discussion_r608618424
##########
File path: boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
##########
@@ -0,0 +1,213 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1064-evk/src/imxrt_spi.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdint.h>
+#include <stdbool.h>
+#include <errno.h>
+#include <debug.h>
+
+#include <nuttx/spi/spi.h>
+#include <arch/board/board.h>
+
+#include "arm_arch.h"
+
+#include "imxrt_config.h"
+#include "imxrt_lpspi.h"
+#include "imxrt_gpio.h"
+#include "imxrt1064-evk.h"
+
+#if defined(CONFIG_IMXRT_LPSPI1) || defined(CONFIG_IMXRT_LPSPI2) || \
+ defined(CONFIG_IMXRT_LPSPI3) || defined(CONFIG_IMXRT_LPSPI4)
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: imxrt_spidev_initialize
+ *
+ * Description:
+ * Called to configure SPI chip select GPIO pins for the imxrt1060-evk
+ * board.
+ *
+ ****************************************************************************/
+
+void weak_function imxrt_spidev_initialize(void)
+{
+#ifdef CONFIG_IMXRT_LPSPI1
+ imxrt_config_gpio(GPIO_LPSPI1_CS); /* LPSPI1 chip select */
+ imxrt_config_gpio(GPIO_MMCSD_EN);
Review comment:
I believe a copy/paste artifact because I have took a MIMXRT1060-EVK as basis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] CFD2 edited a comment on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
CFD2 edited a comment on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-861793114
@jturnsek does the driver support the SIP Flash (W25Q32JV) by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jturnsek commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
jturnsek commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-819783194
@davids5 CI checks successful. Thank you very much. It has been a good day:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-817843289
Hi @jturnsek, this looks really good, thanks! We should also add some documentation (apart from README.txt which you already did), but I am not quite sure what current docs policy is. [Those changes were needed few months ago](https://github.com/apache/incubator-nuttx/commit/2de4b6838934217ae1df555ba865b77a93636374), but sice then, Documentation/platforms folder has been introduced. @v01d, could you please share some light into this? Is there also a need to change boards/README.txt, README.md etc as I did with Teensy or those files are set to deletion when all docs is migrated to platforms/?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-818294888
> Hi @jturnsek, this looks really good, thanks! We should also add some documentation (apart from README.txt which you already did), but I am not quite sure what current docs policy is. [Those changes were needed few months ago](https://github.com/apache/incubator-nuttx/commit/2de4b6838934217ae1df555ba865b77a93636374), but sice then, Documentation/platforms folder has been introduced. @v01d, could you please share some light into this? Is there also a need to change boards/README.txt, README.md etc as I did with Teensy or those files are set to deletion when all docs is migrated to platforms/?
The intention is to fully document boards under Documentation/. This also involves identifying documentation which pertains to the arch and SoC level (which is sometimes present in board READMEs). There's no doc yet for arm and stm32, but we could have a blank skeleton for that so that new stm32 boards can already be documented there.
If you wish to have this as part of this PR I can create that skeleton first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jturnsek commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
jturnsek commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-818531840
@davids5 Hi, I am still having problems with the CI. Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jturnsek commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
jturnsek commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-817585926
I have added FlexSPI NOR driver into this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] CFD2 commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
CFD2 commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-861793114
@jturnsek does the driver support the SIP Flash (W2532JV) by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jturnsek commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
jturnsek commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-818448545
@davids5 I know where the problem is, but did not find the solution yet. I have checked and I do not enable exceptions or unwinding.
AR (create): libboard.a imxrt_boot.o imxrt_flexspi_nor_boot.o imxrt_flexspi_nor_flash.o imxrt_appinit.o imxrt_bringup.o imxrt_autoleds.o
make[2]: Leaving directory '/home/jernej/nuttx/nuttx/boards/arm/imxrt/imxrt1064-evk/src'
LD: nuttx
/usr/lib/gcc/arm-none-eabi/9.2.1/thumb/v7e-m+dp/hard/libgcc.a(_udivmoddi4.o):(.ARM.exidx+0x0): relocation truncated to fit: R_ARM_PREL31 against `.text'
make[1]: *** [Makefile:156: nuttx] Error 1
make[1]: Leaving directory '/home/jernej/nuttx/nuttx/arch/arm/src'
make: *** [tools/Makefile.unix:422: nuttx] Error 2
Do you have some clue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-819456263
@jturnsek - I had a look I think that you need to rebase on master and run https://github.com/apache/incubator-nuttx/blob/master/tools/refresh.sh or `make oldconfig` and `make savedefconfig` to update the new defconfigs for the 1064 for the new board manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-818526857
> The intention is to fully document boards under Documentation/. This also involves identifying documentation which pertains to the arch and SoC level (which is sometimes present in board READMEs). There's no doc yet for arm and stm32, but we could have a blank skeleton for that so that new stm32 boards can already be documented there.
>
> If you wish to have this as part of this PR I can create that skeleton first.
Thanks for clarifying this. I have [basic skeleton for imxrt series](https://github.com/michallenc/incubator-nuttx/tree/teensy-doc/Documentation/platforms/arm/imxrt) (MCU series used in this board) ready, but so far it´s more like a list of peripherals than proper documentation. But if we merge that basics into mainline then this PR could add Documentation/platforms/arm/imxrt/imxrt1064-evk folder with proper documentation. Arch level documentation would still be missing though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3462: MIMXRT1064-EVK support
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3462:
URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-818713887
> > The intention is to fully document boards under Documentation/. This also involves identifying documentation which pertains to the arch and SoC level (which is sometimes present in board READMEs). There's no doc yet for arm and stm32, but we could have a blank skeleton for that so that new stm32 boards can already be documented there.
> > If you wish to have this as part of this PR I can create that skeleton first.
>
> Thanks for clarifying this. I have [basic skeleton for imxrt series](https://github.com/michallenc/incubator-nuttx/tree/teensy-doc/Documentation/platforms/arm/imxrt) (MCU series used in this board) ready, but so far it´s more like a list of peripherals than proper documentation. But if we merge that basics into mainline then this PR could add Documentation/platforms/arm/imxrt/imxrt1064-evk folder with proper documentation. Arch level documentation would still be missing though.
Sure, that's good enough for now. It can be improved later. Please also remove the teensy-4.x README when you submit that part of the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org