You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/03/15 00:16:12 UTC

[GitHub] sijie opened a new pull request #1386: Improve sync send logic for allowing batching

sijie opened a new pull request #1386: Improve sync send logic for allowing batching
URL: https://github.com/apache/incubator-pulsar/pull/1386
 
 
   ### Motivation
   
   Batching is required for achieving high performance messaging. If we want to flip the default behaviour of publishers into batch publishing,
   we need to improve current send logic to flush out batches after enqueuing the send requests. so batch settings won't impact sync sends.
   
   ### Modifications
   
   - add a flush() method on single partition producer
   - break the send logic on single partition producer to `enqueue-flush-wait`
   - change multi-partitions producer to use single partition producer
   
   ### Result
   
   - sync send will "kind of ignore" batch settings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services