You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Qianlin Xia <qi...@microsoft.com> on 2014/12/16 08:43:39 UTC
Review Request 29091: Patch for KAFKA-1646
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description
-------
truncate off trailing zeros on broker restart if broker is gracefully stopped.
Diffs
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Improve 1646 fix by add log.preallocate
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated April 15, 2015, 1:45 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Kafka 1646 fix update - Do not do flush when trim
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Improve 1646 fix by add log.preallocate
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/#review80031
-----------------------------------------------------------
This patch is looking really good. One minor issue but otherwise good to go.
core/src/main/scala/kafka/log/FileMessageSet.scala
<https://reviews.apache.org/r/29091/#comment129783>
Forcing a flush here will block all writes to the segment during a log roll() (potentially for upward of 30 seconds). I don't actually think this flush is needed since we have a background process which handles the segment flush. I think trim() should just trim the excess bytes and the close() can still force the flush.
core/src/main/scala/kafka/log/LogConfig.scala
<https://reviews.apache.org/r/29091/#comment129784>
- Jay Kreps
On April 14, 2015, 10:54 a.m., Qianlin Xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29091/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 10:54 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1646
> https://issues.apache.org/jira/browse/KAFKA-1646
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Commit to local for 1646 fix
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
> core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
> core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
> core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
> core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
> core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
>
> Diff: https://reviews.apache.org/r/29091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qianlin Xia
>
>
Re: Review Request 29091: Improve 1646 fix by add log.preallocate
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated April 14, 2015, 10:54 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Improve 1646 fix by add log.preallocate
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Commit to local for 1646 fix
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Patch for KAFKA-1646
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated April 14, 2015, 10:46 a.m.)
Review request for kafka.
Changes
-------
Add log.preallocation for Kafka-1646 fix
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Add log.preallocation for Kafka-1646 fix
Diffs
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Patch for KAFKA-1646
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated April 14, 2015, 10:44 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1646
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Commit to local for 1646 fix
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Improve 1646 fix by reduce check if
Os.IsWindows
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/#review79812
-----------------------------------------------------------
I think this looks more reasonable. I am pretty confused by the code in roll(), have you tried that? Maybe I am misreading it?
Let's do this:
1. Push the preallocation as far down in log as possible. I.e. ideally FileMessageSet should do the preallocation and a trim() method which would be invoked on Log.role() and during FileMessageSet.close().
2. Get rid of the Os.isWindows option and make this a proper configuration as you suggested. I think there is nothing Windows specific, right?
3. Couple of other comments I left.
core/src/main/scala/kafka/log/Log.scala
<https://reviews.apache.org/r/29091/#comment129394>
This should not be exposed as it doesn't make sense as a public operation. The fact that we preallocate and shrink the data file is internal. I think we can just have this happen as part of close(), right?
core/src/main/scala/kafka/log/Log.scala
<https://reviews.apache.org/r/29091/#comment129395>
I'm confused by this. It looks like you are running log recovery--i.e. iterating over all messages in the segment and checksumming them--in the middle of rolling the log? That seems wrong, isn't it? I mean this means that if you had a 1GB log you would spend several minutes blocking during rolling the new segment, right? I think you do need to truncate off any preallocated bytes in the active segment but that should go through the same code path as close() right?
core/src/main/scala/kafka/utils/Utils.scala
<https://reviews.apache.org/r/29091/#comment129393>
This utility is a bit unusual now since it is something like openChannelAndPreallocate.
Let's do the following:
1. Remove the debug logging. We try to make the logging intelligible to non-programmer operators reading the log without reference to the code. And that won't make any sense.
2. Combine the two openChannel methods into one with an optional preallocateToSize option.
3. Move that method into FileMessageSet since that is the only place it is used and now it is a bit more idiosyncratic.
- Jay Kreps
On March 13, 2015, 3:12 a.m., Qianlin Xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29091/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 3:12 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1646
> https://issues.apache.org/jira/browse/KAFKA-1646
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Improve 1646 fix by reduce check if Os.IsWindows
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
> core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
> core/src/main/scala/kafka/log/LogManager.scala 7cee5435b23fcd0d76f531004911a2ca499df4f8
> core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
> core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
>
> Diff: https://reviews.apache.org/r/29091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qianlin Xia
>
>
Re: Review Request 29091: Improve 1646 fix by reduce check if
Os.IsWindows
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/#review76688
-----------------------------------------------------------
core/src/main/scala/kafka/utils/Utils.scala
<https://reviews.apache.org/r/29091/#comment124320>
can we do setLength for all os not just specific to windows?
- Sriharsha Chintalapani
On March 13, 2015, 3:12 a.m., Qianlin Xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29091/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 3:12 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1646
> https://issues.apache.org/jira/browse/KAFKA-1646
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Improve 1646 fix by reduce check if Os.IsWindows
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
> core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
> core/src/main/scala/kafka/log/LogManager.scala 7cee5435b23fcd0d76f531004911a2ca499df4f8
> core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
> core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
>
> Diff: https://reviews.apache.org/r/29091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qianlin Xia
>
>
Re: Review Request 29091: Improve 1646 fix by reduce check if
Os.IsWindows
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated March 13, 2015, 3:12 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Improve 1646 fix by reduce check if Os.IsWindows
Diffs
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogManager.scala 7cee5435b23fcd0d76f531004911a2ca499df4f8
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Improve 1646 fix by reduce check if
Os.IsWindows
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated March 13, 2015, 3:04 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Improve 1646 fix by reduce check if Os.IsWindows
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Merge branch '0.8.1' of http://git-wip-us.apache.org/repos/asf/kafka into Branch_0.8.1.1
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogManager.scala 7cee5435b23fcd0d76f531004911a2ca499df4f8
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Improve 1646 fix by truncate extra space
when clean shutdown
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated March 6, 2015, 9:11 a.m.)
Review request for kafka.
Changes
-------
Correct the titile
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Kafka 1646 fix
Diffs
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogManager.scala 7cee5435b23fcd0d76f531004911a2ca499df4f8
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Improve 1646 fix by truncate extra space
when clean shutdown
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated March 6, 2015, 8:51 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Merge branch '0.8.1' of http://git-wip-us.apache.org/repos/asf/kafka into Branch_0.8.1.1
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogManager.scala 7cee5435b23fcd0d76f531004911a2ca499df4f8
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Improve 1646 fix by truncate extra space
when clean shutdown
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated March 6, 2015, 8:48 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Improve 1646 fix by truncate extra space when clean shutdown
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
KAFKA-1158 run rat is not needed this is documented now in the release not part of the server running
kafka-1244,kafka-1246,kafka-1249; various gradle issues for release; patched by Jun Rao; reviewed by Neha Narkhede
KAFKA-1263 Snazzy up the README markdown for better visibility on github; patched by Joe Stein; reviewed by Neha Narkhede
KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them patch by Joe Stein; Reviewed by Jun Rao
KAFKA-1274 gradle.properties needs the variables used in the build.gradle patch by Joe Stein; Reviewed by Jun Rao
KAFKA-1254 remove vestigial sbt patch by Joe Stein; reviewed by Jun Rao
kafka-1271; controller logs exceptions during ZK session expiration; patched by Jun Rao; reviewed by Guozhang Wang and Jay kreps
auto rebalance last commit
KAFKA-1289 Misc. nitpicks in log cleaner for new 0.8.1 features patch by Jay Kreps, reviewed by Sriram Subramanian and Jun Rao
KAFKA-1288 add enclosing dir in release tar gz patch by Jun Rao, reviewed by Neha Narkhede
KAFKA-1311 Add a flag to turn off delete topic until it is stable; reviewed by Joel and Guozhang
KAFKA-1315 log.dirs property in KafkaServer intolerant of trailing slash; reviewed by Neha Narkhede and Guozhang Wang
kafka-1319; kafka jar doesn't depend on metrics-annotation any more; patched by Jun Rao; reviewed by Neha Narkhede
KAFKA-1317 KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state; reviewed by Neha Narkhede
KAFKA-1317 follow up fix
KAFKA-1350 Fix excessive state change logging;reviewed by Jun,Joel,Guozhang and Timothy
KAFKA-1358 Broker throws exception when reconnecting to zookeeper; reviewed by Neha Narkhede
KAFKA-1358: Fixing minor log4j statement
KAFKA-1373; Set first dirty (uncompacted) offset to first offset of the log if no checkpoint exists. Reviewed by Timothy Chen and Neha Narkhede.
KAFKA-1323; Fix regression due to KAFKA-1315 (support for relative directories in log.dirs property broke). Patched by Timothy Chen and Guozhang Wang; reviewed by Joel Koshy, Neha Narkhede and Jun Rao.
KAFKA-1356 Topic metadata requests takes too long to process; reviewed by Joel Koshy, Neha Narkhede, Jun Rao and Guozhang Wang
KAFKA-1365; Second Manual preferred replica leader election command always fails; reviewed by Joel Koshy.
KAFKA-1356 (Follow-up) patch to clean up metadata cache api; reviewed by Jun Rao
KAFKA-1362; Publish sources and javadoc jars; (also removed Scala 2.8.2-specific actions). Reviewed by Jun Rao and Joe Stein
KAFKA-1355; Avoid sending all topic metadata on state changes. Reviewed by Neha Narkhede, Timothy Chen and Guozhang Wang.
KAFKA-1398 dynamic config changes are broken.
KAFKA-1398 Dynamic config follow-on-comments.
KAFKA-1327 Add log cleaner metrics.
KAFKA-1356; follow-up - return unknown topic partition on non-existent topic if auto.create is off; reviewed by Timothy Chen, Neha Narkhede and Jun Rao.
KAFKA-1327; Log cleaner metrics follow-up patch to reset dirtiest log cleanable ratio; reviewed by Jun Rao
bump kafka version to 0.8.1.1 in gradle.properties patch by Joe Stein reviewed by Joel Koshy
KAFKA-1308; Publish jar of test utilities to Maven. Jun Rao and Jakob Homan; reviewed by Neha Narkhede.
Improve 1646 fix by truncate extra space when clean shutdown
Merge branch '0.8.1' of http://git-wip-us.apache.org/repos/asf/kafka into Branch_0.8.1.1
Diffs (updated)
-----
LICENSE cb1800b0c39afc60a3dbf8249ba98f27a63467f3
README-sbt.md 10b8d2523605e8c6b0854f11e37d6e9e24d2814f
README.md 9b272b52c8b65668f9f2c9aa15b95b7441735936
bin/kafka-run-class.sh 75a3fc42a2e41977fa0d19a53cbc31e7538b8283
bin/run-rat.sh 1b7bc312e8b42aca60e630f2c39b976ee8352a77
build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
clients/build.sbt ca3c8ee3d7e56cefec2ecf8f21b237615c9bd759
config/log4j.properties 1ab850772a965d1f4301678cfe58e3901a11b7e0
config/server.properties 2ffe0ebccf1092ddf614b2fcdc327c607dfd685a
contrib/LICENSE PRE-CREATION
contrib/NOTICE PRE-CREATION
contrib/hadoop-consumer/LICENSE 6b0b1270ff0ca8f03867efcd09ba6ddb6392b1e1
contrib/hadoop-consumer/build.sbt 02e95eb8ca2c7a97a1f6bef88c4e044ea1f99539
contrib/hadoop-producer/LICENSE 6b0b1270ff0ca8f03867efcd09ba6ddb6392b1e1
contrib/hadoop-producer/build.sbt 02e95eb8ca2c7a97a1f6bef88c4e044ea1f99539
core/build.sbt 3eff64ef3f15a85a2f4dff3e31fec9d2662719f2
core/src/main/scala/kafka/admin/TopicCommand.scala fc8d6861ccab54f9443c871b0208b81d172f357b
core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 03117377e1cb2ad63e4c7740d97ca9a4f20abeeb
core/src/main/scala/kafka/api/TopicMetadata.scala 0513a59ed94e556894b3515dc38666ee9a66ae3d
core/src/main/scala/kafka/cluster/Partition.scala 1087a2e91c86e36a2494a95913a3ec2daf238287
core/src/main/scala/kafka/controller/ControllerChannelManager.scala a1ee5a707412166629cf9025cac054570d6d27c0
core/src/main/scala/kafka/controller/KafkaController.scala d812cb4121d7f8705c6d54eae2fb67d824a5f79f
core/src/main/scala/kafka/controller/PartitionStateMachine.scala 57c96b5539f20d53238280b6e059325c757bddcf
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 613aec6f40db5831f62e1391450ef02b63ae3390
core/src/main/scala/kafka/controller/TopicDeletionManager.scala 91a446ddc8aeb2ac90a62e274f612da45a67f772
core/src/main/scala/kafka/log/CleanerConfig.scala fa946ada926025fe4d547d18591ba6d45481028e
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala b3ab5220a66a2ae82084dad89877daf60f613e66
core/src/main/scala/kafka/log/LogCleaner.scala 64046472a1f88a51390416a724c4c27915b9cbf3
core/src/main/scala/kafka/log/LogCleanerManager.scala 1612c8dbcaba8141e5ea7ee1a1578d9f4e129509
core/src/main/scala/kafka/log/LogConfig.scala 0b32aeeffcd9d4755ac90573448d197d3f729749
core/src/main/scala/kafka/log/LogManager.scala 10062af1e02af5e4238f408ba5b9f98cc226244f
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/network/RequestChannel.scala a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748
core/src/main/scala/kafka/server/KafkaApis.scala c56ad503d83e31850cc2032d192d29506de96fdd
core/src/main/scala/kafka/server/KafkaConfig.scala 3c3aafc2b3f06fc8f3168a8a9c1e0b08e944c1ef
core/src/main/scala/kafka/server/KafkaServer.scala 5e34f95e64eaf12ae7e904ffef32422a365eca86
core/src/main/scala/kafka/server/OffsetCheckpoint.scala 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0
core/src/main/scala/kafka/server/ReplicaManager.scala 21bba48affb38ff6504e02535d3cc56258f45b60
core/src/main/scala/kafka/server/TopicConfigManager.scala d41fd33d91406dfa2ce8c1e1b04a078e983ccadd
core/src/main/scala/kafka/utils/Throttler.scala c6c3c75ee8408ca81aeeb5846f7987a287b5a6e8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
core/src/main/scala/kafka/utils/VerifiableProperties.scala b070bb4df117df8542a651b4f0b6bc476855308b
core/src/main/scala/kafka/utils/ZkUtils.scala fa86bb94475dec41d5ea1a94f4eebcd5500756e6
core/src/test/scala/other/kafka/TestLogCleaning.scala 22b16e54980e30f60dbf2fbe46c16398d654ba21
core/src/test/scala/unit/kafka/admin/AdminTest.scala d5644ea40ec7678b975c4775546b79fcfa9f64b7
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 974b057a880569ddd2035980d317147d892cf24f
core/src/test/scala/unit/kafka/log/CleanerTest.scala 51cd94b316764574d32d34b1c97c7b43c908b2ab
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 1de3ef0435d76e858167cedb07f5548751605f79
core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8
core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala 02c188a412995f876dd6616d70027b84c07eb264
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 20fe93e623319fd82236eb6364d7f80bf7a256aa
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 1317b4c3c60b8d1835dd6a06bf9b250398f0d47d
core/src/test/scala/unit/kafka/utils/TestUtils.scala 500eeca2f95d901536b1363b8c4b485c4893179f
examples/build.sbt d12d70142f6ece849177cd39fb1ca66799306dac
gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
lib/sbt-launch.jar 06ad8d880592ad776fdfc38c573359261314e6c3
perf/build.sbt 8aa72f4a13eda3d18a3c6e3816f7c39753e643c4
project/Build.scala ddcfc4176e68933377590e095c07283083249f4a
project/build.properties eea46f3ca0a07d9e648b4b5c784f2d01a60c4ee4
project/build/KafkaProject.scala f29c67a47fe89099dd02087d78bf9f4a3ee63a72
project/plugins.sbt 7abe703893ba04d819cbcfdacd38298eca39431d
sbt 944ebf8c383ecbd2475bc6fcacd6ac9f5b3fd799
sbt.bat 9321ada9316ac420ee3639488e639ec452b64f09
scala.gradle PRE-CREATION
settings.gradle 74e591a8a4afc6586fd24caf7fdb3d224e126d6b
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Patch for KAFKA-1646
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/#review65216
-----------------------------------------------------------
Ship it!
Overall it looks good to me.
- Sriharsha Chintalapani
On Dec. 16, 2014, 8:30 a.m., Qianlin Xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29091/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 8:30 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1646
> https://issues.apache.org/jira/browse/KAFKA-1646
>
>
> Repository: kafka
>
>
> Description
> -------
>
> truncate off trailing zeros on broker restart if broker is gracefully stopped.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
> core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
> core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
> core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
>
> Diff: https://reviews.apache.org/r/29091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qianlin Xia
>
>
Re: Review Request 29091: Patch for KAFKA-1646
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 8:30 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description
-------
truncate off trailing zeros on broker restart if broker is gracefully stopped.
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Patch for KAFKA-1646
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 8:22 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description
-------
truncate off trailing zeros on broker restart if broker is gracefully stopped.
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Patch for KAFKA-1646
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 8:18 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description
-------
truncate off trailing zeros on broker restart if broker is gracefully stopped.
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Patch for KAFKA-1646
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 8:13 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description
-------
truncate off trailing zeros on broker restart if broker is gracefully stopped.
Diffs
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia