You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Srikanth Sundarrajan <sr...@hotmail.com> on 2014/01/30 06:48:15 UTC

Review Request 17525: FALCON-264 Update with effectiveTime in CLI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-264
    https://issues.apache.org/jira/browse/FALCON-264


Repository: falcon-git


Description
-------

Update with effective time in CLI


Diffs
-----

  client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
  client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
  common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
  pom.xml 9252d80 
  prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
  prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
  webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
  webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 

Diff: https://reviews.apache.org/r/17525/diff/


Testing
-------


Thanks,

Srikanth Sundarrajan


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33301
-----------------------------------------------------------

Ship it!


Ship It!

- Srikanth Sundarrajan


On Jan. 31, 2014, 7:31 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 7:31 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
>   docs/src/site/twiki/FalconCLI.twiki 1d451be 
>   docs/src/site/twiki/FalconDocumentation.twiki 1c96ecf 
>   docs/src/site/twiki/restapi/EntityUpdate.twiki 82e9f2e 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/
-----------------------------------------------------------

(Updated Jan. 31, 2014, 7:31 a.m.)


Review request for Falcon.


Bugs: FALCON-264
    https://issues.apache.org/jira/browse/FALCON-264


Repository: falcon-git


Description
-------

Update with effective time in CLI


Diffs (updated)
-----

  client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
  client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
  common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
  docs/src/site/twiki/FalconCLI.twiki 1d451be 
  docs/src/site/twiki/FalconDocumentation.twiki 1c96ecf 
  docs/src/site/twiki/restapi/EntityUpdate.twiki 82e9f2e 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
  pom.xml 9252d80 
  prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
  prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
  webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
  webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 

Diff: https://reviews.apache.org/r/17525/diff/


Testing
-------


Thanks,

Srikanth Sundarrajan


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by sh...@inmobi.com.

> On Jan. 30, 2014, 6:05 a.m., shaik idris wrote:
> > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java, line 885
> > <https://reviews.apache.org/r/17525/diff/1/?file=454211#file454211line885>
> >
> >     Typo in API, effectiveTime
> 
> Srikanth Sundarrajan wrote:
>     This isn't fixed.

It is fixed


- shwethags


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33203
-----------------------------------------------------------


On Jan. 31, 2014, 7:31 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 7:31 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
>   docs/src/site/twiki/FalconCLI.twiki 1d451be 
>   docs/src/site/twiki/FalconDocumentation.twiki 1c96ecf 
>   docs/src/site/twiki/restapi/EntityUpdate.twiki 82e9f2e 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.

> On Jan. 30, 2014, 6:05 a.m., shaik idris wrote:
> > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java, line 885
> > <https://reviews.apache.org/r/17525/diff/1/?file=454211#file454211line885>
> >
> >     Typo in API, effectiveTime

This isn't fixed.


- Srikanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33203
-----------------------------------------------------------


On Jan. 31, 2014, 7:31 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 7:31 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
>   docs/src/site/twiki/FalconCLI.twiki 1d451be 
>   docs/src/site/twiki/FalconDocumentation.twiki 1c96ecf 
>   docs/src/site/twiki/restapi/EntityUpdate.twiki 82e9f2e 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by sh...@inmobi.com.

> On Jan. 30, 2014, 6:05 a.m., shaik idris wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 362
> > <https://reviews.apache.org/r/17525/diff/1/?file=454208#file454208line362>
> >
> >     This validation should be at API level, if CLI is bypassed.
> 
> shwethags wrote:
>     Yes, I noticed it. But all the other validations are at CLI, hence I added it here. Will move this to client

Actually, the argument in CLI is a string and in client its a date. So, the validation should be in CLI only. 


- shwethags


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33203
-----------------------------------------------------------


On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by sh...@inmobi.com.

> On Jan. 30, 2014, 6:05 a.m., shaik idris wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 362
> > <https://reviews.apache.org/r/17525/diff/1/?file=454208#file454208line362>
> >
> >     This validation should be at API level, if CLI is bypassed.

Yes, I noticed it. But all the other validations are at CLI, hence I added it here. Will move this to client


- shwethags


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33203
-----------------------------------------------------------


On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by shaik idris <ps...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33203
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/17525/#comment62565>

    This validation should be at API level, if CLI is bypassed.



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/17525/#comment62564>

    Typo in API, effectiveTime


- shaik idris


On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.

> On Jan. 30, 2014, 6 a.m., Srikanth Sundarrajan wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 80
> > <https://reviews.apache.org/r/17525/diff/1/?file=454208#file454208line80>
> >
> >     Can this switch be called effectiveTime instead
> 
> shwethags wrote:
>     Its too long to write in CLI. So, used time instead

Agreed


- Srikanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33201
-----------------------------------------------------------


On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by sh...@inmobi.com.

> On Jan. 30, 2014, 6 a.m., Srikanth Sundarrajan wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 80
> > <https://reviews.apache.org/r/17525/diff/1/?file=454208#file454208line80>
> >
> >     Can this switch be called effectiveTime instead

Its too long to write in CLI. So, used time instead


> On Jan. 30, 2014, 6 a.m., Srikanth Sundarrajan wrote:
> > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java, line 191
> > <https://reviews.apache.org/r/17525/diff/1/?file=454214#file454214line191>
> >
> >     REST query param can also be called effectiveTime

Yes, I can change this to effectiveTime


> On Jan. 30, 2014, 6 a.m., Srikanth Sundarrajan wrote:
> > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java, line 758
> > <https://reviews.apache.org/r/17525/diff/1/?file=454216#file454216line758>
> >
> >     Looks like this function isn't being used. Dont know what is the impact of changing the end time to the first hour of the day to the first day of the month.

I had a testcase that was using this. Let me check where it went missing. The example process used has frequency of 1 day. It doesn't set the time to first day of month, it adds one day so that effective time is in the future.


- shwethags


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33201
-----------------------------------------------------------


On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33201
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/17525/#comment62558>

    Can this switch be called effectiveTime instead



prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
<https://reviews.apache.org/r/17525/#comment62559>

    REST query param can also be called effectiveTime



webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java
<https://reviews.apache.org/r/17525/#comment62560>

    time to effectiveTime



webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java
<https://reviews.apache.org/r/17525/#comment62561>

    Looks like this function isn't being used. Dont know what is the impact of changing the end time to the first hour of the day to the first day of the month.


- Srikanth Sundarrajan


On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>