You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/02/04 01:35:44 UTC

Review Request 43168: Added working dir flag to command executor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43168/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4005
    https://issues.apache.org/jira/browse/MESOS-4005


Repository: mesos


Description
-------

Added working dir flag to command executor.


Diffs
-----

  src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 

Diff: https://reviews.apache.org/r/43168/diff/


Testing
-------

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 43168: Added working dir flag to command executor.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43168/#review117904
-----------------------------------------------------------




src/launcher/executor.cpp (line 215)
<https://reviews.apache.org/r/43168/#comment179162>

    Can you add a TODO here saying that this is a hacky way to detect if root filesystem is specified for the command task.



src/launcher/executor.cpp (lines 351 - 364)
<https://reviews.apache.org/r/43168/#comment179161>

    Ditto on merging them so that we don't chdir twice.
    ```
    string cwd;
    if (workingDirectory.isSome()) {
      cwd = workingDirectory.get();
    } else {
      CHECK_SOME(sandboxDirectory);
      cwd = sandboxDirectory.get();
    }
    
    Try<Nothing> chdir = os::chdir(cwd);
    if (chdir.isError()) {
      ...
    }
    ```



src/launcher/executor.cpp (lines 780 - 781)
<https://reviews.apache.org/r/43168/#comment179163>

    Adjust the help message here according to my comments in the other review.


- Jie Yu


On Feb. 4, 2016, 12:35 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43168/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 12:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4005
>     https://issues.apache.org/jira/browse/MESOS-4005
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added working dir flag to command executor.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
> 
> Diff: https://reviews.apache.org/r/43168/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43168: Added working dir flag to command executor.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43168/#review118040
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 5, 2016, 1:24 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43168/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 1:24 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4005
>     https://issues.apache.org/jira/browse/MESOS-4005
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added working dir flag to command executor.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp b214a3f876a023c1d68dab4288b18fe5068b2b5a 
> 
> Diff: https://reviews.apache.org/r/43168/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43168: Added working dir flag to command executor.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43168/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 5:24 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4005
    https://issues.apache.org/jira/browse/MESOS-4005


Repository: mesos


Description
-------

Added working dir flag to command executor.


Diffs (updated)
-----

  src/launcher/executor.cpp b214a3f876a023c1d68dab4288b18fe5068b2b5a 

Diff: https://reviews.apache.org/r/43168/diff/


Testing
-------

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song