You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/02 12:14:10 UTC
[GitHub] [kafka] chia7712 opened a new pull request #10246: MINOR: add 'toString' to classes which are used by loggin
chia7712 opened a new pull request #10246:
URL: https://github.com/apache/kafka/pull/10246
see following links for `toString` references
BrokerHeartbeatState
https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java#L188
QuorumState
https://github.com/apache/kafka/blob/trunk/raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java#L629
MemberToRemove
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java#L86
InsertionSpec
https://github.com/apache/kafka/blob/trunk/connect/transforms/src/main/java/org/apache/kafka/connect/transforms/InsertField.java#L122
Field
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/protocol/types/TaggedFields.java#L143
FieldSpec
https://github.com/apache/kafka/blob/trunk/generator/src/main/java/org/apache/kafka/message/Target.java#L61
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a change in pull request #10246: MINOR: add 'toString' to classes which are used by loggin
Posted by GitBox <gi...@apache.org>.
dengziming commented on a change in pull request #10246:
URL: https://github.com/apache/kafka/pull/10246#discussion_r585558320
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/types/Field.java
##########
@@ -46,6 +46,17 @@ public Field(String name, Type type) {
this(name, type, null, false, null);
}
+ @Override
+ public String toString() {
+ return "Field{" +
+ "name='" + name + '\'' +
+ ", docString='" + docString + '\'' +
Review comment:
the docString field maybe very long so how about putting it to last？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #10246: MINOR: add 'toString' to classes which are used by loggin
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #10246:
URL: https://github.com/apache/kafka/pull/10246#discussion_r585600633
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/types/Field.java
##########
@@ -46,6 +46,17 @@ public Field(String name, Type type) {
this(name, type, null, false, null);
}
+ @Override
+ public String toString() {
+ return "Field{" +
+ "name='" + name + '\'' +
+ ", docString='" + docString + '\'' +
Review comment:
good suggestion. will move it to last.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a change in pull request #10246: MINOR: add 'toString' to classes which are used by loggin
Posted by GitBox <gi...@apache.org>.
dengziming commented on a change in pull request #10246:
URL: https://github.com/apache/kafka/pull/10246#discussion_r585558320
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/types/Field.java
##########
@@ -46,6 +46,17 @@ public Field(String name, Type type) {
this(name, type, null, false, null);
}
+ @Override
+ public String toString() {
+ return "Field{" +
+ "name='" + name + '\'' +
+ ", docString='" + docString + '\'' +
Review comment:
the docString field maybe very long so how about putting it to last or ignore it？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #10246: MINOR: add 'toString' to classes which are used by loggin
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #10246:
URL: https://github.com/apache/kafka/pull/10246#discussion_r585600633
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/types/Field.java
##########
@@ -46,6 +46,17 @@ public Field(String name, Type type) {
this(name, type, null, false, null);
}
+ @Override
+ public String toString() {
+ return "Field{" +
+ "name='" + name + '\'' +
+ ", docString='" + docString + '\'' +
Review comment:
good suggestion. will address it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org