You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/22 09:14:13 UTC
[GitHub] [dubbo-go] beiwei30 opened a new pull request #954: DelParam method on common.URL
beiwei30 opened a new pull request #954:
URL: https://github.com/apache/dubbo-go/pull/954
parameter
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Introduce a new method 'DelParam' on common.URL so that now it is possible to remove one particular parameter from the URL.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #954: DelParam method on common.URL
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #954:
URL: https://github.com/apache/dubbo-go/pull/954#issuecomment-749441157
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=h1) Report
> Merging [#954](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=desc) (b4f304e) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f7342649f8f46da80a2f879e6b7a3adc30fd4f34?el=desc) (f734264) will **decrease** coverage by `0.16%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #954 +/- ##
===========================================
- Coverage 60.27% 60.10% -0.17%
===========================================
Files 260 260
Lines 12894 12897 +3
===========================================
- Hits 7772 7752 -20
- Misses 4160 4183 +23
Partials 962 962
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `61.04% <0.00%> (-0.57%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `42.85% <0.00%> (-8.58%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `69.04% <0.00%> (-1.59%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `39.83% <0.00%> (+10.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=footer). Last update [f734264...b4f304e](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #954: DelParam method on common.URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #954:
URL: https://github.com/apache/dubbo-go/pull/954#issuecomment-749441157
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=h1) Report
> Merging [#954](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=desc) (b4f304e) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f7342649f8f46da80a2f879e6b7a3adc30fd4f34?el=desc) (f734264) will **increase** coverage by `0.07%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #954 +/- ##
===========================================
+ Coverage 60.27% 60.34% +0.07%
===========================================
Files 260 260
Lines 12894 12897 +3
===========================================
+ Hits 7772 7783 +11
+ Misses 4160 4149 -11
- Partials 962 965 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `61.04% <0.00%> (-0.57%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `69.04% <0.00%> (-1.59%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.84% <0.00%> (+3.15%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/954/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `39.83% <0.00%> (+10.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=footer). Last update [f734264...b4f304e](https://codecov.io/gh/apache/dubbo-go/pull/954?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #954: DelParam method on common.URL
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #954:
URL: https://github.com/apache/dubbo-go/pull/954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org