You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/07/19 09:53:19 UTC
[GitHub] erisu commented on a change in pull request #848: Remove deprecated
platforms from plugin page
erisu commented on a change in pull request #848: Remove deprecated platforms from plugin page
URL: https://github.com/apache/cordova-docs/pull/848#discussion_r203666592
##########
File path: www/static/plugins/supportedplatforms.jsx
##########
@@ -1,83 +1,32 @@
-var Preact = require('preact'),
- h = require('preact').h,
- createClass = require('preact-compat').createClass,
- PlatformButton = require('./platformbutton.jsx');
+const Preact = require('preact');
+const h = require('preact').h;
+const createClass = require('preact-compat').createClass;
+const PlatformButton = require('./platformbutton.jsx');
-var SupportedPlatforms = createClass({
- render: function() {
- var keywords = this.props.keywords;
- var sortedPlatforms = [
- {present:false, icon: "android", alt:"Android"},
- {present:false, icon: "ios", alt:"iOS"},
- {present:false, icon: "windows", alt:"Windows"},
- {present:false, icon: "blackberry", alt:"Blackberry"},
- {present:false, icon: "ubuntu", alt:"Ubuntu"},
- {present:false, icon: "firefox", alt:"FirefoxOS"},
- {present:false, icon: "webos", alt:"webOS"},
- {present:false, icon: "fireos", alt:"FireOS"},
- {present:false, icon: "osx", alt:"OS X"},
- {present:false, icon: "browser", alt:"Browser"}
+const SupportedPlatforms = createClass({
+ render: function () {
+ // Collection of the npm package keywords.
+ const keywords = new Set(this.props.keywords);
Review comment:
@raphinesse I just uploaded another alternative that doesn't use arrow functions or Set.
As for transpilation, I see a transform process that babelify, in the gulp build task but only has the react preset.
https://github.com/apache/cordova-docs/blob/0c5f1136f56a20582ab58a41757500ea79c71a3b/gulpfile.js#L406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org