You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/28 11:26:46 UTC
[GitHub] [airflow] rafalh opened a new pull request #21866: Make project_id argument optional in all dataproc operators
rafalh opened a new pull request #21866:
URL: https://github.com/apache/airflow/pull/21866
`DataprocHook` handles `project_id=None` in `@GoogleBaseHook.fallback_to_default_project_id` decorator.
In some operators `project_id` was already optional. Make it optional for all.
Note: this change is not backward compatible because order of constructor arguments changed in some operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #21866: Make project_id argument optional in all dataproc operators
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #21866:
URL: https://github.com/apache/airflow/pull/21866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #21866: Make project_id argument optional in all dataproc operators
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #21866:
URL: https://github.com/apache/airflow/pull/21866#issuecomment-1054185819
> Note: this change is not backward compatible because order of constructor arguments changed in some operators.
These changes are backward compatible because all operators use only keywords arguments.
https://github.com/apache/airflow/blob/7407a95cde08b065118221312ec3bdf128841aed/airflow/providers/google/cloud/operators/dataproc.py#L451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #21866: Make project_id argument optional in all dataproc operators
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #21866:
URL: https://github.com/apache/airflow/pull/21866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21866: Make project_id argument optional in all dataproc operators
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21866:
URL: https://github.com/apache/airflow/pull/21866#issuecomment-1054811563
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org