You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/11/23 21:22:29 UTC
[GitHub] [gobblin] arjun4084346 opened a new pull request, #3607: add job.name and job.id to kafka workunits
arjun4084346 opened a new pull request, #3607:
URL: https://github.com/apache/gobblin/pull/3607
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3607: [GOBBLIN-1747] add job.name and job.id to kafka workunits
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3607:
URL: https://github.com/apache/gobblin/pull/3607#issuecomment-1325688517
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3607?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3607](https://codecov.io/gh/apache/gobblin/pull/3607?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37e78a5) into [master](https://codecov.io/gh/apache/gobblin/commit/94c40dc950e57b32cc5c14dfaddddb4538df2709?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94c40dc) will **decrease** coverage by `5.61%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3607 +/- ##
============================================
- Coverage 49.36% 43.75% -5.62%
+ Complexity 9199 2062 -7137
============================================
Files 1741 408 -1333
Lines 67495 17627 -49868
Branches 7715 2154 -5561
============================================
- Hits 33322 7713 -25609
+ Misses 31055 9057 -21998
+ Partials 3118 857 -2261
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3607?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../runtime/job\_catalog/NonObservingFSJobCatalog.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2NhdGFsb2cvTm9uT2JzZXJ2aW5nRlNKb2JDYXRhbG9nLmphdmE=) | | |
| [...obblin/service/modules/flowgraph/BaseDataNode.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvQmFzZURhdGFOb2RlLmphdmE=) | | |
| [...n/listeners/SimpleCompactorCompletionListener.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbGlzdGVuZXJzL1NpbXBsZUNvbXBhY3RvckNvbXBsZXRpb25MaXN0ZW5lci5qYXZh) | | |
| [...in/data/management/policy/SelectNothingPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3BvbGljeS9TZWxlY3ROb3RoaW5nUG9saWN5LmphdmE=) | | |
| [.../org/apache/gobblin/service/ServiceConfigKeys.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9TZXJ2aWNlQ29uZmlnS2V5cy5qYXZh) | | |
| [...e/gobblin/metrics/ConsoleEventReporterFactory.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Db25zb2xlRXZlbnRSZXBvcnRlckZhY3RvcnkuamF2YQ==) | | |
| [.../data/management/dataset/SimpleDatasetRequest.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvU2ltcGxlRGF0YXNldFJlcXVlc3QuamF2YQ==) | | |
| [...gement/retention/version/StringDatasetVersion.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi92ZXJzaW9uL1N0cmluZ0RhdGFzZXRWZXJzaW9uLmphdmE=) | | |
| [...che/gobblin/metrics/event/GobblinEventBuilder.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9Hb2JibGluRXZlbnRCdWlsZGVyLmphdmE=) | | |
| [...org/apache/gobblin/runtime/EventMetadataUtils.java](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvRXZlbnRNZXRhZGF0YVV0aWxzLmphdmE=) | | |
| ... and [1326 more](https://codecov.io/gh/apache/gobblin/pull/3607/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3607: [GOBBLIN-1747] add job.name and job.id to kafka and compaction workunits
Posted by GitBox <gi...@apache.org>.
Will-Lo merged PR #3607:
URL: https://github.com/apache/gobblin/pull/3607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org