[GitHub] [druid] FrankChen021 commented on a change in pull request #12373: Deprecated jackson fix

[GitBox <gi...@apache.org>]

FrankChen021 commented on a change in pull request #12373:
URL: https://github.com/apache/druid/pull/12373#discussion_r836989594



##########
File path: core/src/main/java/org/apache/druid/guice/GuiceAnnotationIntrospector.java
##########
@@ -58,9 +58,9 @@ public Object findInjectableValueId(AnnotatedMember m)
       if (m instanceof AnnotatedMethod) {
         throw new IAE("Annotated methods don't work very well yet...");
       }
-      return Key.get(m.getGenericType());
+      return Key.get(m.getRawType());

Review comment:
       ``` java
       /**
        * JDK declared generic type of the annotated element; definition
        * of what exactly this means depends on sub-class. Note that such type
        * cannot be reliably resolved without {@link TypeResolutionContext}, and
        * as a result use of this method was deprecated in Jackson 2.7: see
        * {@link #getType} for replacement.
        *
        * @deprecated Since 2.7 should instead use {@link #getType()}. To be removed from 2.9
        */
   ```
   
   I'm a little confused that the javadoc indicates that `getType` should be used as a replacement, and current `getGenericType` calls `getRawType()` internally.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org