You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by ni...@apache.org on 2006/06/16 18:32:08 UTC

svn commit: r414857 - in /jakarta/poi/trunk/src/scratchpad: src/org/apache/poi/hslf/model/TextRun.java testcases/org/apache/poi/hslf/usermodel/TestRichTextRun.java

Author: nick
Date: Fri Jun 16 09:32:07 2006
New Revision: 414857

URL: http://svn.apache.org/viewvc?rev=414857&view=rev
Log:
Tweak rich text handling

Modified:
    jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java
    jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/usermodel/TestRichTextRun.java

Modified: jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java
URL: http://svn.apache.org/viewvc/jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java?rev=414857&r1=414856&r2=414857&view=diff
==============================================================================
--- jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java (original)
+++ jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java Fri Jun 16 09:32:07 2006
@@ -88,7 +88,7 @@
 		LinkedList cStyles = new LinkedList();
 		if(_styleAtom != null) {
 			// Get the style atom to grok itself
-			_styleAtom.setParentTextSize(runRawText.length()+1);
+			_styleAtom.setParentTextSize(runRawText.length());
 			pStyles = _styleAtom.getParagraphStyles();
 			cStyles = _styleAtom.getCharacterStyles();
 		}

Modified: jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/usermodel/TestRichTextRun.java
URL: http://svn.apache.org/viewvc/jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/usermodel/TestRichTextRun.java?rev=414857&r1=414856&r2=414857&view=diff
==============================================================================
--- jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/usermodel/TestRichTextRun.java (original)
+++ jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/usermodel/TestRichTextRun.java Fri Jun 16 09:32:07 2006
@@ -182,6 +182,11 @@
 			rtr.setFontSize(18);
 			rtr.setFontName("Courier");
 			
+			// Check it took those
+			assertEquals(true, rtr.isBold());
+			assertEquals(18, rtr.getFontSize());
+			assertEquals("Courier", rtr.getFontName());
+			
 			// Write out and back in
 			ByteArrayOutputStream baos = new ByteArrayOutputStream();
 			h[i].write(baos);
@@ -195,8 +200,14 @@
 			rtr.setFontSize(17);
 			rtr.setFontName("CourierZZ");
 			
+			// Check it took those changes
+			assertEquals(false, rtr.isBold());
+			assertEquals(17, rtr.getFontSize());
+			assertEquals("CourierZZ", rtr.getFontName());
+
 			
-			// Check written out/back ing one contains modifications
+			// Now, look at the one we changed, wrote out, and read back in
+			// Ensure it does contain our original modifications
 			Slide slideOneRR = readS.getSlides()[0];
 			TextRun[] textRunsRR = slideOneRR.getTextRuns();
 			RichTextRun rtrRRa = textRunsRR[0].getRichTextRuns()[0];



---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/