You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "laurentgo (via GitHub)" <gi...@apache.org> on 2024/03/27 22:18:36 UTC
[PR] MINOR: [Java] Fix maven-checkstyle-plugin configuration [arrow]
laurentgo opened a new pull request, #40850:
URL: https://github.com/apache/arrow/pull/40850
### Rationale for this change
`maven-checkstyle-plugin` configuration refers to several unrecognized properties, causing build output to print several messages like:
> [WARNING] Parameter 'format' is unknown for plugin 'maven-checkstyle-plugin:3.1.0:check (validate)'
### What changes are included in this PR?
Fix checkstyle configuration and use the correct outputFileFormat and inputEncoding properties in place of the unrecognized format and encoding ones.
### Are these changes tested?
As this is a build change with no code change, only via a local build + visual inspection of the build output
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Fix maven-checkstyle-plugin configuration [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #40850:
URL: https://github.com/apache/arrow/pull/40850#issuecomment-2024172951
Thanks @laurentgo for creating this PR, I kicked the crossbows to validate the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Fix maven-checkstyle-plugin configuration [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #40850:
URL: https://github.com/apache/arrow/pull/40850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Fix maven-checkstyle-plugin configuration [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40850:
URL: https://github.com/apache/arrow/pull/40850#issuecomment-2024173121
Revision: 1588a21122890cf09d8e0ce4ccc74b8b4cf3e326
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1a040d372b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1a040d372b)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/8460226578/job/23178031753)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8460226603/job/23178031486)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8460226584/job/23178031196)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8460226585/job/23178031193)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8460226600/job/23178031500)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8460226601/job/23178031400)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Fix maven-checkstyle-plugin configuration [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #40850:
URL: https://github.com/apache/arrow/pull/40850#issuecomment-2024171406
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Fix maven-checkstyle-plugin configuration [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #40850:
URL: https://github.com/apache/arrow/pull/40850#issuecomment-2026325432
@lidavidm seems like the crossbows are passing, there is a failing Windows CI and it seems to be not related. Although we could re-run and verify. The change looks fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Java] Fix maven-checkstyle-plugin configuration [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40850:
URL: https://github.com/apache/arrow/pull/40850#issuecomment-2032217942
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 65dd5c7e23b0e4a7aa57a50f619ef5c017da0894.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23349801378) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org