You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/11/22 07:40:47 UTC
[GitHub] [james-project] chibenwa opened a new pull request #755: JAMES-3487 Java property: MimeMessageInputStreamSource THRESHOLD
chibenwa opened a new pull request #755:
URL: https://github.com/apache/james-project/pull/755
- Docmentation available
- Added but commented within jvm.properties file (cf #744)
This is a rework of #285 using #744 to improve discoverability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #755: JAMES-3487 Java property: MimeMessageInputStreamSource THRESHOLD
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #755:
URL: https://github.com/apache/james-project/pull/755#issuecomment-975208828
Cc @ottoka @mbaechler @jeantil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #755: JAMES-3487 Java property: MimeMessageInputStreamSource THRESHOLD
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #755:
URL: https://github.com/apache/james-project/pull/755#discussion_r754045665
##########
File path: src/site/xdoc/server/config-system.xml
##########
@@ -166,6 +166,23 @@
<p>For testing purposes, you may specify a different file path via the
command line option <code>-Dextra.props=/some/other/jvm.properties</code>.</p>
+ <p>Some tuning can be done via system properties. This includes:</p>
+
+ <dl>
+ <dt><strong>james.message.memory.threshold</strong></dt>
+ <dd>(Optional). String (size, integer + size units, example: `12 KIB`, supported units are bytes KIB MIB GIB TIB). Defaults to 100KIB. <br/>
+ This governs the threshold MimeMessageInputStreamSource relies on for storing MimeMessage content on disk. <br/>
+ Below, data is stored in memory. Above data is stored on disk.
+ Lower values will lead to longer processing time but will minimize heap memory usage. Modern SSD hardware
+ should however support a high throughput. Higher values will lead to faster single mail processing at the cost
+ of higher heap usage.
+ </dd>
+
+ <dt><strong>james.message.usememorycopy</strong></dt>
+ <dd>Optional. Boolean. Defaults to false. Recommended value is false. <br/>
+ Should MimeMessageWrapper use a copy of the message in memory?</dd>
Review comment:
```suggestion
Should MimeMessageWrapper use a copy of the message in memory? Or should bigger message exceeding james.message.memory.threshold be copied to temporary files?</dd>
```
##########
File path: server/apps/distributed-app/docs/modules/ROOT/pages/configure/index.adoc
##########
@@ -63,3 +63,26 @@ By omitting these files, no extra behaviour is added.
** xref:configure/collecting-contacts.adoc[This page] documents contact collection
** xref:configure/collecting-events.adoc[This page] documents event collection
** xref:configure/dsn.adoc[this page] specified how to support SMTP Delivery Submission Notification (link:https://tools.ietf.org/html/rfc3461[RFC-3461])
+
+== System properties
+
+Some tuning can be done via system properties. This includes:
+
+.System properties
+|===
+| Property name | explanation
+
+| james.message.memory.threshold
+| (Optional). String (size, integer + size units, example: `12 KIB`, supported units are bytes KIB MIB GIB TIB). Defaults to 100KIB.
+This governs the threshold MimeMessageInputStreamSource relies on for storing MimeMessage content on disk.
+Below, data is stored in memory. Above data is stored on disk.
+Lower values will lead to longer processing time but will minimize heap memory usage. Modern SSD hardware
+should however support a high throughput. Higher values will lead to faster single mail processing at the cost
+of higher heap usage.
+
+
+| james.message.usememorycopy
+|Optional. Boolean. Defaults to false. Recommended value is false.
+Should MimeMessageWrapper use a copy of the message in memory?
Review comment:
```suggestion
Should MimeMessageWrapper use a copy of the message in memory? Or should bigger message exceeding james.message.memory.threshold
be copied to temporary files?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #755: JAMES-3487 Java property: MimeMessageInputStreamSource THRESHOLD
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #755:
URL: https://github.com/apache/james-project/pull/755#issuecomment-979694103
Checkstyle errors:
```
04:42:46,299 [ERROR] src/main/java/org/apache/james/server/core/MimeMessageInputStreamSource.java:[52] (whitespace) EmptyLineSeparator: 'METHOD_DEF' should be separated from previous statement.
04:42:46,299 [ERROR] src/main/java/org/apache/james/server/core/MimeMessageInputStreamSource.java:[58] (whitespace) EmptyLineSeparator: 'VARIABLE_DEF' should be separated from previous statement.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #755: JAMES-3487 Java property: MimeMessageInputStreamSource THRESHOLD
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #755:
URL: https://github.com/apache/james-project/pull/755#issuecomment-975303296
> Did not expect anyone to find one so soon :-)
That's why I was enthousiastic about your proposal ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #755: JAMES-3487 Java property: MimeMessageInputStreamSource THRESHOLD
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #755:
URL: https://github.com/apache/james-project/pull/755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #755: JAMES-3487 Java property: MimeMessageInputStreamSource THRESHOLD
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #755:
URL: https://github.com/apache/james-project/pull/755#issuecomment-976369983
I am glad these settings are more readily available, I can't help but wonder if introducing a parallel (and poorer) configuration file system is really a good move though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ottoka commented on pull request #755: JAMES-3487 Java property: MimeMessageInputStreamSource THRESHOLD
Posted by GitBox <gi...@apache.org>.
ottoka commented on pull request #755:
URL: https://github.com/apache/james-project/pull/755#issuecomment-975256468
Nice to see there is actually a good use for jvm.properties. Did not expect anyone to find one so soon :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org